[Buildroot] [PATCH 1/1] system/Config.in: disable openrc with uclibc

[Buildroot] [PATCH 1/1] system/Config.in: disable openrc with uclibc

[Fabrice Fontaine]

openrc raises the following uclibc build failures since bump to version
0.51 in commit 730c90faa3ec13ee1ead47113c9c5c7d3a8dac55:

../src/rc-abort/rc-abort.c: In function 'main':
../src/rc-abort/rc-abort.c:27:21: error: implicit declaration of function 'kill'; did you mean 'killpg'? [-Werror=implicit-function-declaration]
   27 |                 if (kill(pid, SIGUSR1) != 0)
      |                     ^~~~
      |                     killpg

../src/libeinfo/libeinfo.c: In function 'colour_terminal':
../src/libeinfo/libeinfo.c:319:26: error: implicit declaration of function 'fileno' [-Werror=implicit-function-declaration]
  319 |         if (f && !isatty(fileno(f)))
      |                          ^~~~~~

../src/librc/librc-misc.c: In function 'rc_getfile':
../src/librc/librc-misc.c:79:14: error: implicit declaration of function 'fileno'; did you mean 'd_fileno'? [-Werror=implicit-function-declaration]
   79 |         fd = fileno(fp);
      |              ^~~~~~
      |              d_fileno

../src/librc/librc-daemon.c: In function 'rc_service_daemons_crashed':
../src/librc/librc-daemon.c:633:37: error: implicit declaration of function 'kill'; did you mean 'killpg'? [-Werror=implicit-function-declaration]
  633 |                                 if (kill(pid, 0) == -1 && errno == ESRCH)
      |                                     ^~~~
      |                                     killpg

These build failures could be fixed by patching openrc but upstream
is not happy with this patch: https://github.com/OpenRC/openrc/pull/674.

So, as advised by Yann E. Morin, openrc is hided away for uClibc, until
upstream has a proper fix.

Fixes:
 - http://autobuild.buildroot.org/results/494ef392a971ddb3c5c7b01e0149c6439018dbe7

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 system/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/system/Config.in b/system/Config.in
index 0b4dc9543e..b90e40e415 100644
--- a/system/Config.in
+++ b/system/Config.in
@@ -105,12 +105,13 @@ config BR2_INIT_OPENRC
 	bool "OpenRC"
 	depends on BR2_USE_MMU
 	depends on !BR2_STATIC_LIBS
+	depends on !BR2_TOOLCHAIN_BUILDROOT_UCLIBC
 	select BR2_PACKAGE_OPENRC
 	select BR2_PACKAGE_SKELETON_INIT_OPENRC if BR2_ROOTFS_SKELETON_DEFAULT
 
-comment "openrc needs a toolchain w/ dynamic library"
+comment "openrc needs a glibc or musl toolchain w/ dynamic library"
 	depends on BR2_USE_MMU
-	depends on BR2_STATIC_LIBS
+	depends on BR2_STATIC_LIBS && BR2_TOOLCHAIN_BUILDROOT_UCLIBC
 
 # In Buildroot, we decided not to support a split-usr when systemd is
 # used as an init system. This is a design decision, not a systemd
-- 
2.42.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] system/Config.in: disable openrc with uclibc

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > openrc raises the following uclibc build failures since bump to version
 > 0.51 in commit 730c90faa3ec13ee1ead47113c9c5c7d3a8dac55:

 > ../src/rc-abort/rc-abort.c: In function 'main':
 > ../src/rc-abort/rc-abort.c:27:21: error: implicit declaration of
 > function 'kill'; did you mean 'killpg'?
 > [-Werror=implicit-function-declaration]
 >    27 |                 if (kill(pid, SIGUSR1) != 0)
 >       |                     ^~~~
 >       |                     killpg

 > ../src/libeinfo/libeinfo.c: In function 'colour_terminal':
 > ../src/libeinfo/libeinfo.c:319:26: error: implicit declaration of function 'fileno' [-Werror=implicit-function-declaration]
 >   319 |         if (f && !isatty(fileno(f)))
 >       |                          ^~~~~~

 > ../src/librc/librc-misc.c: In function 'rc_getfile':
 > ../src/librc/librc-misc.c:79:14: error: implicit declaration of
 > function 'fileno'; did you mean 'd_fileno'?
 > [-Werror=implicit-function-declaration]
 >    79 |         fd = fileno(fp);
 >       |              ^~~~~~
 >       |              d_fileno

 > ../src/librc/librc-daemon.c: In function 'rc_service_daemons_crashed':
 > ../src/librc/librc-daemon.c:633:37: error: implicit declaration of
 > function 'kill'; did you mean 'killpg'?
 > [-Werror=implicit-function-declaration]
 >   633 |                                 if (kill(pid, 0) == -1 && errno == ESRCH)
 >       |                                     ^~~~
 >       |                                     killpg

 > These build failures could be fixed by patching openrc but upstream
 > is not happy with this patch: https://github.com/OpenRC/openrc/pull/674.

 > So, as advised by Yann E. Morin, openrc is hided away for uClibc, until
 > upstream has a proper fix.

 > Fixes:
 >  - http://autobuild.buildroot.org/results/494ef392a971ddb3c5c7b01e0149c6439018dbe7

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

I was going to say that such things are normally fixed by defining
_GNU_SOURCE, E.G. we could do

OPENRC_CFLAGS=$(TARGET_CFLAGS) -D_GNU_SOURCE

But indeed, upstream doesn't seem very receptive - So lets drop uClibc
support.

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] system/Config.in: disable openrc with uclibc

[Yann E. MORIN]

Fabrice, All,

On 2023-11-28 20:46 +0100, Fabrice Fontaine spake thusly:
[--SNIP--]
> So, as advised by Yann E. Morin, openrc is hided away for uClibc, until
> upstream has a proper fix.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/494ef392a971ddb3c5c7b01e0149c6439018dbe7
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  system/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/system/Config.in b/system/Config.in
> index 0b4dc9543e..b90e40e415 100644
> --- a/system/Config.in
> +++ b/system/Config.in
> @@ -105,12 +105,13 @@ config BR2_INIT_OPENRC
>  	bool "OpenRC"
>  	depends on BR2_USE_MMU
>  	depends on !BR2_STATIC_LIBS
> +	depends on !BR2_TOOLCHAIN_BUILDROOT_UCLIBC

Err, no; the proper symbol is BR2_TOOLCHAIN_USES_UCLIBC:
    https://buildroot.org/downloads/manual/manual.html#dependencies-target-toolchain-options

Also, the dependency must be on the package itself. Indeed, the issue is
with the package, not with our use of init as an init system. So we need
the dependency on the package itself, and it is inherited in the init
system choice:

    config BR2_PACKAGE_OPENRC
        bool "openrc"
        depends on !BR2_TOOLCHAIN_USES_UCLIBC

and then:

    config BR2_INIT_OPENRC
        bool "openrc"
        depends on !BR2_TOOLCHAIN_USES_UCLIBC  # openrc

Regards,
Yann E. MORIN.

>  	select BR2_PACKAGE_OPENRC
>  	select BR2_PACKAGE_SKELETON_INIT_OPENRC if BR2_ROOTFS_SKELETON_DEFAULT
>  
> -comment "openrc needs a toolchain w/ dynamic library"
> +comment "openrc needs a glibc or musl toolchain w/ dynamic library"
>  	depends on BR2_USE_MMU
> -	depends on BR2_STATIC_LIBS
> +	depends on BR2_STATIC_LIBS && BR2_TOOLCHAIN_BUILDROOT_UCLIBC
>  
>  # In Buildroot, we decided not to support a split-usr when systemd is
>  # used as an init system. This is a design decision, not a systemd
> -- 
> 2.42.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot