From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Adam Duskett <adam.duskett@amarulasolutions.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3 06/10] package/sway: enable default-wallpaper support
Date: Thu, 21 Dec 2023 09:35:12 +0100 [thread overview]
Message-ID: <20231221093512.0130c521@windsurf> (raw)
In-Reply-To: <20231221001924.1356215-6-adam.duskett@amarulasolutions.com>
Hello,
On Wed, 20 Dec 2023 17:19:20 -0700
Adam Duskett <adam.duskett@amarulasolutions.com> wrote:
> +if BR2_PACKAGE_SWAY
> +
> +config BR2_PACKAGE_SWAY_DEFAULT_WALLPAPER
> + bool "Install default wallpaper"
> + select BR2_PACKAGE_SWAYBG
I don't have a hard feeling on this one, but why isn't this handled
like this:
ifeq ($(BR2_PACKAGE_SWAYBG),y)
SWAY_CONF_OPTS += -Ddefault-wallpaper=true
else
SWAY_CONF_OPTS += -Ddefault-wallpaper=false
endif
The swaybg package anyway has:
default y if BR2_PACKAGE_SWAY
So users are not likely to miss it "by default".
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-12-21 8:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 0:19 [Buildroot] [PATCH v3 01/10] package/wlroots: add hwdata and hwdata_pnp_ids as a dependency Adam Duskett
2023-12-21 0:19 ` [Buildroot] [PATCH v3 02/10] package/dmenu-wayland: new package Adam Duskett
2023-12-21 8:33 ` Thomas Petazzoni via buildroot
2023-12-21 0:19 ` [Buildroot] [PATCH v3 03/10] package/foot: " Adam Duskett
2023-12-21 0:19 ` [Buildroot] [PATCH v3 04/10] package/ncurses: install foot terminfo if foot is selected Adam Duskett
2023-12-21 0:19 ` [Buildroot] [PATCH v3 05/10] package/sway: enable bash-completion support Adam Duskett
2023-12-21 0:19 ` [Buildroot] [PATCH v3 06/10] package/sway: enable default-wallpaper support Adam Duskett
2023-12-21 8:35 ` Thomas Petazzoni via buildroot [this message]
2023-12-21 14:40 ` Adam Duskett
2023-12-21 0:19 ` [Buildroot] [PATCH v3 07/10] package/sway: enable swaybar support Adam Duskett
2023-12-21 0:19 ` [Buildroot] [PATCH v3 08/10] package/sway: enable swaybar tray support Adam Duskett
2023-12-21 0:19 ` [Buildroot] [PATCH v3 09/10] package/sway: enable swaynag support Adam Duskett
2023-12-21 0:19 ` [Buildroot] [PATCH v3 10/10] package/sway/Config.in: Add a help note about the default terminal Adam Duskett
2023-12-21 8:31 ` [Buildroot] [PATCH v3 01/10] package/wlroots: add hwdata and hwdata_pnp_ids as a dependency Thomas Petazzoni via buildroot
2023-12-21 14:43 ` Adam Duskett
2023-12-22 8:19 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221093512.0130c521@windsurf \
--to=buildroot@buildroot.org \
--cc=adam.duskett@amarulasolutions.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox