Re: [Buildroot] [PATCH v3 01/10] package/wlroots: add hwdata and hwdata_pnp_ids as a dependency

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Adam,

On Thu, 21 Dec 2023 07:43:37 -0700
Adam Duskett <adam.duskett@amarulasolutions.com> wrote:

> > > hwdata = dependency('hwdata', required: false, native: true)
> > > if hwdata.found()
> > >       hwdata_dir = hwdata.get_variable(pkgconfig: 'pkgdatadir')
> > >       pnp_ids = files(hwdata_dir / 'pnp.ids')
> > > else
> > >       pnp_ids = files('/usr/share/hwdata/pnp.ids')
> > > endif  
> >
> > But does that mean they are actually used, unconditionally, by wlroots?
> > Yes, this sets a path in meson, and then? Yes, they *might* be used,
> > but how mandatory are those pnp.ids?
> >  
> The build fails without hwdata and the pnp ids.

Then please mention this in the commit log, with the error message.
This sort of detail should really be part of all your commit messages.
Each time you write a commit message, you should ask yourself "what
will the person reviewing this patch, who hasn't looked into the issue
I'm trying to solve, would need to know to understand the issue and be
convinced that my patch is the correct fix".

Also, if there is a build failure, is the build failure visible in our
autobuilders? If yes, please add a reference. If not, please say so in
the commit log. According to
http://autobuild.buildroot.net/?reason=wlroots% it seems like we didn't
catch this error. Why? Does it happen only under very specific
circumstances?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot