From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Maxim Kochetkov via buildroot <buildroot@buildroot.org>
Cc: Maxim Kochetkov <fido_max@inbox.ru>
Subject: Re: [Buildroot] [PATCH 1/1] package/postgresql: bump version to 16.1
Date: Sat, 23 Dec 2023 18:39:47 +0100 [thread overview]
Message-ID: <20231223183947.1586f122@windsurf> (raw)
In-Reply-To: <20231219075352.1048958-1-fido_max@inbox.ru>
On Tue, 19 Dec 2023 10:53:52 +0300
Maxim Kochetkov via buildroot <buildroot@buildroot.org> wrote:
> +ifeq ($(BR2_PACKAGE_ICU),y)
> +POSTGRESQL_DEPENDENCIES += icu
> +POSTGRESQL_CONF_OPTS += --with-icu
> +else
> +POSTGRESQL_CONF_OPTS += --without-icu
> +endif
Unless I'm wrong, this change is unrelated to the bump to 16.1. The
--with-icu/--without-icu options already exist in the currently
packaged version of Postgresql in Buildroot. Therefore, could you split
this into two patches?
Thanks a lot,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-12-23 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 7:53 [Buildroot] [PATCH 1/1] package/postgresql: bump version to 16.1 Maxim Kochetkov via buildroot
2023-12-23 17:39 ` Thomas Petazzoni via buildroot [this message]
2023-12-24 14:54 ` Maxim Kochetkov via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231223183947.1586f122@windsurf \
--to=buildroot@buildroot.org \
--cc=fido_max@inbox.ru \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox