[Buildroot] [PATCH 1/1] package/postgresql: bump version to 16.1

[Buildroot] [PATCH 1/1] package/postgresql: bump version to 16.1

[Maxim Kochetkov via buildroot]

Release notes: https://www.postgresql.org/docs/release/16.1/

Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
---
 package/postgresql/postgresql.hash | 4 ++--
 package/postgresql/postgresql.mk   | 9 ++++++++-
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/package/postgresql/postgresql.hash b/package/postgresql/postgresql.hash
index 4fc3bfcff0..cf859e3505 100644
--- a/package/postgresql/postgresql.hash
+++ b/package/postgresql/postgresql.hash
@@ -1,4 +1,4 @@
-# From https://ftp.postgresql.org/pub/source/v15.4/postgresql-15.5.tar.bz2.sha256
-sha256  8f53aa95d78eb8e82536ea46b68187793b42bba3b4f65aa342f540b23c9b10a6  postgresql-15.5.tar.bz2
+# From https://ftp.postgresql.org/pub/source/v16.1/postgresql-16.1.tar.bz2.sha256
+sha256  ce3c4d85d19b0121fe0d3f8ef1fa601f71989e86f8a66f7dc3ad546dd5564fec  postgresql-16.1.tar.bz2
 # License file, Locally calculated
 sha256  1a7d13c3ab31961b91ba256f77d6e82e0b54bf992253060fe93bdb5466df416a  COPYRIGHT
diff --git a/package/postgresql/postgresql.mk b/package/postgresql/postgresql.mk
index 3108fe65e1..ec5b61b932 100644
--- a/package/postgresql/postgresql.mk
+++ b/package/postgresql/postgresql.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-POSTGRESQL_VERSION = 15.5
+POSTGRESQL_VERSION = 16.1
 POSTGRESQL_SOURCE = postgresql-$(POSTGRESQL_VERSION).tar.bz2
 POSTGRESQL_SITE = https://ftp.postgresql.org/pub/source/v$(POSTGRESQL_VERSION)
 POSTGRESQL_LICENSE = PostgreSQL
@@ -87,6 +87,13 @@ else
 POSTGRESQL_CONF_OPTS += --without-ldap
 endif
 
+ifeq ($(BR2_PACKAGE_ICU),y)
+POSTGRESQL_DEPENDENCIES += icu
+POSTGRESQL_CONF_OPTS += --with-icu
+else
+POSTGRESQL_CONF_OPTS += --without-icu
+endif
+
 ifeq ($(BR2_PACKAGE_LIBXML2),y)
 POSTGRESQL_DEPENDENCIES += libxml2
 POSTGRESQL_CONF_OPTS += --with-libxml
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/postgresql: bump version to 16.1

[Thomas Petazzoni via buildroot]

On Tue, 19 Dec 2023 10:53:52 +0300
Maxim Kochetkov via buildroot <buildroot@buildroot.org> wrote:

> +ifeq ($(BR2_PACKAGE_ICU),y)
> +POSTGRESQL_DEPENDENCIES += icu
> +POSTGRESQL_CONF_OPTS += --with-icu
> +else
> +POSTGRESQL_CONF_OPTS += --without-icu
> +endif

Unless I'm wrong, this change is unrelated to the bump to 16.1. The
--with-icu/--without-icu options already exist in the currently
packaged version of Postgresql in Buildroot. Therefore, could you split
this into two patches?

Thanks a lot,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/postgresql: bump version to 16.1

[Maxim Kochetkov via buildroot]

On 23.12.2023 20:39, Thomas Petazzoni via buildroot wrote:
> On Tue, 19 Dec 2023 10:53:52 +0300
> Maxim Kochetkov via buildroot <buildroot@buildroot.org> wrote:
> 
>> +ifeq ($(BR2_PACKAGE_ICU),y)
>> +POSTGRESQL_DEPENDENCIES += icu
>> +POSTGRESQL_CONF_OPTS += --with-icu
>> +else
>> +POSTGRESQL_CONF_OPTS += --without-icu
>> +endif
> 
> Unless I'm wrong, this change is unrelated to the bump to 16.1. The

https://www.postgresql.org/docs/release/16.0/

.....
Build ICU support by default (Jeff Davis)

This removes build flag --with-icu and adds flag --without-icu.
.....


There will be configure error if ICU is not available:
....
checking for icu-uc icu-i18n... no
configure: error: ICU library not found
If you have ICU already installed, see config.log for details on the
failure.  It is possible the compiler isn't looking in the proper directory.
Use --without-icu to disable ICU support.
....

So we have to provide --without-icu or add ICU dependency

> --with-icu/--without-icu options already exist in the currently
> packaged version of Postgresql in Buildroot. Therefore, could you split

I see no such options in the current package/postgresql.

> this into two patches?

Correct bump is not possible without ifeq ($(BR2_PACKAGE_ICU),y)

> 
> Thanks a lot,
> 
> Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot