Re: [Buildroot] [PATCH 6/6] package/google-breakpad: bump version to f49c2f1a2023da0cb055874fba050563dfea57db

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Adam,

Thanks for this patch! I have applied, but after doing a number of
changes because as-is the change was not building correctly (I will
provide more details below on what the issues were).

On Sat,  2 Dec 2023 21:18:39 -0700
Adam Duskett <adam.duskett@amarulasolutions.com> wrote:

>   - Drop no longer needed 0001-add-cstdint-to-minidump_descriptor.h.patch
> 
>   - Rename 0002-dont-include-stab.h.patch to 0001-dont-include-stab.h.patch
>     and refactor so it applies cleanly.

I dropped this part, because I did not include the fix that allows
building with uClibc at this point (I will reply separately to PATCH
5/6 about this).

> -GOOGLE_BREAKPAD_VERSION = c85eb4a59b618f3beaad5445ceb1f865ffa8efdf
> +GOOGLE_BREAKPAD_VERSION = f49c2f1a2023da0cb055874fba050563dfea57db
>  GOOGLE_BREAKPAD_SITE = https://chromium.googlesource.com/breakpad/breakpad
>  GOOGLE_BREAKPAD_SITE_METHOD = git
>  GOOGLE_BREAKPAD_INSTALL_STAGING = YES
> -GOOGLE_BREAKPAD_LICENSE = BSD-3-Clause, MIT
> +GOOGLE_BREAKPAD_LICENSE = Apache-2.0, Clarified Artistic License, gedcurl, BSD-3-Clause, GPL-2.0, MIT

"gedcurl" wasn't a valid SPDX identifier, based on the LICENSE file, I
assumed it was for the curl license, which is known simply as "curl" in
the SPDX spec.

"Clarified Artistic License" is now as "ClArtistic" in the SPDX
specification.

However, some of those licenses are actually not relevant, because they
are used only for Mac code, or for the autotools machinery that doesn't
go into the target. So I looked at all the licenses of LICENSE one by
one, which gave this:

+# APSL-2.0, BSD-4-Clause, Apache-2.0, BSD-2-Clause not listed, only
+# used for Mac code, GPL-2.0 not listed, only used for autotools code
+GOOGLE_BREAKPAD_LICENSE = \
+       BSD-3-Clause, \
+       Unicode-DFS-2015 (UTF code), \
+       MIT (src/common/linux/breakpad_getcontext.S), \
+       curl (src/third_party/curl/), \
+       ClArtistic (src/third_party/libdisasm)

Hopefully I got it right, because it was a bit tricky. I'm definitely
open to review/suggestions on this as I might have gotten it wrong.

Now, to the things that were problematic:

- This new version has a mandatory dependency on zlib, without which
  the build simply fails.

- This new version has an optional dependency on zstd, which needs to
  be disabled explicitly to avoid build failures. And also AUTORECONF =
  YES is needed because the pre-generated configure/Makefile.in is out
  of date, and tries to link with -lzstd even if --disable-zstd is
  passed.

So I had to add the following changes:

-GOOGLE_BREAKPAD_DEPENDENCIES = host-google-breakpad linux-syscall-support
+# Needed because the configure/Makefile.in provided in the Git
+# repository is out of date, and links with -lzstd even if
+# --disable-zstd is passed
+GOOGLE_BREAKPAD_AUTORECONF = YES
+GOOGLE_BREAKPAD_DEPENDENCIES = host-google-breakpad linux-syscall-support zlib
+GOOGLE_BREAKPAD_CONF_OPTS = --disable-zstd
 
-HOST_GOOGLE_BREAKPAD_DEPENDENCIES = host-linux-syscall-support
+HOST_GOOGLE_BREAKPAD_DEPENDENCIES = host-linux-syscall-support host-zlib
+HOST_GOOGLE_BREAKPAD_CONF_OPTS = --disable-zstd

To get breakpad to build properly in this new version (as well as
"select BR2_PACKAGE_ZLIB" in the Config.in).

Applied with those fixes. Thanks for the contribution!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot