From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Adam Duskett <adam.duskett@amarulasolutions.com>
Cc: Pascal Huerst <pascal.huerst@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 5/6] package/google-breakpad: add 0002-dont-include-stab.h.patch
Date: Sun, 24 Dec 2023 11:59:11 +0100 [thread overview]
Message-ID: <20231224115911.0f3f687b@windsurf> (raw)
In-Reply-To: <20231203041841.492885-5-adam.duskett@amarulasolutions.com>
Hello Adam,
On Sat, 2 Dec 2023 21:18:38 -0700
Adam Duskett <adam.duskett@amarulasolutions.com> wrote:
> diff --git a/package/google-breakpad/0002-dont-include-stab.h.patch b/package/google-breakpad/0002-dont-include-stab.h.patch
> new file mode 100644
> index 0000000000..0817f1928f
> --- /dev/null
> +++ b/package/google-breakpad/0002-dont-include-stab.h.patch
> @@ -0,0 +1,103 @@
> +From 569af712da94637091080943f6a0d69ccb35864e Mon Sep 17 00:00:00 2001
> +From: Khem Raj <raj.khem@gmail.com>
> +Date: Thu, 14 Sep 2017 23:24:08 -0700
> +Subject: [PATCH] don't include stab.h
> +
> +From openembeddeds patch found at the following path:
> +meta-oe/recipes-devtools/breakpad/breakpad/0003-Dont-include-stab.h.patch
> +
> + - Backported to c85eb4a59b618f3beaad5445ceb1f865ffa8efdf
> + - Added || defined(__UCLIBC__) in stabs_reader.h, as uClibc provides the
> + a.out.h file but does not include the N_* macros.
> +
> +Upstream: Pending
> +
> +Signed-off-by: Khem Raj <raj.khem@gmail.com>
> +[Backported to c85eb4a59b618f3beaad5445ceb1f865ffa8efdf]
> +Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
I am not too sure about wanting to include this patch. The patch has
been written in 2017 apparently, and it says "Upstream: Pending", but I
couldn't find it having been submitted anywhere. So it's really a patch
that apparently has never been submitted upstream, which we would carry
forever. So unless someone has a particular interested in getting
google-breakpad to work on uClibc systems, who would take care of
taking the time to upstream this change, I'd prefer to keep
google-breakpad available only for glibc configurations for now. If the
patch was being submitted upstream, I would be fully OK to include it
in Buildroot.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-12-24 10:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-03 4:18 [Buildroot] [PATCH 1/6] package/google-breakpad/gen-syms.sh: fix shellcheck warnings Adam Duskett
2023-12-03 4:18 ` [Buildroot] [PATCH 2/6] package/google-breakpad: disable uclibc support Adam Duskett
2023-12-23 21:25 ` Thomas Petazzoni via buildroot
2024-01-09 12:51 ` Peter Korsgaard
2024-01-09 13:33 ` Baruch Siach via buildroot
2024-01-09 13:37 ` Peter Korsgaard
2023-12-03 4:18 ` [Buildroot] [PATCH 3/6] package/google-breakpad: fix building on newer systems Adam Duskett
2023-12-23 21:22 ` Thomas Petazzoni via buildroot
2024-01-09 12:51 ` Peter Korsgaard
2023-12-03 4:18 ` [Buildroot] [PATCH 4/6] support/testing/tests/package/test_google_breakpad.py: new runtime test Adam Duskett
2023-12-24 11:09 ` Thomas Petazzoni via buildroot
2024-01-09 12:58 ` Peter Korsgaard
2023-12-03 4:18 ` [Buildroot] [PATCH 5/6] package/google-breakpad: add 0002-dont-include-stab.h.patch Adam Duskett
2023-12-24 10:59 ` Thomas Petazzoni via buildroot [this message]
2023-12-03 4:18 ` [Buildroot] [PATCH 6/6] package/google-breakpad: bump version to f49c2f1a2023da0cb055874fba050563dfea57db Adam Duskett
2023-12-24 10:56 ` Thomas Petazzoni via buildroot
2023-12-23 21:22 ` [Buildroot] [PATCH 1/6] package/google-breakpad/gen-syms.sh: fix shellcheck warnings Thomas Petazzoni via buildroot
2024-01-09 12:51 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231224115911.0f3f687b@windsurf \
--to=buildroot@buildroot.org \
--cc=adam.duskett@amarulasolutions.com \
--cc=pascal.huerst@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox