[Buildroot] [PATCH 1/1] package/sentry-cli: needs host-libopenssl

[Buildroot] [PATCH 1/1] package/sentry-cli: needs host-libopenssl

[Bernd Kuhls]

Fixes:
http://autobuild.buildroot.net/results/b86/b8613dc343c9ebb1470075a72ad86137ddddf5a7/

This build error did not occur prior to bumping libopenssl to 3.0.9 with
buildroot commit 3c66f65a6a549930870f2c0d98abb5ca9321d2a5

It first occured after a libopeenssl 3.x fixed was commit to buildroot
with commit 8382f0eb41bc12098f032c12781fb488aa63d901 here:
http://autobuild.buildroot.net/results/2df/2df940342007e1e3bcdc9defde3a8be1fef1a0b3/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
The rust build system and its dependency management are a complete
mystery to me, I can not provide more information.

 package/sentry-cli/sentry-cli.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/sentry-cli/sentry-cli.mk b/package/sentry-cli/sentry-cli.mk
index df419f81e1..9a05992853 100644
--- a/package/sentry-cli/sentry-cli.mk
+++ b/package/sentry-cli/sentry-cli.mk
@@ -9,6 +9,6 @@ SENTRY_CLI_SITE = $(call github,getsentry,sentry-cli,$(SENTRY_CLI_VERSION))
 SENTRY_CLI_LICENSE = BSD-3-clause
 SENTRY_CLI_LICENSE_FILES = LICENSE
 
-HOST_SENTRY_CLI_DEPENDENCIES = host-zlib
+HOST_SENTRY_CLI_DEPENDENCIES = host-pkgconf host-libopenssl host-zlib
 
 $(eval $(host-cargo-package))
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/sentry-cli: needs host-libopenssl

[Thomas Petazzoni via buildroot]

Hello Bernd,

+Adam, whom I believe has an interest in sentry-cli.

On Fri, 25 Aug 2023 18:17:54 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Fixes:
> http://autobuild.buildroot.net/results/b86/b8613dc343c9ebb1470075a72ad86137ddddf5a7/
> 
> This build error did not occur prior to bumping libopenssl to 3.0.9 with
> buildroot commit 3c66f65a6a549930870f2c0d98abb5ca9321d2a5
> 
> It first occured after a libopeenssl 3.x fixed was commit to buildroot
> with commit 8382f0eb41bc12098f032c12781fb488aa63d901 here:
> http://autobuild.buildroot.net/results/2df/2df940342007e1e3bcdc9defde3a8be1fef1a0b3/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

I've done a bit of research and investigation, and I believe the
problem is a bit more complex, and actually was introduced by your
commits 8382f0eb41bc12098f032c12781fb488aa63d901 and
961dc9d397c136181982a9c3add17f737e1b9e82 which aim at fixing the build
of sentry-cli with OpenSSL 3.x.

Indeed, prior to
8382f0eb41bc12098f032c12781fb488aa63d901/961dc9d397c136181982a9c3add17f737e1b9e82,
it was possible to build sentry-cli without OpenSSL (it would fail if
OpenSSL 3.x was built, due to incompatibility, but it would build fine
without OpenSSL).

You can experiment by yourself:

# Check out Buildroot just before 8382f0eb41bc12098f032c12781fb488aa63d901

$ git checkout dff67170f73959e6826ec3e87e892747f8d3a5fb
$ ./utils/docker-run make host-sentry-cli

# It builds just fine

# Now let's do it with host-openssl built before:
$ make clean
$ ./utils/docker-run make host-openssl
$ ./utils/docker-run make host-sentry-cli

# It will fail because sentry-cli doesn't play well with OpenSSL 3.x,
# and we are before your fixes.

Now, let's try with 961dc9d397c136181982a9c3add17f737e1b9e82, which
after the two commits to sentry-cli fixing OpenSSL 3.x build

$ git checkout 961dc9d397c136181982a9c3add17f737e1b9e82

# First, with host-openssl:
$ ./utils/docker-run make host-sentry-cli

# It fails to build

# Then, with host-openssl
$ make clean
$ ./utils/docker-run make host-openssl
$ ./utils/docker-run make host-sentry-cli

# It also fails to build

So it looks like that the commits
8382f0eb41bc12098f032c12781fb488aa63d901 and
961dc9d397c136181982a9c3add17f737e1b9e82 rather than solving the
OpenSSL 3.x issue broke the build without OpenSSL, and with OpenSSL,
unless my experimentations above are wrong of course.

Could you have a deeper look into this? I strongly suggest using a
Docker container (as done above using docker-run), to be isolated from
a host provided OpenSSL.

Thanks a lot in advance for your additional research!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot