Re: [Buildroot] [PATCH v3 6/8] package/python-fastapi-sessions: new package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Marcin Niestroj <m.niestroj@grinn-global.com>,
	Asaf Kahlon <asafka7@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3 6/8] package/python-fastapi-sessions: new package
Date: Mon, 25 Dec 2023 21:24:15 +0100	[thread overview]
Message-ID: <20231225212415.3e6b7621@windsurf> (raw)
In-Reply-To: <20231214165420.181703-6-james.hilliard1@gmail.com>

Hello James,

On Thu, 14 Dec 2023 09:54:18 -0700
James Hilliard <james.hilliard1@gmail.com> wrote:

> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

I am applying this series, and I have a few questions on this patch.
They won't prevent applying the patch, they are more for my
curiosity/understanding.

> diff --git a/package/python-fastapi-sessions/Config.in b/package/python-fastapi-sessions/Config.in
> new file mode 100644
> index 0000000000..a54b072f09
> --- /dev/null
> +++ b/package/python-fastapi-sessions/Config.in
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_PYTHON_FASTAPI_SESSIONS
> +	bool "python-fastapi-sessions"
> +	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS # python-pydantic -> python-pydantic-core
> +	select BR2_PACKAGE_PYTHON_FASTAPI # runtime
> +	select BR2_PACKAGE_PYTHON_ITSDANGEROUS # runtime
> +	select BR2_PACKAGE_PYTHON_PYDANTIC # runtime

I indeed see pydantic imported in two places:

$ grep -r pydantic *
fastapi_sessions/backends/session_backend.py:from pydantic.main import BaseModel
fastapi_sessions/frontends/implementations/cookie.py:from pydantic.main import BaseModel

However, it's not listed in setup.py or pyproject.toml, even as an
optional dependency. Is this an upstream "bug" ?

> +PYTHON_FASTAPI_SESSIONS_VERSION = 0.3.2
> +PYTHON_FASTAPI_SESSIONS_SOURCE = fastapi-sessions-$(PYTHON_FASTAPI_SESSIONS_VERSION).tar.gz
> +PYTHON_FASTAPI_SESSIONS_SITE = https://files.pythonhosted.org/packages/1d/89/da83ba47bd70101e14eca0ac57c7f300b055b70104446badfdc1dcbe813f
> +PYTHON_FASTAPI_SESSIONS_SETUP_TYPE = setuptools

I see you're using plain old setuptools, but this package has a
pyproject.toml, though it doesn't define a [build-system]. Is this why
you can't use pep517?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot