Re: [Buildroot] [PATCH v3 6/8] package/python-fastapi-sessions: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello James,

On Mon, 25 Dec 2023 17:47:01 -0700
James Hilliard <james.hilliard1@gmail.com> wrote:

> > $ grep -r pydantic *
> > fastapi_sessions/backends/session_backend.py:from pydantic.main import BaseModel
> > fastapi_sessions/frontends/implementations/cookie.py:from pydantic.main import BaseModel
> >
> > However, it's not listed in setup.py or pyproject.toml, even as an
> > optional dependency. Is this an upstream "bug" ?  
> 
> I see it in setup.py here:
> https://github.com/jordanisaacs/fastapi-sessions/blob/be4126938011abd709fa18e9d9fc8a54c66a2130/setup.py#L12

Thanks for the feedback. Yann replied to you about what I didn't see
it: it's not in the tarball from pypi, and I always look at the code in
output/build/<pkg>-<version>/, which is the code really seen by
Buildroot.

> > I see you're using plain old setuptools, but this package has a
> > pyproject.toml, though it doesn't define a [build-system]. Is this why
> > you can't use pep517?  
> 
> A package with no [build-system] section in pyproject.toml per pep517
> falls back to the setuptools build backend.

Ah, OK, thanks for clarifying this.

> We can use a pep517 frontend with setuptools packages, see:
> https://patchwork.ozlabs.org/project/buildroot/patch/20231126180840.2081945-5-james.hilliard1@gmail.com/

ACK!

Thanks for those details, very useful.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot