From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: James Hilliard <james.hilliard1@gmail.com>,
Asaf Kahlon <asafka7@gmail.com>,
Brandon Maier <brandon.maier@collins.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2, 2/2] package/python-pysensors: add host-lm-sensors dependency
Date: Thu, 4 Jan 2024 11:44:20 +0100 [thread overview]
Message-ID: <20240104114420.0a1fb690@windsurf> (raw)
In-Reply-To: <CAPi7W83sQsbf-_SVva6QFpRhzg-YJ65UwKf+YeU2HRi_GVkt_w@mail.gmail.com>
Hello Fabrice,
On Thu, 4 Jan 2024 11:10:22 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> > Should just be moved directly to setup.py, and setup.py should not
> > import sensors. From a quick look, none of those variables are used
> > outside of setup.py. And of course this could be contributed upstream,
> > explaining why "import sensors" at setup time is not good.
>
> Indeed, this is a cleaner solution.
> However, it should be noted that upstream is dead: latest version is
> from 2019 and source code repository given on
> https://pypi.org/project/PySensors/ is unreachable.
Hm. Then maybe it wasn't such a good idea to add this package in
Buildroot in the first place? Even lm-sensors is not very well
maintained in fact.
Anyway, as an immediate fix, we can simply carry a patch in Buildroot.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-01-04 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 17:37 [Buildroot] [PATCH v2,1/2] package/lm-sensors: add host package Fabrice Fontaine
2024-01-03 17:37 ` [Buildroot] [PATCH v2, 2/2] package/python-pysensors: add host-lm-sensors dependency Fabrice Fontaine
2024-01-03 21:36 ` [Buildroot] [External] " Maier, Brandon L Collins via buildroot
2024-01-04 9:55 ` [Buildroot] " Thomas Petazzoni via buildroot
2024-01-04 10:10 ` Fabrice Fontaine
2024-01-04 10:44 ` Thomas Petazzoni via buildroot [this message]
2024-01-03 21:35 ` [Buildroot] [External] [PATCH v2, 1/2] package/lm-sensors: add host package Maier, Brandon L Collins via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240104114420.0a1fb690@windsurf \
--to=buildroot@buildroot.org \
--cc=asafka7@gmail.com \
--cc=brandon.maier@collins.com \
--cc=fontaine.fabrice@gmail.com \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox