[Buildroot] [PATCH v2,1/2] package/lm-sensors: add host package

[Buildroot] [PATCH v2,1/2] package/lm-sensors: add host package

[Fabrice Fontaine]

host package is needed by python-pysensors

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/lm-sensors/lm-sensors.mk | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/package/lm-sensors/lm-sensors.mk b/package/lm-sensors/lm-sensors.mk
index 1bf27fc25a..f085c8acb0 100644
--- a/package/lm-sensors/lm-sensors.mk
+++ b/package/lm-sensors/lm-sensors.mk
@@ -9,6 +9,7 @@ LM_SENSORS_SITE = \
 	$(call github,lm-sensors,lm-sensors,V$(subst .,-,$(LM_SENSORS_VERSION)))
 LM_SENSORS_INSTALL_STAGING = YES
 LM_SENSORS_DEPENDENCIES = host-bison host-flex
+HOST_LM_SENSORS_DEPENDENCIES = host-bison host-flex
 LM_SENSORS_LICENSE = LGPL-2.1+ (libsensors), GPL-2.0+ (programs)
 LM_SENSORS_LICENSE_FILES = COPYING.LGPL COPYING
 
@@ -50,4 +51,14 @@ define LM_SENSORS_INSTALL_TARGET_CMDS
 	rm -f $(addprefix $(TARGET_DIR)/usr/,$(LM_SENSORS_BINS_))
 endef
 
+define HOST_LM_SENSORS_BUILD_CMDS
+	$(HOST_MAKE_ENV) $(MAKE) PREFIX=/usr -C $(@D)
+endef
+
+define HOST_LM_SENSORS_INSTALL_CMDS
+	$(HOST_MAKE_ENV) $(MAKE) -C $(@D) PREFIX=/usr DESTDIR=$(HOST_DIR) install
+	rm -f $(addprefix $(HOST_DIR)/usr/,$(LM_SENSORS_BINS_) $(LM_SENSORS_BINS_y))
+endef
+
 $(eval $(generic-package))
+$(eval $(host-generic-package))
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2, 2/2] package/python-pysensors: add host-lm-sensors dependency

[Fabrice Fontaine]

host-lm-sensors is needed to extract the version from libsensors.so and
avoid the following build failure raised since the addition of the
package in commit c8ff8d41c06f6b1cbc5cf8702a516411084ead16:

  File "/home/buildroot/autobuild/instance-2/output-1/build/python-pysensors-0.0.4/setup.py", line 3, in <module>
    import sensors
  File "/home/buildroot/autobuild/instance-2/output-1/build/python-pysensors-0.0.4/sensors/__init__.py", line 20, in <module>
    raise ImportError("can't find the sensors library.")

Fixes:
 - http://autobuild.buildroot.org/results/acd8583fb635ea27811405a2478182ddcd5642f7

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2 (after review of Brandon Maier):
 - Replace lm-sensors dependency by host-lm-sensors and set SENSORS_LIB

 package/python-pysensors/Config.in           | 2 +-
 package/python-pysensors/python-pysensors.mk | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/package/python-pysensors/Config.in b/package/python-pysensors/Config.in
index f8e056506b..952d14c351 100644
--- a/package/python-pysensors/Config.in
+++ b/package/python-pysensors/Config.in
@@ -1,6 +1,6 @@
 config BR2_PACKAGE_PYTHON_PYSENSORS
 	bool "python-pysensors"
-	select BR2_PACKAGE_LM_SENSORS
+	select BR2_PACKAGE_LM_SENSORS # runtime
 	help
 	  Python bindings for libsensors.so from the lm-sensors project
 	  via ctypes. Supports API version 4, i.e. libsensors version
diff --git a/package/python-pysensors/python-pysensors.mk b/package/python-pysensors/python-pysensors.mk
index b38c47f0c8..d006109d41 100644
--- a/package/python-pysensors/python-pysensors.mk
+++ b/package/python-pysensors/python-pysensors.mk
@@ -9,5 +9,8 @@ PYTHON_PYSENSORS_SOURCE = PySensors-$(PYTHON_PYSENSORS_VERSION).tar.gz
 PYTHON_PYSENSORS_SITE = https://files.pythonhosted.org/packages/76/31/d3383a192f31ce1d79f27ec3d047cca23dd82a1bf0939e774386aba37cf5
 PYTHON_PYSENSORS_SETUP_TYPE = setuptools
 PYTHON_PYSENSORS_LICENSE = LGPL-2.1
+# host-lm-sensors is used to extract version of sensors library
+PYTHON_PYSENSORS_DEPENDENCIES = host-lm-sensors
+PYTHON_PYSENSORS_ENV = SENSORS_LIB=$(HOST_DIR)/usr/lib/libsensors.so
 
 $(eval $(python-package))
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [External] [PATCH v2, 1/2] package/lm-sensors: add host package

[Maier, Brandon L Collins via buildroot]

Hi Fabrice,

> -----Original Message-----
> From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> Sent: Wednesday, January 3, 2024 11:38 AM
> To: buildroot@buildroot.org
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>; James Hilliard
> <james.hilliard1@gmail.com>; Maier, Brandon L Collins
> <Brandon.Maier@collins.com>; Asaf Kahlon <asafka7@gmail.com>; Yegor
> Yefremov <yegorslists@googlemail.com>; Fabrice Fontaine
> <fontaine.fabrice@gmail.com>
> Subject: [External] [PATCH v2,1/2] package/lm-sensors: add host package
>
> host package is needed by python-pysensors
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/lm-sensors/lm-sensors.mk | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/package/lm-sensors/lm-sensors.mk b/package/lm-sensors/lm-
> sensors.mk
> index 1bf27fc25a..f085c8acb0 100644
> --- a/package/lm-sensors/lm-sensors.mk
> +++ b/package/lm-sensors/lm-sensors.mk
> @@ -9,6 +9,7 @@ LM_SENSORS_SITE = \
>       $(call github,lm-sensors,lm-sensors,V$(subst .,-
> ,$(LM_SENSORS_VERSION)))
>  LM_SENSORS_INSTALL_STAGING = YES
>  LM_SENSORS_DEPENDENCIES = host-bison host-flex
> +HOST_LM_SENSORS_DEPENDENCIES = host-bison host-flex
>  LM_SENSORS_LICENSE = LGPL-2.1+ (libsensors), GPL-2.0+ (programs)
>  LM_SENSORS_LICENSE_FILES = COPYING.LGPL COPYING
>
> @@ -50,4 +51,14 @@ define LM_SENSORS_INSTALL_TARGET_CMDS
>       rm -f $(addprefix $(TARGET_DIR)/usr/,$(LM_SENSORS_BINS_))
>  endef
>
> +define HOST_LM_SENSORS_BUILD_CMDS
> +     $(HOST_MAKE_ENV) $(MAKE) PREFIX=/usr -C $(@D)
> +endef
> +
> +define HOST_LM_SENSORS_INSTALL_CMDS
> +     $(HOST_MAKE_ENV) $(MAKE) -C $(@D) PREFIX=/usr
> DESTDIR=$(HOST_DIR) install
> +     rm -f $(addprefix $(HOST_DIR)/usr/,$(LM_SENSORS_BINS_)
> $(LM_SENSORS_BINS_y))
> +endef
> +
>  $(eval $(generic-package))
> +$(eval $(host-generic-package))
> --
> 2.43.0

Built this through run-docker and locally and it works now

Tested-by: Brandon Maier <brandon.maier@collins.com>

Thanks!
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [External] [PATCH v2, 2/2] package/python-pysensors: add host-lm-sensors dependency

[Maier, Brandon L Collins via buildroot]

> -----Original Message-----
> From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> Sent: Wednesday, January 3, 2024 11:38 AM
> To: buildroot@buildroot.org
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>; James Hilliard
> <james.hilliard1@gmail.com>; Maier, Brandon L Collins
> <Brandon.Maier@collins.com>; Asaf Kahlon <asafka7@gmail.com>; Yegor
> Yefremov <yegorslists@googlemail.com>; Fabrice Fontaine
> <fontaine.fabrice@gmail.com>
> Subject: [External] [PATCH v2,2/2] package/python-pysensors: add host-lm-
> sensors dependency
>
> host-lm-sensors is needed to extract the version from libsensors.so and
> avoid the following build failure raised since the addition of the
> package in commit c8ff8d41c06f6b1cbc5cf8702a516411084ead16:
>
>   File "/home/buildroot/autobuild/instance-2/output-1/build/python-
> pysensors-0.0.4/setup.py", line 3, in <module>
>     import sensors
>   File "/home/buildroot/autobuild/instance-2/output-1/build/python-
> pysensors-0.0.4/sensors/__init__.py", line 20, in <module>
>     raise ImportError("can't find the sensors library.")
>
> Fixes:
>  -
> https://urldefense.com/v3/__http://autobuild.buildroot.org/results/acd8583
> fb635ea27811405a2478182ddcd5642f7__;!!MvWE!C2Tu3sCb1T5sJd8w2lVX1T
> wgz2nQbtyb3-
> beoYlbDE0GJdOF7h9gXeeIjA8Nr5zOi2IoUmW49NxYnib2RS8hUkk38OsB_Q$
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Brandon Maier):
>  - Replace lm-sensors dependency by host-lm-sensors and set SENSORS_LIB
>
>  package/python-pysensors/Config.in           | 2 +-
>  package/python-pysensors/python-pysensors.mk | 3 +++
>  2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/package/python-pysensors/Config.in b/package/python-
> pysensors/Config.in
> index f8e056506b..952d14c351 100644
> --- a/package/python-pysensors/Config.in
> +++ b/package/python-pysensors/Config.in
> @@ -1,6 +1,6 @@
>  config BR2_PACKAGE_PYTHON_PYSENSORS
>       bool "python-pysensors"
> -     select BR2_PACKAGE_LM_SENSORS
> +     select BR2_PACKAGE_LM_SENSORS # runtime
>       help
>         Python bindings for libsensors.so from the lm-sensors project
>         via ctypes. Supports API version 4, i.e. libsensors version
> diff --git a/package/python-pysensors/python-pysensors.mk
> b/package/python-pysensors/python-pysensors.mk
> index b38c47f0c8..d006109d41 100644
> --- a/package/python-pysensors/python-pysensors.mk
> +++ b/package/python-pysensors/python-pysensors.mk
> @@ -9,5 +9,8 @@ PYTHON_PYSENSORS_SOURCE = PySensors-
> $(PYTHON_PYSENSORS_VERSION).tar.gz
>  PYTHON_PYSENSORS_SITE =
> https://urldefense.com/v3/__https://files.pythonhosted.org/packages/76/31/
> d3383a192f31ce1d79f27ec3d047cca23dd82a1bf0939e774386aba37cf5__;!!M
> vWE!C2Tu3sCb1T5sJd8w2lVX1Twgz2nQbtyb3-
> beoYlbDE0GJdOF7h9gXeeIjA8Nr5zOi2IoUmW49NxYnib2RS8hUkl-MSlL3g$
>  PYTHON_PYSENSORS_SETUP_TYPE = setuptools
>  PYTHON_PYSENSORS_LICENSE = LGPL-2.1
> +# host-lm-sensors is used to extract version of sensors library
> +PYTHON_PYSENSORS_DEPENDENCIES = host-lm-sensors
> +PYTHON_PYSENSORS_ENV =
> SENSORS_LIB=$(HOST_DIR)/usr/lib/libsensors.so
>
>  $(eval $(python-package))
> --
> 2.43.0

Tested-by: Brandon Maier <brandon.maier@collins.com>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2, 2/2] package/python-pysensors: add host-lm-sensors dependency

[Thomas Petazzoni via buildroot]

Hello Fabrice,

Thanks for the patch. See below some feedback.

On Wed,  3 Jan 2024 18:37:41 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> host-lm-sensors is needed to extract the version from libsensors.so and
> avoid the following build failure raised since the addition of the
> package in commit c8ff8d41c06f6b1cbc5cf8702a516411084ead16:
> 
>   File "/home/buildroot/autobuild/instance-2/output-1/build/python-pysensors-0.0.4/setup.py", line 3, in <module>
>     import sensors
>   File "/home/buildroot/autobuild/instance-2/output-1/build/python-pysensors-0.0.4/sensors/__init__.py", line 20, in <module>
>     raise ImportError("can't find the sensors library.")
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/acd8583fb635ea27811405a2478182ddcd5642f7

Does python-pysensors setup.py really need  the version of the
lm-sensors library?

I see this:

#!/usr/bin/env python3
from setuptools import setup
import sensors

setup(
    name='PySensors',
    version=sensors.__version__,
    author=sensors.__author__,
    author_email=sensors.__contact__,
    packages=['sensors'],
    # scripts=[],
    url='http://pypi.python.org/pypi/PySensors/',
    # download_url='',
    license=sensors.__license__,
    description='Python bindings to libsensors (via ctypes)',
    long_description=open('README.rst').read(),
    long_description_content_type="text/x-rst",
    keywords=['sensors', 'hardware', 'monitoring'],
    classifiers=[
        'Development Status :: 3 - Alpha',
        'Intended Audience :: Developers',
        'License :: OSI Approved',
        'License :: OSI Approved ::'
        ' GNU Lesser General Public License v2 or later (LGPLv2+)',
        'Operating System :: POSIX :: Linux',
        'Programming Language :: Python',
        'Programming Language :: Python :: 3',
        'Programming Language :: Python :: 3.6',
        'Programming Language :: Python :: Implementation',
        'Programming Language :: Python :: Implementation :: CPython',
        'Topic :: System',
        'Topic :: System :: Hardware',
        'Topic :: System :: Monitoring',
    ],
    python_requires=">=3.6",
)

So the "sensors" module is only being imported to get
sensors.__version__, sensors.__author__ and sensors.__contact__,
sensors.__license__, all of which are statically defined in the sensors
module.

So in practice, in the context of setup.py, this detection of the
lm-sensors version is not used. I believe:

__version__ = "0.0.4"
__date__ = "2019-09-19"
__author__ = "Marc 'BlackJack' Rintsch"
__contact__ = 'marc@rintsch.de'
__license__ = 'LGPL v2.1'

Should just be moved directly to setup.py, and setup.py should not
import sensors. From a quick look, none of those variables are used
outside of setup.py. And of course this could be contributed upstream,
explaining why "import sensors" at setup time is not good.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2, 2/2] package/python-pysensors: add host-lm-sensors dependency

[Fabrice Fontaine]

Hi Thomas,

Le jeu. 4 janv. 2024 à 10:55, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a écrit :
>
> Hello Fabrice,
>
> Thanks for the patch. See below some feedback.
>
> On Wed,  3 Jan 2024 18:37:41 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > host-lm-sensors is needed to extract the version from libsensors.so and
> > avoid the following build failure raised since the addition of the
> > package in commit c8ff8d41c06f6b1cbc5cf8702a516411084ead16:
> >
> >   File "/home/buildroot/autobuild/instance-2/output-1/build/python-pysensors-0.0.4/setup.py", line 3, in <module>
> >     import sensors
> >   File "/home/buildroot/autobuild/instance-2/output-1/build/python-pysensors-0.0.4/sensors/__init__.py", line 20, in <module>
> >     raise ImportError("can't find the sensors library.")
> >
> > Fixes:
> >  - http://autobuild.buildroot.org/results/acd8583fb635ea27811405a2478182ddcd5642f7
>
> Does python-pysensors setup.py really need  the version of the
> lm-sensors library?
>
> I see this:
>
> #!/usr/bin/env python3
> from setuptools import setup
> import sensors
>
> setup(
>     name='PySensors',
>     version=sensors.__version__,
>     author=sensors.__author__,
>     author_email=sensors.__contact__,
>     packages=['sensors'],
>     # scripts=[],
>     url='http://pypi.python.org/pypi/PySensors/',
>     # download_url='',
>     license=sensors.__license__,
>     description='Python bindings to libsensors (via ctypes)',
>     long_description=open('README.rst').read(),
>     long_description_content_type="text/x-rst",
>     keywords=['sensors', 'hardware', 'monitoring'],
>     classifiers=[
>         'Development Status :: 3 - Alpha',
>         'Intended Audience :: Developers',
>         'License :: OSI Approved',
>         'License :: OSI Approved ::'
>         ' GNU Lesser General Public License v2 or later (LGPLv2+)',
>         'Operating System :: POSIX :: Linux',
>         'Programming Language :: Python',
>         'Programming Language :: Python :: 3',
>         'Programming Language :: Python :: 3.6',
>         'Programming Language :: Python :: Implementation',
>         'Programming Language :: Python :: Implementation :: CPython',
>         'Topic :: System',
>         'Topic :: System :: Hardware',
>         'Topic :: System :: Monitoring',
>     ],
>     python_requires=">=3.6",
> )
>
> So the "sensors" module is only being imported to get
> sensors.__version__, sensors.__author__ and sensors.__contact__,
> sensors.__license__, all of which are statically defined in the sensors
> module.
>
> So in practice, in the context of setup.py, this detection of the
> lm-sensors version is not used. I believe:
>
> __version__ = "0.0.4"
> __date__ = "2019-09-19"
> __author__ = "Marc 'BlackJack' Rintsch"
> __contact__ = 'marc@rintsch.de'
> __license__ = 'LGPL v2.1'
>
> Should just be moved directly to setup.py, and setup.py should not
> import sensors. From a quick look, none of those variables are used
> outside of setup.py. And of course this could be contributed upstream,
> explaining why "import sensors" at setup time is not good.

Indeed, this is a cleaner solution.
However, it should be noted that upstream is dead: latest version is
from 2019 and source code repository given on
https://pypi.org/project/PySensors/ is unreachable.

>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com

Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2, 2/2] package/python-pysensors: add host-lm-sensors dependency

[Thomas Petazzoni via buildroot]

Hello Fabrice,

On Thu, 4 Jan 2024 11:10:22 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> > Should just be moved directly to setup.py, and setup.py should not
> > import sensors. From a quick look, none of those variables are used
> > outside of setup.py. And of course this could be contributed upstream,
> > explaining why "import sensors" at setup time is not good.  
> 
> Indeed, this is a cleaner solution.
> However, it should be noted that upstream is dead: latest version is
> from 2019 and source code repository given on
> https://pypi.org/project/PySensors/ is unreachable.

Hm. Then maybe it wasn't such a good idea to add this package in
Buildroot in the first place? Even lm-sensors is not very well
maintained in fact.

Anyway, as an immediate fix, we can simply carry a patch in Buildroot.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot