Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Matt Flax <flatmax@flatmax.com>
Cc: "Wojciech M . Zabolotny" <wzab01@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/jack2: Add example tools build option
Date: Wed, 10 Jan 2024 22:44:27 +0100	[thread overview]
Message-ID: <20240110224427.3eb96995@windsurf> (raw)
In-Reply-To: <20230331030455.1356986-1-flatmax@flatmax.com>

Hello Matt,

On Fri, 31 Mar 2023 14:04:55 +1100
Matt Flax <flatmax@flatmax.com> wrote:

> +ifeq ($(BR2_PACKAGE_JACK2_TOOLS),y)
> +JACK2_CONF_OPTS += --example-tools=yes
> +else
> +JACK2_CONF_OPTS += --example-tools=no
> +endif

Sorry for the very long delay in getting back to you. I finally wanted
to apply and merge this patch, but unfortunately it doesn't seem to
work. I'm getting the following build failure:

waf: error: no such option: --example-tools

and indeed, I don't see --example-tools in the output of waf options. I
see that this is most likely not your fault, as this option has been
removed from jack2. According to their Changelog:

* 1.9.22 (2023-02-02)

  * The waf autooption ``--example-tools`` has been removed.

So presumably, the option existed when you implemented the patch, but a
follow-up version bump of jack2 in Buildroot made us use 1.9.22, and
therefore the option is no longer available.

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-01-10 21:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31  3:04 [Buildroot] [PATCH 1/1] package/jack2: Add example tools build option Matt Flax
2024-01-10 21:44 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240110224427.3eb96995@windsurf \
    --to=buildroot@buildroot.org \
    --cc=flatmax@flatmax.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=wzab01@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox