[Buildroot] [PATCH 1/1] package/jack2: Add example tools build option

[Buildroot] [PATCH 1/1] package/jack2: Add example tools build option

[Matt Flax]

Signed-off-by: Matt Flax <flatmax@flatmax.com>
---
 package/jack2/Config.in | 7 +++++++
 package/jack2/jack2.mk  | 8 +++++++-
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/package/jack2/Config.in b/package/jack2/Config.in
index f5ac0399eb..d8717de426 100644
--- a/package/jack2/Config.in
+++ b/package/jack2/Config.in
@@ -23,6 +23,13 @@ config BR2_PACKAGE_JACK2

 if BR2_PACKAGE_JACK2

+config BR2_PACKAGE_JACK2_TOOLS
+	bool "example tools"
+	help
+	  Build jack's example tools like jack_connect, jack_lsp, etc.
+
+	  https://github.com/jackaudio/jack-example-tools/tree/main/tools
+
 config BR2_PACKAGE_JACK2_LEGACY
 	bool "classic jack2"
 	help
diff --git a/package/jack2/jack2.mk b/package/jack2/jack2.mk
index f7683304a6..5d6d9f6bc7 100644
--- a/package/jack2/jack2.mk
+++ b/package/jack2/jack2.mk
@@ -12,7 +12,13 @@ JACK2_CPE_ID_VENDOR = jackaudio
 JACK2_DEPENDENCIES = host-pkgconf alsa-lib
 JACK2_INSTALL_STAGING = YES

-JACK2_CONF_OPTS = --alsa --example-tools=no
+JACK2_CONF_OPTS = --alsa
+
+ifeq ($(BR2_PACKAGE_JACK2_TOOLS),y)
+JACK2_CONF_OPTS += --example-tools=yes
+else
+JACK2_CONF_OPTS += --example-tools=no
+endif

 ifeq ($(BR2_PACKAGE_LIBEXECINFO),y)
 JACK2_DEPENDENCIES += libexecinfo
--
2.37.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/jack2: Add example tools build option

[Thomas Petazzoni via buildroot]

Hello Matt,

On Fri, 31 Mar 2023 14:04:55 +1100
Matt Flax <flatmax@flatmax.com> wrote:

> +ifeq ($(BR2_PACKAGE_JACK2_TOOLS),y)
> +JACK2_CONF_OPTS += --example-tools=yes
> +else
> +JACK2_CONF_OPTS += --example-tools=no
> +endif

Sorry for the very long delay in getting back to you. I finally wanted
to apply and merge this patch, but unfortunately it doesn't seem to
work. I'm getting the following build failure:

waf: error: no such option: --example-tools

and indeed, I don't see --example-tools in the output of waf options. I
see that this is most likely not your fault, as this option has been
removed from jack2. According to their Changelog:

* 1.9.22 (2023-02-02)

  * The waf autooption ``--example-tools`` has been removed.

So presumably, the option existed when you implemented the patch, but a
follow-up version bump of jack2 in Buildroot made us use 1.9.22, and
therefore the option is no longer available.

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot