Re: [Buildroot] [PATCH] package/sway: make systemd optional

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Thu, 18 Jan 2024 01:28:34 +0100
Stefan Ott via buildroot <buildroot@buildroot.org> wrote:

>  if BR2_PACKAGE_SWAY
>  
> +choice BR2_PACKAGE_SWAY_SD_BUS_PROVIDER
> +	prompt "Provider of the sd-bus library"
> +	default BR2_PACKAGE_SWAY_SD_BUS_PROVIDER_AUTO
> +
> +config BR2_PACKAGE_SWAY_SD_BUS_PROVIDER_AUTO
> +	bool "auto"
> +
> +config BR2_PACKAGE_SWAY_SD_BUS_PROVIDER_LIBSYSTEMD
> +	bool "libsystemd"
> +	depends on BR2_PACKAGE_SYSTEMD
> +
> +comment "The systemd backend needs systemd"
> +	depends on !BR2_PACKAGE_SYSTEMD
> +endchoice

Thanks for your patch! I am wondering if adding an option for this is
needed. Can't we just enable systemd support when BR2_PACKAGE_SYSTEMD=y?

I think the fact that your comments is worded as "The systemd backend
needs systemd" is a good hint that this dependency is obvious, and
there's no need to have an explicit option for it.


> -	-Dsd-bus-provider=libsystemd
> +	-Dman-pages=disabled
> +
> +ifeq ($(BR2_PACKAGE_SWAY_SD_BUS_PROVIDER_LIBSYSTEMD),y)
> +SWAY_CONF_OPTS += -Dsd-bus-provider=libsystemd

Is there another sd-bus-provider option value that should be set when
systemd is not available?

> +SWAY_DEPENDENCIES += systemd
> +endif

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot