From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Stefan Ott <stefan@ott.net>
Cc: Raphael Pavlidis <raphael.pavlidis@gmail.com>,
Stefan Ott via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] package/sway: make systemd optional
Date: Thu, 18 Jan 2024 14:48:28 +0100 [thread overview]
Message-ID: <20240118144823.5105c00f@windsurf> (raw)
In-Reply-To: <20240118134301.GA81291@mort>
Hello Stefan,
On Thu, 18 Jan 2024 14:43:01 +0100
Stefan Ott <stefan@ott.net> wrote:
> That would indeed seem to be a more reasonable approach. The
> reason I chose to turn it into an option was to make the user
> aware of the fact that there is such an option at all and that
> they might get additional features when using systemd.
>
> Whether this is relevant or not, I cannot say. But if you think
> it would be acceptable to do it automatically, I'll update the
> patch accordingly.
There's rarely a super clear-cut way of deciding whether an option
should be added, or the dependency be handled implicitly/automatically.
But in this particular case, it seems relatively obvious to me. In
addition, the systemd integration is mostly relevant if you use systemd
as your init system, in which case systemd will anyway already be
enabled, and therefore the systemd support in sway will be
automagically enabled.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-01-18 13:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 0:28 [Buildroot] [PATCH] package/sway: make systemd optional Stefan Ott via buildroot
2024-01-18 12:58 ` Thomas Petazzoni via buildroot
2024-01-18 13:43 ` Stefan Ott via buildroot
2024-01-18 13:48 ` Thomas Petazzoni via buildroot [this message]
2024-01-19 2:11 ` [Buildroot] [PATCH v2] " Stefan Ott via buildroot
2024-01-19 11:26 ` Thomas Petazzoni via buildroot
2024-01-20 15:08 ` Stefan Ott via buildroot
2024-01-21 18:01 ` Raphael Pavlidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240118144823.5105c00f@windsurf \
--to=buildroot@buildroot.org \
--cc=raphael.pavlidis@gmail.com \
--cc=stefan@ott.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox