[Buildroot] [PATCH 1/1] package/bayer2rgb-neon: fix aarch64 build with BR2_OPTIMIZE_0

[Buildroot] [PATCH 1/1] package/bayer2rgb-neon: fix aarch64 build with BR2_OPTIMIZE_0

[Fabrice Fontaine]

Fix the following build failure with aarch64 and BR2_OPTIMIZE_0 raised
since commit 0512910e4901edcb78bb1daa4eb3be9bdc4dc8a9:

src/convert-neon-body-bayer8.inc.h: In function 'bayer2rgb_convert_neon':
src/convert-neon.c:233:17: error: third argument to '__builtin_prefetch' must be a constant
  233 |                 __builtin_prefetch(((void const *)(_addr)) + 64, 0, (_lvl)); \
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/convert-neon-body-bayer8.inc.h:8:9: note: in expansion of macro 'do_prefetch'
    8 |         do_prefetch(&in[+1*stride - 1], (rows_per_loop) < 3 ? 3 : 0);
      |         ^~~~~~~~~~~

Fixes:
 - http://autobuild.buildroot.org/results/307c1c448becd99dfba3a17b3ef816db0bb5cad6

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/bayer2rgb-neon/bayer2rgb-neon.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/bayer2rgb-neon/bayer2rgb-neon.mk b/package/bayer2rgb-neon/bayer2rgb-neon.mk
index 212fe76766..b0b9882def 100644
--- a/package/bayer2rgb-neon/bayer2rgb-neon.mk
+++ b/package/bayer2rgb-neon/bayer2rgb-neon.mk
@@ -19,6 +19,10 @@ ifeq ($(BR2_arm),y)
 BAYER2RGB_NEON_CFLAGS += -mfpu=neon
 endif
 
+ifeq ($(BR2_OPTIMIZE_0),y)
+BAYER2RGB_NEON_CFLAGS += -O1
+endif
+
 BAYER2RGB_NEON_CONF_ENV = CFLAGS="$(BAYER2RGB_NEON_CFLAGS)"
 
 $(eval $(autotools-package))
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/bayer2rgb-neon: fix aarch64 build with BR2_OPTIMIZE_0

[Thomas Petazzoni via buildroot]

On Sat,  6 Jan 2024 23:42:33 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fix the following build failure with aarch64 and BR2_OPTIMIZE_0 raised
> since commit 0512910e4901edcb78bb1daa4eb3be9bdc4dc8a9:
> 
> src/convert-neon-body-bayer8.inc.h: In function 'bayer2rgb_convert_neon':
> src/convert-neon.c:233:17: error: third argument to '__builtin_prefetch' must be a constant
>   233 |                 __builtin_prefetch(((void const *)(_addr)) + 64, 0, (_lvl)); \
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> src/convert-neon-body-bayer8.inc.h:8:9: note: in expansion of macro 'do_prefetch'
>     8 |         do_prefetch(&in[+1*stride - 1], (rows_per_loop) < 3 ? 3 : 0);
>       |         ^~~~~~~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/307c1c448becd99dfba3a17b3ef816db0bb5cad6
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/bayer2rgb-neon/bayer2rgb-neon.mk | 4 ++++
>  1 file changed, 4 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/bayer2rgb-neon: fix aarch64 build with BR2_OPTIMIZE_0

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > On Sat,  6 Jan 2024 23:42:33 +0100
 > Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

 >> Fix the following build failure with aarch64 and BR2_OPTIMIZE_0 raised
 >> since commit 0512910e4901edcb78bb1daa4eb3be9bdc4dc8a9:
 >> 
 >> src/convert-neon-body-bayer8.inc.h: In function 'bayer2rgb_convert_neon':
 >> src/convert-neon.c:233:17: error: third argument to '__builtin_prefetch' must be a constant
 >> 233 |                 __builtin_prefetch(((void const *)(_addr)) + 64, 0, (_lvl)); \
 >> |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 >> src/convert-neon-body-bayer8.inc.h:8:9: note: in expansion of macro 'do_prefetch'
 >> 8 |         do_prefetch(&in[+1*stride - 1], (rows_per_loop) < 3 ? 3 : 0);
 >> |         ^~~~~~~~~~~
 >> 
 >> Fixes:
 >> - http://autobuild.buildroot.org/results/307c1c448becd99dfba3a17b3ef816db0bb5cad6
 >> 
 >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 >> ---
 >> package/bayer2rgb-neon/bayer2rgb-neon.mk | 4 ++++
 >> 1 file changed, 4 insertions(+)

 > Applied to master, thanks.

Committed to 2023.02.x and 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot