* [Buildroot] [PATCH] package/python3: fix install
@ 2024-02-08 9:56 Roy Kollen Svendsen
2024-02-11 22:11 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 6+ messages in thread
From: Roy Kollen Svendsen @ 2024-02-08 9:56 UTC (permalink / raw)
To: buildroot
Cc: Roy Kollen Svendsen, James Hilliard, Asaf Kahlon,
Thomas Petazzoni
Fixes the following failure in the install step of host-python3:
...
/usr/bin/install -c -m 644 pyconfig.h output/host/include/python3.12/pyconfig.h
[ERROR] _tkinter failed to import: output/build/host-python3-3.12.1/build/lib.linux-x86_64-3.12/_tkinter.cpython-312-x86_64-linux-gnu.so: undefined symbol: Tcl_AddErrorInfo
The following modules are *disabled* in configure script:
_ctypes_test _testbuffer _testcapi
_testclinic _testimportmultiple _testinternalcapi
_testmultiphase _xxtestfuzz xxsubtype
Following modules built successfully but were removed because they could not be imported:
_tkinter
Checked 110 modules (31 built-in, 54 shared, 15 n/a on linux-x86_64, 9 disabled, 0 missing, 1 failed on import)
...
/usr/bin/install -c -m 644 ./Lib/types.py output/host/lib/python3.12
/usr/bin/install: cannot stat 'Modules/_tkinter.cpython-312-x86_64-linux-gnu.so': No such file or directory
/usr/bin/install -c -m 644 ./Lib/typing.py output/host/lib/python3.12
make[3]: *** [Makefile:2068: sharedinstall] Error 1
...
Signed-off-by: Roy Kollen Svendsen <roy.kollen.svendsen@akersolutions.com>
---
Changes v1 -> v2:
Make the --disable-tk option automatically set py_cv_module__tkinter=n/a (suggested by Thomas Petazzoni)
---
.../python3/0012-Add-an-option-to-disable-the-tk-module.patch | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/package/python3/0012-Add-an-option-to-disable-the-tk-module.patch b/package/python3/0012-Add-an-option-to-disable-the-tk-module.patch
index 7fafbedddb..08617241a6 100644
--- a/package/python3/0012-Add-an-option-to-disable-the-tk-module.patch
+++ b/package/python3/0012-Add-an-option-to-disable-the-tk-module.patch
@@ -62,7 +62,7 @@ diff --git a/configure.ac b/configure.ac
index c8ae60aa6b5..7caa361138d 100644
--- a/configure.ac
+++ b/configure.ac
-@@ -4503,6 +4503,11 @@ AC_ARG_ENABLE(pydoc,
+@@ -4503,6 +4503,13 @@ AC_ARG_ENABLE(pydoc,
AS_HELP_STRING([--disable-pydoc], [disable pydoc]),
[ PYDOC="${enableval}" ], [ PYDOC=yes ])
@@ -70,6 +70,8 @@ index c8ae60aa6b5..7caa361138d 100644
+AC_ARG_ENABLE(tk,
+ AS_HELP_STRING([--disable-tk], [disable tk]),
+ [ TK="${enableval}" ], [ TK=yes ])
++AS_IF([test "$TK" = "no"],
++ [PY_STDLIB_MOD_SET_NA([_tkinter])])
+
# Check for enable-ipv6
AH_TEMPLATE([ENABLE_IPV6], [Define if --enable-ipv6 is specified])
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Buildroot] [PATCH] package/python3: fix install
2024-02-08 9:56 [Buildroot] [PATCH] package/python3: fix install Roy Kollen Svendsen
@ 2024-02-11 22:11 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-02-11 22:11 UTC (permalink / raw)
To: Roy Kollen Svendsen
Cc: Roy Kollen Svendsen, James Hilliard, Asaf Kahlon, buildroot
On Thu, 8 Feb 2024 10:56:14 +0100
Roy Kollen Svendsen <roykollensvendsen@gmail.com> wrote:
> Fixes the following failure in the install step of host-python3:
> ...
> /usr/bin/install -c -m 644 pyconfig.h output/host/include/python3.12/pyconfig.h
> [ERROR] _tkinter failed to import: output/build/host-python3-3.12.1/build/lib.linux-x86_64-3.12/_tkinter.cpython-312-x86_64-linux-gnu.so: undefined symbol: Tcl_AddErrorInfo
> The following modules are *disabled* in configure script:
> _ctypes_test _testbuffer _testcapi
> _testclinic _testimportmultiple _testinternalcapi
> _testmultiphase _xxtestfuzz xxsubtype
>
> Following modules built successfully but were removed because they could not be imported:
> _tkinter
>
> Checked 110 modules (31 built-in, 54 shared, 15 n/a on linux-x86_64, 9 disabled, 0 missing, 1 failed on import)
> ...
> /usr/bin/install -c -m 644 ./Lib/types.py output/host/lib/python3.12
> /usr/bin/install: cannot stat 'Modules/_tkinter.cpython-312-x86_64-linux-gnu.so': No such file or directory
> /usr/bin/install -c -m 644 ./Lib/typing.py output/host/lib/python3.12
> make[3]: *** [Makefile:2068: sharedinstall] Error 1
> ...
>
> Signed-off-by: Roy Kollen Svendsen <roy.kollen.svendsen@akersolutions.com>
> ---
> Changes v1 -> v2:
> Make the --disable-tk option automatically set py_cv_module__tkinter=n/a (suggested by Thomas Petazzoni)
> ---
> .../python3/0012-Add-an-option-to-disable-the-tk-module.patch | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied to master after improving the commit title, and extending the
commit log to indicate which commit this is fixing.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/python3: fix install
@ 2024-02-08 9:41 Roy Kollen Svendsen
0 siblings, 0 replies; 6+ messages in thread
From: Roy Kollen Svendsen @ 2024-02-08 9:41 UTC (permalink / raw)
To: buildroot
Cc: Roy Kollen Svendsen, James Hilliard, Thomas Petazzoni,
Asaf Kahlon
Fixes the following failure in the install step of host-python3:
...
/usr/bin/install -c -m 644 pyconfig.h output/host/include/python3.12/pyconfig.h
[ERROR] _tkinter failed to import: output/build/host-python3-3.12.1/build/lib.linux-x86_64-3.12/_tkinter.cpython-312-x86_64-linux-gnu.so: undefined symbol: Tcl_AddErrorInfo
The following modules are *disabled* in configure script:
_ctypes_test _testbuffer _testcapi
_testclinic _testimportmultiple _testinternalcapi
_testmultiphase _xxtestfuzz xxsubtype
Following modules built successfully but were removed because they could not be imported:
_tkinter
Checked 110 modules (31 built-in, 54 shared, 15 n/a on linux-x86_64, 9 disabled, 0 missing, 1 failed on import)
...
/usr/bin/install -c -m 644 ./Lib/types.py output/host/lib/python3.12
/usr/bin/install: cannot stat 'Modules/_tkinter.cpython-312-x86_64-linux-gnu.so': No such file or directory
/usr/bin/install -c -m 644 ./Lib/typing.py output/host/lib/python3.12
make[3]: *** [Makefile:2068: sharedinstall] Error 1
...
Signed-off-by: Roy Kollen Svendsen <roy.kollen.svendsen@akersolutions.com>
---
Changes v1 -> v2:
Make the --disable-tk option automatically set py_cv_module__tkinter=n/a (suggested by Thomas Petazzoni)
---
.../python3/0012-Add-an-option-to-disable-the-tk-module.patch | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/package/python3/0012-Add-an-option-to-disable-the-tk-module.patch b/package/python3/0012-Add-an-option-to-disable-the-tk-module.patch
index 7fafbedddb..08617241a6 100644
--- a/package/python3/0012-Add-an-option-to-disable-the-tk-module.patch
+++ b/package/python3/0012-Add-an-option-to-disable-the-tk-module.patch
@@ -62,7 +62,7 @@ diff --git a/configure.ac b/configure.ac
index c8ae60aa6b5..7caa361138d 100644
--- a/configure.ac
+++ b/configure.ac
-@@ -4503,6 +4503,11 @@ AC_ARG_ENABLE(pydoc,
+@@ -4503,6 +4503,13 @@ AC_ARG_ENABLE(pydoc,
AS_HELP_STRING([--disable-pydoc], [disable pydoc]),
[ PYDOC="${enableval}" ], [ PYDOC=yes ])
@@ -70,6 +70,8 @@ index c8ae60aa6b5..7caa361138d 100644
+AC_ARG_ENABLE(tk,
+ AS_HELP_STRING([--disable-tk], [disable tk]),
+ [ TK="${enableval}" ], [ TK=yes ])
++AS_IF([test "$TK" = "no"],
++ [PY_STDLIB_MOD_SET_NA([_tkinter])])
+
# Check for enable-ipv6
AH_TEMPLATE([ENABLE_IPV6], [Define if --enable-ipv6 is specified])
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH] package/python3: fix install
@ 2024-02-08 9:38 Roy Kollen Svendsen
0 siblings, 0 replies; 6+ messages in thread
From: Roy Kollen Svendsen @ 2024-02-08 9:38 UTC (permalink / raw)
To: buildroot
Cc: Roy Kollen Svendsen, James Hilliard, Asaf Kahlon,
Thomas Petazzoni
Fixes the following failure in the install step of host-python3:
...
/usr/bin/install -c -m 644 pyconfig.h output/host/include/python3.12/pyconfig.h
[ERROR] _tkinter failed to import: output/build/host-python3-3.12.1/build/lib.linux-x86_64-3.12/_tkinter.cpython-312-x86_64-linux-gnu.so: undefined symbol: Tcl_AddErrorInfo
The following modules are *disabled* in configure script:
_ctypes_test _testbuffer _testcapi
_testclinic _testimportmultiple _testinternalcapi
_testmultiphase _xxtestfuzz xxsubtype
Following modules built successfully but were removed because they could not be imported:
_tkinter
Checked 110 modules (31 built-in, 54 shared, 15 n/a on linux-x86_64, 9 disabled, 0 missing, 1 failed on import)
...
/usr/bin/install -c -m 644 ./Lib/types.py output/host/lib/python3.12
/usr/bin/install: cannot stat 'Modules/_tkinter.cpython-312-x86_64-linux-gnu.so': No such file or directory
/usr/bin/install -c -m 644 ./Lib/typing.py output/host/lib/python3.12
make[3]: *** [Makefile:2068: sharedinstall] Error 1
...
Signed-off-by: Roy Kollen Svendsen <roy.kollen.svendsen@akersolutions.com>
---
Changes v1 -> v2:
Make the --disable-tk option automatically set py_cv_module__tkinter=n/a (suggested by Thomas Petazzoni)
---
.../python3/0012-Add-an-option-to-disable-the-tk-module.patch | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/package/python3/0012-Add-an-option-to-disable-the-tk-module.patch b/package/python3/0012-Add-an-option-to-disable-the-tk-module.patch
index 7fafbedddb..08617241a6 100644
--- a/package/python3/0012-Add-an-option-to-disable-the-tk-module.patch
+++ b/package/python3/0012-Add-an-option-to-disable-the-tk-module.patch
@@ -62,7 +62,7 @@ diff --git a/configure.ac b/configure.ac
index c8ae60aa6b5..7caa361138d 100644
--- a/configure.ac
+++ b/configure.ac
-@@ -4503,6 +4503,11 @@ AC_ARG_ENABLE(pydoc,
+@@ -4503,6 +4503,13 @@ AC_ARG_ENABLE(pydoc,
AS_HELP_STRING([--disable-pydoc], [disable pydoc]),
[ PYDOC="${enableval}" ], [ PYDOC=yes ])
@@ -70,6 +70,8 @@ index c8ae60aa6b5..7caa361138d 100644
+AC_ARG_ENABLE(tk,
+ AS_HELP_STRING([--disable-tk], [disable tk]),
+ [ TK="${enableval}" ], [ TK=yes ])
++AS_IF([test "$TK" = "no"],
++ [PY_STDLIB_MOD_SET_NA([_tkinter])])
+
# Check for enable-ipv6
AH_TEMPLATE([ENABLE_IPV6], [Define if --enable-ipv6 is specified])
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH] package/python3: fix install
@ 2024-02-08 7:49 Roy Kollen Svendsen
2024-02-08 8:01 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 6+ messages in thread
From: Roy Kollen Svendsen @ 2024-02-08 7:49 UTC (permalink / raw)
To: buildroot
Cc: Roy Kollen Svendsen, James Hilliard, Asaf Kahlon,
Thomas Petazzoni
Fixes the following failure in the install step of host-python3:
...
/usr/bin/install -c -m 644 pyconfig.h output/host/include/python3.12/pyconfig.h
[ERROR] _tkinter failed to import: output/build/host-python3-3.12.1/build/lib.linux-x86_64-3.12/_tkinter.cpython-312-x86_64-linux-gnu.so: undefined symbol: Tcl_AddErrorInfo
The following modules are *disabled* in configure script:
_ctypes_test _testbuffer _testcapi
_testclinic _testimportmultiple _testinternalcapi
_testmultiphase _xxtestfuzz xxsubtype
Following modules built successfully but were removed because they could not be imported:
_tkinter
Checked 110 modules (31 built-in, 54 shared, 15 n/a on linux-x86_64, 9 disabled, 0 missing, 1 failed on import)
...
/usr/bin/install -c -m 644 ./Lib/types.py output/host/lib/python3.12
/usr/bin/install: cannot stat 'Modules/_tkinter.cpython-312-x86_64-linux-gnu.so': No such file or directory
/usr/bin/install -c -m 644 ./Lib/typing.py output/host/lib/python3.12
make[3]: *** [Makefile:2068: sharedinstall] Error 1
...
---
package/python3/python3.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/python3/python3.mk b/package/python3/python3.mk
index 42765abcf4..81d9a904c7 100644
--- a/package/python3/python3.mk
+++ b/package/python3/python3.mk
@@ -34,6 +34,7 @@ HOST_PYTHON3_CONF_OPTS += \
HOST_PYTHON3_CONF_ENV += \
LDFLAGS="$(HOST_LDFLAGS) -Wl,--enable-new-dtags" \
py_cv_module_nis=n/a \
+ py_cv_module__tkinter=n/a \
py_cv_module_unicodedata=yes \
py_cv_module__codecs_cn=n/a \
py_cv_module__codecs_hk=n/a \
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Buildroot] [PATCH] package/python3: fix install
2024-02-08 7:49 Roy Kollen Svendsen
@ 2024-02-08 8:01 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-02-08 8:01 UTC (permalink / raw)
To: Roy Kollen Svendsen
Cc: Roy Kollen Svendsen, James Hilliard, Asaf Kahlon, buildroot
Hello Roy,
On Thu, 8 Feb 2024 08:49:00 +0100
Roy Kollen Svendsen <roykollensvendsen@gmail.com> wrote:
> diff --git a/package/python3/python3.mk b/package/python3/python3.mk
> index 42765abcf4..81d9a904c7 100644
> --- a/package/python3/python3.mk
> +++ b/package/python3/python3.mk
> @@ -34,6 +34,7 @@ HOST_PYTHON3_CONF_OPTS += \
> HOST_PYTHON3_CONF_ENV += \
> LDFLAGS="$(HOST_LDFLAGS) -Wl,--enable-new-dtags" \
> py_cv_module_nis=n/a \
> + py_cv_module__tkinter=n/a \
> py_cv_module_unicodedata=yes \
> py_cv_module__codecs_cn=n/a \
> py_cv_module__codecs_hk=n/a \
Thanks a lot for your patch! However, in order to be consistent with
how we do it with ncurses, sqlite, etc, I think it is the --disable-tk
option that should automatically set py_cv_module__tkinter=n/a.
+AC_SUBST(TK)
+AC_ARG_ENABLE(tk,
+ AS_HELP_STRING([--disable-tk], [disable tk]),
+ [ TK="${enableval}" ], [ TK=yes ])
should be followed by something like
AS_IF([test "${enable_tk}" = "no"], [PY_STDLIB_MOD_SET_NA([_tkinter])])
something like this (in
package/python3/0012-Add-an-option-to-disable-the-tk-module.patch).
Or, we need to turn around how things are done, and instead of adding
those --enable/--disable, look at whether py_cv_module_<foo> is passed
to appropriately disable things. Might be more upstreamable (but I
thought about this idea *after* redoing the 3.12 patches).
That said, the 3.12 bump is for now causing quite a few issues, so it
is not impossible that we revert it before the 2024.02 release.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-02-11 22:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-08 9:56 [Buildroot] [PATCH] package/python3: fix install Roy Kollen Svendsen
2024-02-11 22:11 ` Thomas Petazzoni via buildroot
-- strict thread matches above, loose matches on Subject: below --
2024-02-08 9:41 Roy Kollen Svendsen
2024-02-08 9:38 Roy Kollen Svendsen
2024-02-08 7:49 Roy Kollen Svendsen
2024-02-08 8:01 ` Thomas Petazzoni via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox