From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Sebastian Bauer <mail@sebastianbauer.info>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>,
Marcus Folkesson <marcus.folkesson@gmail.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 3/3] packages/libcamera-apps: Fix build to use meson
Date: Mon, 12 Feb 2024 23:07:21 +0100 [thread overview]
Message-ID: <20240212230721.4f97dae3@windsurf> (raw)
In-Reply-To: <20231227182429.1215185-3-mail@sebastianbauer.info>
Hello Sebastian,
On Wed, 27 Dec 2023 19:24:29 +0100
Sebastian Bauer <mail@sebastianbauer.info> wrote:
> Upstream uses meson instead of cmake since a while.
>
> Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info>
Thanks for your patch, and sorry for the slow feedback. Could you
clarify why this you say "Fix build" in your commit title? Is there
some build failure, or is this an improvement patch?
> -ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> -LIBCAMERA_APPS_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-latomic
> -endif
You're removing this chunk, but it was important. Do you have some
evidence that it is no longer needed?
It was added in f41d47f15b63a4bbe026834478e63acba85d33fe, as otherwise
libcamera-apps would fail to build on the SPARC CPU architecture. See
the commit log for a reference to an autobuilder failure.
Thanks in advance for your feedback!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-02-12 22:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 18:24 [Buildroot] [PATCH 1/3] Revert "package/libcamera-apps: bump to version 1.3.0" Sebastian Bauer
2023-12-27 18:24 ` [Buildroot] [PATCH 2/3] packages/libcamera: Fix libcamera build with rpi pipeline Sebastian Bauer
2023-12-27 21:52 ` Peter Seiderer via buildroot
2023-12-27 22:15 ` Yann E. MORIN
2023-12-28 10:46 ` Sebastian Bauer
2023-12-27 18:24 ` [Buildroot] [PATCH 3/3] packages/libcamera-apps: Fix build to use meson Sebastian Bauer
2024-01-08 22:42 ` Sebastian Bauer
2024-02-12 22:07 ` Thomas Petazzoni via buildroot [this message]
2024-02-13 18:30 ` Sebastian Bauer
2023-12-27 22:14 ` [Buildroot] [PATCH 1/3] Revert "package/libcamera-apps: bump to version 1.3.0" Yann E. MORIN
2024-01-10 15:28 ` Peter Korsgaard
2024-01-10 15:30 ` Peter Korsgaard
2024-01-10 21:57 ` Sebastian Bauer
2024-01-11 16:03 ` Kieran Bingham
2024-01-11 16:05 ` Kieran Bingham
2024-01-15 16:24 ` Sebastian Bauer
2024-04-04 4:20 ` Nayab Sayed via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240212230721.4f97dae3@windsurf \
--to=buildroot@buildroot.org \
--cc=eric.le.bihan.dev@free.fr \
--cc=kieran.bingham@ideasonboard.com \
--cc=mail@sebastianbauer.info \
--cc=marcus.folkesson@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox