Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Sebastian Bauer <mail@sebastianbauer.info>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>,
	Marcus Folkesson <marcus.folkesson@gmail.com>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/3] packages/libcamera: Fix libcamera build with rpi pipeline
Date: Wed, 27 Dec 2023 23:15:35 +0100	[thread overview]
Message-ID: <ZYyiB4POkcCnTbd6@landeda> (raw)
In-Reply-To: <20231227182429.1215185-2-mail@sebastianbauer.info>

Sebastien, All,

Thanks for this patch!

On 2023-12-27 19:24 +0100, Sebastian Bauer spake thusly:
> The name of the pipeline was renamed from raspberrypi to rpi/vc4 in
> version 0.1.0 of libcamera, which is why, without this fix, the build is
> broken.

As Peter pointed out, his patch is a bit more complete, so I ended up
applying his patch.

Regards,
Yann E. MORIN.

> Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info>
> ---
>  package/libcamera/libcamera.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk
> index 8dce67f60f..c0c5a02368 100644
> --- a/package/libcamera/libcamera.mk
> +++ b/package/libcamera/libcamera.mk
> @@ -52,7 +52,7 @@ endif
>  
>  LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_IPU3) += ipu3
>  ifeq ($(BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI),y)
> -LIBCAMERA_PIPELINES-y += raspberrypi
> +LIBCAMERA_PIPELINES-y += rpi/vc4
>  LIBCAMERA_DEPENDENCIES += boost
>  endif
>  LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_RKISP1) += rkisp1
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2023-12-27 22:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-27 18:24 [Buildroot] [PATCH 1/3] Revert "package/libcamera-apps: bump to version 1.3.0" Sebastian Bauer
2023-12-27 18:24 ` [Buildroot] [PATCH 2/3] packages/libcamera: Fix libcamera build with rpi pipeline Sebastian Bauer
2023-12-27 21:52   ` Peter Seiderer via buildroot
2023-12-27 22:15   ` Yann E. MORIN [this message]
2023-12-28 10:46     ` Sebastian Bauer
2023-12-27 18:24 ` [Buildroot] [PATCH 3/3] packages/libcamera-apps: Fix build to use meson Sebastian Bauer
2024-01-08 22:42   ` Sebastian Bauer
2024-02-12 22:07   ` Thomas Petazzoni via buildroot
2024-02-13 18:30     ` Sebastian Bauer
2023-12-27 22:14 ` [Buildroot] [PATCH 1/3] Revert "package/libcamera-apps: bump to version 1.3.0" Yann E. MORIN
2024-01-10 15:28 ` Peter Korsgaard
2024-01-10 15:30 ` Peter Korsgaard
2024-01-10 21:57   ` Sebastian Bauer
2024-01-11 16:03     ` Kieran Bingham
2024-01-11 16:05       ` Kieran Bingham
2024-01-15 16:24         ` Sebastian Bauer
2024-04-04  4:20           ` Nayab Sayed via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZYyiB4POkcCnTbd6@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=eric.le.bihan.dev@free.fr \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=mail@sebastianbauer.info \
    --cc=marcus.folkesson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox