Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v1] .github: add a pull request warning that explains the mailing list workflow
@ 2024-04-24 17:53 Thomas Devoogdt
  2024-04-24 18:04 ` Thomas Devoogdt
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Thomas Devoogdt @ 2024-04-24 17:53 UTC (permalink / raw)
  To: buildroot, Thomas Petazzoni; +Cc: Thomas Devoogdt

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
---
 .github/pull_request_template.md | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 .github/pull_request_template.md

diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
new file mode 100644
index 0000000000..319e67d861
--- /dev/null
+++ b/.github/pull_request_template.md
@@ -0,0 +1,6 @@
+Please do not submit a Pull Request via GitHub. Buildroot makes use of a
+[mailing list](http://lists.buildroot.org/mailman/listinfo/buildroot) for patch submission and review.
+See [submitting your own patches](http://buildroot.org/manual.html#submitting-patches) for more info.
+
+Thanks for your help!
+
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH v1] .github: add a pull request warning that explains the mailing list workflow
  2024-04-24 17:53 [Buildroot] [PATCH v1] .github: add a pull request warning that explains the mailing list workflow Thomas Devoogdt
@ 2024-04-24 18:04 ` Thomas Devoogdt
  2024-04-24 19:28 ` J. Neuschäfer via buildroot
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Thomas Devoogdt @ 2024-04-24 18:04 UTC (permalink / raw)
  To: thomas; +Cc: thomas.petazzoni, buildroot

Hi all,


This patch is based on this thread: https://github.com/buildroot/buildroot/pull/134.


Kr,

Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH v1] .github: add a pull request warning that explains the mailing list workflow
  2024-04-24 17:53 [Buildroot] [PATCH v1] .github: add a pull request warning that explains the mailing list workflow Thomas Devoogdt
  2024-04-24 18:04 ` Thomas Devoogdt
@ 2024-04-24 19:28 ` J. Neuschäfer via buildroot
  2024-04-24 19:57 ` Yann E. MORIN
  2024-05-07 16:10 ` Peter Korsgaard
  3 siblings, 0 replies; 5+ messages in thread
From: J. Neuschäfer via buildroot @ 2024-04-24 19:28 UTC (permalink / raw)
  To: Thomas Devoogdt; +Cc: Thomas Petazzoni, buildroot

On Wed, Apr 24, 2024 at 07:53:59PM +0200, Thomas Devoogdt wrote:
> Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
> ---
>  .github/pull_request_template.md | 6 ++++++
>  1 file changed, 6 insertions(+)
>  create mode 100644 .github/pull_request_template.md
>
> diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
> new file mode 100644
> index 0000000000..319e67d861
> --- /dev/null
> +++ b/.github/pull_request_template.md
> @@ -0,0 +1,6 @@
> +Please do not submit a Pull Request via GitHub. Buildroot makes use of a
> +[mailing list](http://lists.buildroot.org/mailman/listinfo/buildroot) for patch submission and review.
> +See [submitting your own patches](http://buildroot.org/manual.html#submitting-patches) for more info.
> +
> +Thanks for your help!

Good idea. It's always good to catch misunderstandings early.  And it's
a shame that GitHub seems to insist that PRs are open on every repo…

Reviewed-by: J. Neuschäfer <j.neuschaefer@gmx.net>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH v1] .github: add a pull request warning that explains the mailing list workflow
  2024-04-24 17:53 [Buildroot] [PATCH v1] .github: add a pull request warning that explains the mailing list workflow Thomas Devoogdt
  2024-04-24 18:04 ` Thomas Devoogdt
  2024-04-24 19:28 ` J. Neuschäfer via buildroot
@ 2024-04-24 19:57 ` Yann E. MORIN
  2024-05-07 16:10 ` Peter Korsgaard
  3 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2024-04-24 19:57 UTC (permalink / raw)
  To: Thomas Devoogdt; +Cc: Thomas Petazzoni, buildroot

Thomas, All,

On 2024-04-24 19:53 +0200, Thomas Devoogdt spake thusly:
> Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

Applied to master, thanks.

Do you think you could follow up with the suggestion in the last comment
in that thread:

    https://github.com/buildroot/buildroot/pull/134#issuecomment-1718506664

    For example https://github.com/marketplace/actions/close-pull-request to
    automatically close PR and add comment advising users how to contribute

Regards,
Yann E. MORIN.

> ---
>  .github/pull_request_template.md | 6 ++++++
>  1 file changed, 6 insertions(+)
>  create mode 100644 .github/pull_request_template.md
> 
> diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
> new file mode 100644
> index 0000000000..319e67d861
> --- /dev/null
> +++ b/.github/pull_request_template.md
> @@ -0,0 +1,6 @@
> +Please do not submit a Pull Request via GitHub. Buildroot makes use of a
> +[mailing list](http://lists.buildroot.org/mailman/listinfo/buildroot) for patch submission and review.
> +See [submitting your own patches](http://buildroot.org/manual.html#submitting-patches) for more info.
> +
> +Thanks for your help!
> +
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH v1] .github: add a pull request warning that explains the mailing list workflow
  2024-04-24 17:53 [Buildroot] [PATCH v1] .github: add a pull request warning that explains the mailing list workflow Thomas Devoogdt
                   ` (2 preceding siblings ...)
  2024-04-24 19:57 ` Yann E. MORIN
@ 2024-05-07 16:10 ` Peter Korsgaard
  3 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2024-05-07 16:10 UTC (permalink / raw)
  To: Thomas Devoogdt; +Cc: Thomas Petazzoni, buildroot

>>>>> "Thomas" == Thomas Devoogdt <thomas@devoogdt.com> writes:

 > Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

Committed to 2024.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-05-07 16:10 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-24 17:53 [Buildroot] [PATCH v1] .github: add a pull request warning that explains the mailing list workflow Thomas Devoogdt
2024-04-24 18:04 ` Thomas Devoogdt
2024-04-24 19:28 ` J. Neuschäfer via buildroot
2024-04-24 19:57 ` Yann E. MORIN
2024-05-07 16:10 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox