Re: [Buildroot] [PATCH] package/python-pycrate: bump to version 0.7.2

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Nasser Afshin <afshin.nasser@gmail.com>
Cc: James Hilliard <james.hilliard1@gmail.com>,
	Asaf Kahlon <asafka7@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/python-pycrate: bump to version 0.7.2
Date: Wed, 1 May 2024 21:33:31 +0200	[thread overview]
Message-ID: <20240501213331.48643919@windsurf> (raw)
In-Reply-To: <20240401192629.932481-1-afshin.nasser@gmail.com>

Hello Nasser,

On Mon,  1 Apr 2024 22:56:29 +0330
Nasser Afshin <afshin.nasser@gmail.com> wrote:

> Signed-off-by: Nasser Afshin <afshin.nasser@gmail.com>

Thanks for the patch. However, your empty commit log really wasn't
enough. It's not just a version bump, it does a number of other changes
that should have been explained in the commit log. So I've expanded it
as such:

    The license.txt file is now part of the release tarball, so it is no
    longer needed to download it separately, and re-add it to the source
    tree.

    The https://github.com/P1sec/pycrate/ repository has been archived, so
    use the new official location, as referenced by
    https://pypi.org/project/pycrate/.

> -PYTHON_PYCRATE_LICENSE = LGPL-2.1+
> +PYTHON_PYCRATE_LICENSE = LGPL-2.1

This change looked incorrect to me. Files I've looked at in the tree do
have the (or later) statement, so I kept LGPL-2.1+. If you have a good
justification for this change, could you submit a patch with a
non-empty commit log giving some explanation?

Applied to master with those changes, thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot