Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/python-pycrate: bump to version 0.7.2
@ 2024-04-01 19:26 Nasser Afshin
  2024-05-01 19:33 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 2+ messages in thread
From: Nasser Afshin @ 2024-04-01 19:26 UTC (permalink / raw)
  To: buildroot; +Cc: James Hilliard, Nasser Afshin, Asaf Kahlon

Signed-off-by: Nasser Afshin <afshin.nasser@gmail.com>
---
 package/python-pycrate/Config.in           |  2 +-
 package/python-pycrate/python-pycrate.hash |  4 ++--
 package/python-pycrate/python-pycrate.mk   | 12 +++---------
 3 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/package/python-pycrate/Config.in b/package/python-pycrate/Config.in
index bbd6873938..e78df43fcd 100644
--- a/package/python-pycrate/Config.in
+++ b/package/python-pycrate/Config.in
@@ -4,4 +4,4 @@ config BR2_PACKAGE_PYTHON_PYCRATE
 	  A software suite to handle various data and protocol
 	  formats.
 
-	  https://github.com/P1sec/pycrate/
+	  https://github.com/pycrate-org/pycrate/
diff --git a/package/python-pycrate/python-pycrate.hash b/package/python-pycrate/python-pycrate.hash
index 94ec99b738..5489f9290f 100644
--- a/package/python-pycrate/python-pycrate.hash
+++ b/package/python-pycrate/python-pycrate.hash
@@ -1,5 +1,5 @@
 # md5, sha256 from https://pypi.org/pypi/pycrate/json
-md5  bd21fa697ecff7ad93bec4943230d281  pycrate-0.7.0.tar.gz
-sha256  c83232f522b5bbc3b3eeaca2cf38ee63cd3c25d0c15f3ba221e6dafa89b9a763  pycrate-0.7.0.tar.gz
+md5  37e1bda10f41fe947512e9d5f8289518  pycrate-0.7.2.tar.gz
+sha256  8abd3fb9f3e7a2dc62061490f01e99b2a6185e88b1c9bf30db68853b748b8f61  pycrate-0.7.2.tar.gz
 # Locally computed sha256 checksums
 sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  license.txt
diff --git a/package/python-pycrate/python-pycrate.mk b/package/python-pycrate/python-pycrate.mk
index 1645eaf52c..182644df6d 100644
--- a/package/python-pycrate/python-pycrate.mk
+++ b/package/python-pycrate/python-pycrate.mk
@@ -4,17 +4,11 @@
 #
 ################################################################################
 
-PYTHON_PYCRATE_VERSION = 0.7.0
+PYTHON_PYCRATE_VERSION = 0.7.2
 PYTHON_PYCRATE_SOURCE = pycrate-$(PYTHON_PYCRATE_VERSION).tar.gz
-PYTHON_PYCRATE_SITE = https://files.pythonhosted.org/packages/a6/a5/aab94e6bb8b3281cc450dde3961b417bd56abde2401955a9a4904df44c68
+PYTHON_PYCRATE_SITE = https://files.pythonhosted.org/packages/f4/01/09aac6ea758ca7b7b1b4832c0c39003752ef7b6c1478e6db2f34171db3fe
 PYTHON_PYCRATE_SETUP_TYPE = setuptools
-PYTHON_PYCRATE_EXTRA_DOWNLOADS = https://raw.githubusercontent.com/P1sec/pycrate/$(PYTHON_PYCRATE_VERSION)/license.txt
-PYTHON_PYCRATE_LICENSE = LGPL-2.1+
+PYTHON_PYCRATE_LICENSE = LGPL-2.1
 PYTHON_PYCRATE_LICENSE_FILES = license.txt
 
-define PYTHON_PYCRATE_ADD_LICENSE_FILE
-	cp $(PYTHON_PYCRATE_DL_DIR)/license.txt $(@D)
-endef
-PYTHON_PYCRATE_POST_EXTRACT_HOOKS += PYTHON_PYCRATE_ADD_LICENSE_FILE
-
 $(eval $(python-package))
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH] package/python-pycrate: bump to version 0.7.2
  2024-04-01 19:26 [Buildroot] [PATCH] package/python-pycrate: bump to version 0.7.2 Nasser Afshin
@ 2024-05-01 19:33 ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-05-01 19:33 UTC (permalink / raw)
  To: Nasser Afshin; +Cc: James Hilliard, Asaf Kahlon, buildroot

Hello Nasser,

On Mon,  1 Apr 2024 22:56:29 +0330
Nasser Afshin <afshin.nasser@gmail.com> wrote:

> Signed-off-by: Nasser Afshin <afshin.nasser@gmail.com>

Thanks for the patch. However, your empty commit log really wasn't
enough. It's not just a version bump, it does a number of other changes
that should have been explained in the commit log. So I've expanded it
as such:

    The license.txt file is now part of the release tarball, so it is no
    longer needed to download it separately, and re-add it to the source
    tree.
    
    The https://github.com/P1sec/pycrate/ repository has been archived, so
    use the new official location, as referenced by
    https://pypi.org/project/pycrate/.

> -PYTHON_PYCRATE_LICENSE = LGPL-2.1+
> +PYTHON_PYCRATE_LICENSE = LGPL-2.1

This change looked incorrect to me. Files I've looked at in the tree do
have the (or later) statement, so I kept LGPL-2.1+. If you have a good
justification for this change, could you submit a patch with a
non-empty commit log giving some explanation?

Applied to master with those changes, thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-05-01 19:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-01 19:26 [Buildroot] [PATCH] package/python-pycrate: bump to version 0.7.2 Nasser Afshin
2024-05-01 19:33 ` Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox