Re: [Buildroot] [PATCH] package/busybox: refresh busybox.config

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Nayab,

+Arnout in Cc (question below).

On Fri, 26 Apr 2024 14:10:58 +0530
Nayab Sayed via buildroot <buildroot@buildroot.org> wrote:

> Refresh busybox.config to current version (1.36.1) default values.
> 
> Signed-off-by: Nayab Sayed <nayabbasha.sayed@microchip.com>
> ---
> When `make busybox-update-config` is executed, the config
> CONFIG_UDHCPC6_DEFAULT_SCRIPT became empty. But it's updated to reuse the
> value from earlier bump as mentioned in the commit d68b617993bd
> (package/busybox: update to 1.36.0).

Arnout: I don't really understand the reasoning in commit d68b617993bd.
The commit log says:

    Refresh busybox.config. All configs are set to the new defaults, except
    for CONFIG_UDHCPC_DEFAULT_SCRIPT: for this one, reuse the script we also
    use for DHCPv4. This is matches the behaviour previous to the bump,
    where we had a single script handling both.

Did you mean to say CONFIG_UDHCPC6_DEFAULT_SCRIPT instead?

In the commit, you do:

+CONFIG_UDHCPC6_DEFAULT_SCRIPT="/usr/share/udhcpc/default.script"

But then, why do we do that? udhcpc6 is not enabled in our
busybox.config. Due to this, when we refresh busybox.config, this
CONFIG_UDHCPC6_DEFAULT_SCRIPT gets dropped.

> @@ -336,7 +336,7 @@ CONFIG_TEST=y
>  CONFIG_TEST1=y
>  CONFIG_TEST2=y
>  CONFIG_FEATURE_TEST_64=y
> -# CONFIG_TIMEOUT is not set
> +CONFIG_TIMEOUT=y

Nayab: this doesn't show up here when I refresh the file. Are you sure
this isn't a custom change on your side, unrelated to the Busybox file
refresh?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot