[Buildroot] [PATCH] package/busybox: refresh busybox.config

[Buildroot] [PATCH] package/busybox: refresh busybox.config

[Nayab Sayed via buildroot]

Refresh busybox.config to current version (1.36.1) default values.

Signed-off-by: Nayab Sayed <nayabbasha.sayed@microchip.com>
---
When `make busybox-update-config` is executed, the config
CONFIG_UDHCPC6_DEFAULT_SCRIPT became empty. But it's updated to reuse the
value from earlier bump as mentioned in the commit d68b617993bd
(package/busybox: update to 1.36.0).
---
 package/busybox/busybox.config | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/package/busybox/busybox.config b/package/busybox/busybox.config
index cfd16172fa..2c8e51cd6c 100644
--- a/package/busybox/busybox.config
+++ b/package/busybox/busybox.config
@@ -1,7 +1,7 @@
 #
 # Automatically generated make config: don't edit
-# Busybox version: 1.36.0
-# Tue Feb  7 12:34:02 2023
+# Busybox version: 1.36.1
+# Fri Apr 26 11:38:40 2024
 #
 CONFIG_HAVE_DOT_CONFIG=y
 
@@ -336,7 +336,7 @@ CONFIG_TEST=y
 CONFIG_TEST1=y
 CONFIG_TEST2=y
 CONFIG_FEATURE_TEST_64=y
-# CONFIG_TIMEOUT is not set
+CONFIG_TIMEOUT=y
 CONFIG_TOUCH=y
 CONFIG_FEATURE_TOUCH_SUSV3=y
 CONFIG_TR=y
@@ -969,6 +969,7 @@ CONFIG_ROUTE=y
 # CONFIG_SLATTACH is not set
 # CONFIG_SSL_CLIENT is not set
 # CONFIG_TC is not set
+# CONFIG_FEATURE_TC_INGRESS is not set
 # CONFIG_TCPSVD is not set
 # CONFIG_UDPSVD is not set
 CONFIG_TELNET=y

---
base-commit: db37b0e27d3c54d27b854edbc3253d29f512a6ee
change-id: 20240426-refresh-busybox-config-b724e0c40c29

Best regards,
-- 
Nayab Sayed <nayabbasha.sayed@microchip.com>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/busybox: refresh busybox.config

[Thomas Petazzoni via buildroot]

Hello Nayab,

+Arnout in Cc (question below).

On Fri, 26 Apr 2024 14:10:58 +0530
Nayab Sayed via buildroot <buildroot@buildroot.org> wrote:

> Refresh busybox.config to current version (1.36.1) default values.
> 
> Signed-off-by: Nayab Sayed <nayabbasha.sayed@microchip.com>
> ---
> When `make busybox-update-config` is executed, the config
> CONFIG_UDHCPC6_DEFAULT_SCRIPT became empty. But it's updated to reuse the
> value from earlier bump as mentioned in the commit d68b617993bd
> (package/busybox: update to 1.36.0).

Arnout: I don't really understand the reasoning in commit d68b617993bd.
The commit log says:

    Refresh busybox.config. All configs are set to the new defaults, except
    for CONFIG_UDHCPC_DEFAULT_SCRIPT: for this one, reuse the script we also
    use for DHCPv4. This is matches the behaviour previous to the bump,
    where we had a single script handling both.

Did you mean to say CONFIG_UDHCPC6_DEFAULT_SCRIPT instead?

In the commit, you do:

+CONFIG_UDHCPC6_DEFAULT_SCRIPT="/usr/share/udhcpc/default.script"

But then, why do we do that? udhcpc6 is not enabled in our
busybox.config. Due to this, when we refresh busybox.config, this
CONFIG_UDHCPC6_DEFAULT_SCRIPT gets dropped.

> @@ -336,7 +336,7 @@ CONFIG_TEST=y
>  CONFIG_TEST1=y
>  CONFIG_TEST2=y
>  CONFIG_FEATURE_TEST_64=y
> -# CONFIG_TIMEOUT is not set
> +CONFIG_TIMEOUT=y

Nayab: this doesn't show up here when I refresh the file. Are you sure
this isn't a custom change on your side, unrelated to the Busybox file
refresh?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/busybox: refresh busybox.config

[Nayab Sayed via buildroot]

Hi Thomas,

On 02/05/24 01:48, Thomas Petazzoni wrote:
>>   CONFIG_TEST2=y
>>   CONFIG_FEATURE_TEST_64=y
>> -# CONFIG_TIMEOUT is not set
>> +CONFIG_TIMEOUT=y
> Nayab: this doesn't show up here when I refresh the file. Are you sure
> this isn't a custom change on your side, unrelated to the Busybox file
> refresh?

Yes, CONFIG_TIMEOUT shouldn't be present. I will remove this custom 
config and send a v2 once Arnout replies regarding 
CONFIG_UDHCPC6_DEFAULT_SCRIPT

-- 
Thanks,
Nayab

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/busybox: refresh busybox.config

[Arnout Vandecappelle via buildroot]

On 01/05/2024 22:18, Thomas Petazzoni wrote:
> Hello Nayab,
> 
> +Arnout in Cc (question below).
> 
> On Fri, 26 Apr 2024 14:10:58 +0530
> Nayab Sayed via buildroot <buildroot@buildroot.org> wrote:
> 
>> Refresh busybox.config to current version (1.36.1) default values.
>>
>> Signed-off-by: Nayab Sayed <nayabbasha.sayed@microchip.com>
>> ---
>> When `make busybox-update-config` is executed, the config
>> CONFIG_UDHCPC6_DEFAULT_SCRIPT became empty. But it's updated to reuse the
>> value from earlier bump as mentioned in the commit d68b617993bd
>> (package/busybox: update to 1.36.0).
> 
> Arnout: I don't really understand the reasoning in commit d68b617993bd.

  That's from a year ago, you expect too much from me :-)

> The commit log says:
> 
>      Refresh busybox.config. All configs are set to the new defaults, except
>      for CONFIG_UDHCPC_DEFAULT_SCRIPT: for this one, reuse the script we also
>      use for DHCPv4. This is matches the behaviour previous to the bump,
>      where we had a single script handling both.
> 
> Did you mean to say CONFIG_UDHCPC6_DEFAULT_SCRIPT instead?

  I guess... Although, CONFIG_UDHCPC_DEFAULT_SCRIPT's default value is 
/usr/share/udhcpc/default.script and we set it to something different. Really 
I'm not sure what I meant there.

> 
> In the commit, you do:
> 
> +CONFIG_UDHCPC6_DEFAULT_SCRIPT="/usr/share/udhcpc/default.script"
> 
> But then, why do we do that? udhcpc6 is not enabled in our
> busybox.config. Due to this, when we refresh busybox.config, this
> CONFIG_UDHCPC6_DEFAULT_SCRIPT gets dropped.

  Uh, I guess I didn't notice that udhcpc6 wasn't enabled?

  Regards,
  Arnout

> 
>> @@ -336,7 +336,7 @@ CONFIG_TEST=y
>>   CONFIG_TEST1=y
>>   CONFIG_TEST2=y
>>   CONFIG_FEATURE_TEST_64=y
>> -# CONFIG_TIMEOUT is not set
>> +CONFIG_TIMEOUT=y
> 
> Nayab: this doesn't show up here when I refresh the file. Are you sure
> this isn't a custom change on your side, unrelated to the Busybox file
> refresh?
> 
> Best regards,
> 
> Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/busybox: refresh busybox.config

[Thomas Petazzoni via buildroot]

On Thu, 9 May 2024 22:57:54 +0200
Arnout Vandecappelle <arnout@mind.be> wrote:

> > But then, why do we do that? udhcpc6 is not enabled in our
> > busybox.config. Due to this, when we refresh busybox.config, this
> > CONFIG_UDHCPC6_DEFAULT_SCRIPT gets dropped.  
> 
>   Uh, I guess I didn't notice that udhcpc6 wasn't enabled?

So, should we drop?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot