[Buildroot] [PATCH 1/1] package/ti-sgx-km: needs BR2_ARM_EABIHF

[Buildroot] [PATCH 1/1] package/ti-sgx-km: needs BR2_ARM_EABIHF

[Fabrice Fontaine]

ti-sgx-km raises the following build failure without BR2_ARM_EABIHF:

eurasiacon/build/linux2/toplevel.mk:230: eurasiacon/build/linux2/moduledefs/target_armel.mk: No such file or directory

Fixes:
 - http://autobuild.buildroot.org/results/17e4da346d062570b9a84ab8eb1ce93c6d7384be
 - http://autobuild.buildroot.org/results/04fd659472f1928c2621354bb0ea3b60c5dfadec

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/ti-sgx-km/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/ti-sgx-km/Config.in b/package/ti-sgx-km/Config.in
index 964889ff40..3e8a41b755 100644
--- a/package/ti-sgx-km/Config.in
+++ b/package/ti-sgx-km/Config.in
@@ -1,10 +1,10 @@
 comment "ti-sgx-km needs a Linux kernel to be built"
-	depends on BR2_arm
+	depends on BR2_ARM_EABIHF
 	depends on !BR2_LINUX_KERNEL
 
 config BR2_PACKAGE_TI_SGX_KM
 	bool "ti-sgx-km"
-	depends on BR2_LINUX_KERNEL && BR2_arm
+	depends on BR2_LINUX_KERNEL && BR2_ARM_EABIHF
 	select BR2_LINUX_NEEDS_MODULES
 	help
 	  Kernel modules for TI CPUs with SGX GPU.
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/ti-sgx-km: needs BR2_ARM_EABIHF

[Thomas Petazzoni via buildroot]

On Thu, 11 Apr 2024 19:43:28 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> ti-sgx-km raises the following build failure without BR2_ARM_EABIHF:
> 
> eurasiacon/build/linux2/toplevel.mk:230: eurasiacon/build/linux2/moduledefs/target_armel.mk: No such file or directory
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/17e4da346d062570b9a84ab8eb1ce93c6d7384be
>  - http://autobuild.buildroot.org/results/04fd659472f1928c2621354bb0ea3b60c5dfadec
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/ti-sgx-km/Config.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

In principle, for a package that's available in full source code, the
ABI shouldn't matter. But this package has some extremely convoluted
Makefile machinery that indeed will not work on ARM EABI, and only on
ARM EABIHF. So: patch applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/ti-sgx-km: needs BR2_ARM_EABIHF

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > ti-sgx-km raises the following build failure without BR2_ARM_EABIHF:
 > eurasiacon/build/linux2/toplevel.mk:230: eurasiacon/build/linux2/moduledefs/target_armel.mk: No such file or directory

 > Fixes:
 >  - http://autobuild.buildroot.org/results/17e4da346d062570b9a84ab8eb1ce93c6d7384be
 >  - http://autobuild.buildroot.org/results/04fd659472f1928c2621354bb0ea3b60c5dfadec

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2024.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot