[Buildroot] [PATCH 1/1] boot/arm-trusted-firmware: enable verbose output

[Buildroot] [PATCH 1/1] boot/arm-trusted-firmware: enable verbose output

[Brandon Maier via buildroot]

Signed-off-by: Brandon Maier <brandon.maier@collins.com>
---
 boot/arm-trusted-firmware/arm-trusted-firmware.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/boot/arm-trusted-firmware/arm-trusted-firmware.mk b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
index 2d554c1da8..abf917948e 100644
--- a/boot/arm-trusted-firmware/arm-trusted-firmware.mk
+++ b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
@@ -59,6 +59,7 @@ endif
 endif
 
 ARM_TRUSTED_FIRMWARE_MAKE_OPTS += \
+	$(if $(VERBOSE),V=1) \
 	CROSS_COMPILE="$(TARGET_CROSS)" \
 	BUILD_STRING=$(ARM_TRUSTED_FIRMWARE_VERSION) \
 	$(call qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES)) \
-- 
2.44.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] boot/arm-trusted-firmware: enable verbose output

[Thomas Petazzoni via buildroot]

On Fri, 12 Apr 2024 21:12:22 +0000
Brandon Maier via buildroot <buildroot@buildroot.org> wrote:

> Signed-off-by: Brandon Maier <brandon.maier@collins.com>
> ---
>  boot/arm-trusted-firmware/arm-trusted-firmware.mk | 1 +
>  1 file changed, 1 insertion(+)

I am confused as to why this patch is needed: for both Linux and
U-Boot, we don't need to do anything special, just doing "make V=1" at
the top-level, the V=1 gets passed down to Linux/U-Boot, and they
exhibit a verbose build. However, that doesn't work with
arm-trusted-firmware indeed, so I have applied your patch which makes
the build verbose also for arm-trusted-firmware. Still a bit unclear as
to why it doesn't work "by default".

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [External] Re: [PATCH 1/1] boot/arm-trusted-firmware: enable verbose output

[Maier, Brandon L Collins via buildroot]

Hi Thomas,

> -----Original Message-----
> From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Sent: Sunday, May 5, 2024 8:40 AM
> To: Brandon Maier via buildroot <buildroot@buildroot.org>
> Cc: Maier, Brandon L Collins <Brandon.Maier@collins.com>; Sergey Matyukevich
> <geomatsi@gmail.com>
> Subject: [External] Re: [Buildroot] [PATCH 1/1] boot/arm-trusted-firmware:
> enable verbose output
>
> On Fri, 12 Apr 2024 21:12:22 +0000
> Brandon Maier via buildroot <buildroot@buildroot.org> wrote:
>
> > Signed-off-by: Brandon Maier <brandon.maier@collins.com>
> > ---
> >  boot/arm-trusted-firmware/arm-trusted-firmware.mk | 1 +
> >  1 file changed, 1 insertion(+)
>
> I am confused as to why this patch is needed: for both Linux and
> U-Boot, we don't need to do anything special, just doing "make V=1" at
> the top-level, the V=1 gets passed down to Linux/U-Boot, and they
> exhibit a verbose build. However, that doesn't work with
> arm-trusted-firmware indeed, so I have applied your patch which makes
> the build verbose also for arm-trusted-firmware. Still a bit unclear as
> to why it doesn't work "by default".

The Arm Trusted Firmware sets "V := 0". So, it only sees verbosity when passed as an argument.
https://github.com/ARM-software/arm-trusted-firmware/blob/master/make_helpers/defaults.mk#L291-L292

>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://urldefense.com/v3/__https://bootlin.com__;!!MvWE!HlXPBqUpYdxO9EBr
> 6F_8rB0yD3ldsb16EmjTfAQs5jbjY99L7ck-
> fAeJmn2djFv43hmR8m6SR0VDEhCl9Sam9LQt0ZSPgxQ$
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [External] Re: [PATCH 1/1] boot/arm-trusted-firmware: enable verbose output

[Thomas Petazzoni via buildroot]

On Mon, 6 May 2024 18:15:55 +0000
"Maier, Brandon L                            Collins" <Brandon.Maier@collins.com> wrote:

> > I am confused as to why this patch is needed: for both Linux and
> > U-Boot, we don't need to do anything special, just doing "make V=1" at
> > the top-level, the V=1 gets passed down to Linux/U-Boot, and they
> > exhibit a verbose build. However, that doesn't work with
> > arm-trusted-firmware indeed, so I have applied your patch which makes
> > the build verbose also for arm-trusted-firmware. Still a bit unclear as
> > to why it doesn't work "by default".  
> 
> The Arm Trusted Firmware sets "V := 0". So, it only sees verbosity when passed as an argument.
> https://github.com/ARM-software/arm-trusted-firmware/blob/master/make_helpers/defaults.mk#L291-L292

Aaah, that explains it! I'm not sure how I missed this when looking at
the TF-A Makefile (but I looked quickly). Thanks for following up on
this!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] boot/arm-trusted-firmware: enable verbose output

[Peter Korsgaard]

>>>>> "Brandon" == Brandon Maier via buildroot <buildroot@buildroot.org> writes:

 > Signed-off-by: Brandon Maier <brandon.maier@collins.com>

Committed to 2024.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot