[Buildroot] [PATCH 1/1] package/shadow: fix NLS build

[Buildroot] [PATCH 1/1] package/shadow: fix NLS build

[Fabrice Fontaine]

NLS is an optional dependency since the addition of the package in
commit f78c5cb5cae93a9e63dad4361d78e1787759382f:

/home/autobuild/autobuild/instance-0/output-1/host/lib/gcc/arm-buildroot-linux-musleabi/12.3.0/../../../../arm-buildroot-linux-musleabi/bin/ld: ../lib/.libs/libshadow.a(libshadow_la-alloc.o): in function `xcalloc':
alloc.c:(.text+0x7c): undefined reference to `libintl_gettext'

Fixes: f78c5cb5cae93a9e63dad4361d78e1787759382f
 - http://autobuild.buildroot.org/results/9f604d09745ffa1f4db3bdcfe0326c236effac0c

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/shadow/shadow.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/shadow/shadow.mk b/package/shadow/shadow.mk
index 491f271330..e4d8b67b8a 100644
--- a/package/shadow/shadow.mk
+++ b/package/shadow/shadow.mk
@@ -10,6 +10,8 @@ SHADOW_SOURCE = shadow-$(SHADOW_VERSION).tar.xz
 SHADOW_LICENSE = BSD-3-Clause
 SHADOW_LICENSE_FILES = COPYING
 SHADOW_CPE_ID_VENDOR = debian
+SHADOW_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES)
+SHADOW_CONF_ENV = LIBS=$(TARGET_NLS_LIBS)
 
 SHADOW_CONF_OPTS = \
 	--disable-man \
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/shadow: fix NLS build

[Thomas Petazzoni via buildroot]

On Sun,  5 May 2024 16:17:59 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> NLS is an optional dependency since the addition of the package in
> commit f78c5cb5cae93a9e63dad4361d78e1787759382f:
> 
> /home/autobuild/autobuild/instance-0/output-1/host/lib/gcc/arm-buildroot-linux-musleabi/12.3.0/../../../../arm-buildroot-linux-musleabi/bin/ld: ../lib/.libs/libshadow.a(libshadow_la-alloc.o): in function `xcalloc':
> alloc.c:(.text+0x7c): undefined reference to `libintl_gettext'
> 
> Fixes: f78c5cb5cae93a9e63dad4361d78e1787759382f
>  - http://autobuild.buildroot.org/results/9f604d09745ffa1f4db3bdcfe0326c236effac0c
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/shadow/shadow.mk | 2 ++
>  1 file changed, 2 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/shadow: fix NLS build

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > NLS is an optional dependency since the addition of the package in
 > commit f78c5cb5cae93a9e63dad4361d78e1787759382f:

 > /home/autobuild/autobuild/instance-0/output-1/host/lib/gcc/arm-buildroot-linux-musleabi/12.3.0/../../../../arm-buildroot-linux-musleabi/bin/ld:
 > ../lib/.libs/libshadow.a(libshadow_la-alloc.o): in function `xcalloc':
 > alloc.c:(.text+0x7c): undefined reference to `libintl_gettext'

 > Fixes: f78c5cb5cae93a9e63dad4361d78e1787759382f
 >  - http://autobuild.buildroot.org/results/9f604d09745ffa1f4db3bdcfe0326c236effac0c

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2024.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot