Re: [Buildroot] [PATCH] libusbgx: Update package from git

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Alexander,

On Fri, 19 Apr 2024 09:12:41 +0300
Alexander Shiyan <eagle.alexander923@gmail.com> wrote:

> The current version is more than 6 years old. Update to the latest git
> version.
> The current version contains many fixes and improvements and supports
> several new types of USB gadgets.
> 
> Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>

Thanks for your patch. I have applied it, but after fixing a number of
small things.

First, the commit title should have been:

	package/libusbgx: bump to recent git version

i.e, "package/libusbgx" as prefix, no capital letter when starting the
title.

>  .../0001-Add-include-of-sys-sysmacro.h.patch  | 98 -------------------

The removal of this patch should have been explained in the commit log,
and also the .checkpackageignore file in Buildroot should have been
updated with the removal of this patch.

> -LIBUSBGX_VERSION = 0.2.0
> -LIBUSBGX_SITE = $(call github,libusbgx,libusbgx,libusbgx-v$(LIBUSBGX_VERSION))
> +LIBUSBGX_VERSION = a5bfa81017a9b2064bc449cf74f5f9d106445f62
> +LIBUSBGX_SITE = https://github.com/linux-usb-gadgets/libusbgx.git

The change from https://github.com/libusbgx ->
https://github.com/linux-usb-gadgets should have been explained in the
commit log, and the Config.in file should have been updated as well.

Also, there was not really any reason to switch to the git SITE_METHOD:
you can use $(call github,...) also with an arbitrary commit like this.

As said above: I fixed all those minor details when applying, and
pushed to master. Thanks a lot for your contribution!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot