[Buildroot] [PATCH] libusbgx: Update package from git

[Buildroot] [PATCH] libusbgx: Update package from git

[Alexander Shiyan]

The current version is more than 6 years old. Update to the latest git
version.
The current version contains many fixes and improvements and supports
several new types of USB gadgets.

Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
---
 .../0001-Add-include-of-sys-sysmacro.h.patch  | 98 -------------------
 package/libusbgx/libusbgx.hash                |  2 +-
 package/libusbgx/libusbgx.mk                  |  5 +-
 3 files changed, 4 insertions(+), 101 deletions(-)
 delete mode 100644 package/libusbgx/0001-Add-include-of-sys-sysmacro.h.patch

diff --git a/package/libusbgx/0001-Add-include-of-sys-sysmacro.h.patch b/package/libusbgx/0001-Add-include-of-sys-sysmacro.h.patch
deleted file mode 100644
index 0f47454f7a..0000000000
--- a/package/libusbgx/0001-Add-include-of-sys-sysmacro.h.patch
+++ /dev/null
@@ -1,98 +0,0 @@
-From 45c14ef4d5d7ced0fbf984208de44ced6d5ed898 Mon Sep 17 00:00:00 2001
-From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
-Date: Mon, 10 Sep 2018 15:52:09 +0200
-Subject: [PATCH] libusbgx: fix build with glibc-2.28 since <sys/sysmacros.h>
- is no more included by <sys/types.h>
-
-Since https://sourceware.org/ml/libc-alpha/2015-11/msg00253.html sys/sysmacros.h
-must be explicitly included.
-Without sys/sysmacros.h and with glibc-2.28 build fails with error like:
-src/.libs/libusbgx.so: undefined reference to minor' src/.libs/libusbgx.so: undefined reference tomajor'
-src/.libs/libusbgx.so: undefined reference to `makedev'
-
-Signed-off-by: Sid Spry <R030t1@gmail.com>
-Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
----
- examples/gadget-acm-ecm.c              | 1 +
- examples/gadget-import.c               | 1 +
- examples/gadget-ms.c                   | 1 +
- examples/show-gadgets.c                | 1 +
- examples/show-udcs.c                   | 1 +
- include/usbg/usbg_internal_libconfig.h | 1 +
- 6 files changed, 6 insertions(+)
-
-diff --git a/examples/gadget-acm-ecm.c b/examples/gadget-acm-ecm.c
-index 1c5e2ca..29360da 100644
---- a/examples/gadget-acm-ecm.c
-+++ b/examples/gadget-acm-ecm.c
-@@ -20,6 +20,7 @@
- 
- #include <errno.h>
- #include <stdio.h>
-+#include <sys/sysmacros.h>
- #include <linux/usb/ch9.h>
- #include <usbg/usbg.h>
- 
-diff --git a/examples/gadget-import.c b/examples/gadget-import.c
-index e684fdb..63df449 100644
---- a/examples/gadget-import.c
-+++ b/examples/gadget-import.c
-@@ -25,6 +25,7 @@
- #include <errno.h>
- #include <string.h>
- #include <stdio.h>
-+#include <sys/sysmacros.h>
- #include <usbg/usbg.h>
- 
- int main(int argc, char **argv)
-diff --git a/examples/gadget-ms.c b/examples/gadget-ms.c
-index 478c370..a5c6681 100644
---- a/examples/gadget-ms.c
-+++ b/examples/gadget-ms.c
-@@ -23,6 +23,7 @@
- 
- #include <errno.h>
- #include <stdio.h>
-+#include <sys/sysmacros.h>
- #include <linux/usb/ch9.h>
- #include <usbg/usbg.h>
- #include <usbg/function/ms.h>
-diff --git a/examples/show-gadgets.c b/examples/show-gadgets.c
-index 707d448..a2a21c8 100644
---- a/examples/show-gadgets.c
-+++ b/examples/show-gadgets.c
-@@ -21,6 +21,7 @@
- #include <errno.h>
- #include <stdio.h>
- #include <string.h>
-+#include <sys/sysmacros.h>
- #include <netinet/ether.h>
- #include <usbg/usbg.h>
- #include <usbg/function/ms.h>
-diff --git a/examples/show-udcs.c b/examples/show-udcs.c
-index 66e950f..2f5cc45 100644
---- a/examples/show-udcs.c
-+++ b/examples/show-udcs.c
-@@ -23,6 +23,7 @@
- 
- #include <errno.h>
- #include <stdio.h>
-+#include <sys/sysmacros.h>
- #include <usbg/usbg.h>
- 
- int main(void)
-diff --git a/include/usbg/usbg_internal_libconfig.h b/include/usbg/usbg_internal_libconfig.h
-index ac51758..3fa55c0 100644
---- a/include/usbg/usbg_internal_libconfig.h
-+++ b/include/usbg/usbg_internal_libconfig.h
-@@ -12,6 +12,7 @@
- #ifndef USBG_INTERNAL_LIBCONFIG_H
- #define USBG_INTERNAL_LIBCONFIG_H
- 
-+#include <sys/sysmacros.h>
- #include <libconfig.h>
- #ifdef __cplusplus
- extern "C" {
--- 
-2.16.4
-
diff --git a/package/libusbgx/libusbgx.hash b/package/libusbgx/libusbgx.hash
index dd43ec7b97..0ae994c9b8 100644
--- a/package/libusbgx/libusbgx.hash
+++ b/package/libusbgx/libusbgx.hash
@@ -1,4 +1,4 @@
 # Locally computed:
-sha256  b15abc89a0ef82c6a650cc1d58b5ba50f7ce076db392add84caabcd86c608ee2  libusbgx-0.2.0.tar.gz
+sha256  b66d8b1ee04087133ba841ad1cd0004951a18f695a378ee42a2a0a060ca0183c  libusbgx-a5bfa81017a9b2064bc449cf74f5f9d106445f62-br1.tar.gz
 sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
 sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LGPL
diff --git a/package/libusbgx/libusbgx.mk b/package/libusbgx/libusbgx.mk
index 516ad25970..c0ebabfeae 100644
--- a/package/libusbgx/libusbgx.mk
+++ b/package/libusbgx/libusbgx.mk
@@ -4,8 +4,9 @@
 #
 ################################################################################
 
-LIBUSBGX_VERSION = 0.2.0
-LIBUSBGX_SITE = $(call github,libusbgx,libusbgx,libusbgx-v$(LIBUSBGX_VERSION))
+LIBUSBGX_VERSION = a5bfa81017a9b2064bc449cf74f5f9d106445f62
+LIBUSBGX_SITE = https://github.com/linux-usb-gadgets/libusbgx.git
+LIBUSBGX_SITE_METHOD = git
 LIBUSBGX_LICENSE = GPL-2.0+ (examples), LGPL-2.1+ (library)
 LIBUSBGX_LICENSE_FILES = COPYING COPYING.LGPL
 LIBUSBGX_DEPENDENCIES = host-pkgconf libconfig
-- 
2.39.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] libusbgx: Update package from git

[Thomas Petazzoni via buildroot]

Hello Alexander,

On Fri, 19 Apr 2024 09:12:41 +0300
Alexander Shiyan <eagle.alexander923@gmail.com> wrote:

> The current version is more than 6 years old. Update to the latest git
> version.
> The current version contains many fixes and improvements and supports
> several new types of USB gadgets.
> 
> Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>

Thanks for your patch. I have applied it, but after fixing a number of
small things.

First, the commit title should have been:

	package/libusbgx: bump to recent git version

i.e, "package/libusbgx" as prefix, no capital letter when starting the
title.

>  .../0001-Add-include-of-sys-sysmacro.h.patch  | 98 -------------------

The removal of this patch should have been explained in the commit log,
and also the .checkpackageignore file in Buildroot should have been
updated with the removal of this patch.

> -LIBUSBGX_VERSION = 0.2.0
> -LIBUSBGX_SITE = $(call github,libusbgx,libusbgx,libusbgx-v$(LIBUSBGX_VERSION))
> +LIBUSBGX_VERSION = a5bfa81017a9b2064bc449cf74f5f9d106445f62
> +LIBUSBGX_SITE = https://github.com/linux-usb-gadgets/libusbgx.git

The change from https://github.com/libusbgx ->
https://github.com/linux-usb-gadgets should have been explained in the
commit log, and the Config.in file should have been updated as well.

Also, there was not really any reason to switch to the git SITE_METHOD:
you can use $(call github,...) also with an arbitrary commit like this.

As said above: I fixed all those minor details when applying, and
pushed to master. Thanks a lot for your contribution!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot