[Buildroot] [PATCH v1 1/1] package/mdadm: add udev to ldlibs if enabled

[Buildroot] [PATCH v1 1/1] package/mdadm: add udev to ldlibs if enabled

[Christian Stewart via buildroot]

Fixes a build failure where the udev_ functions are undefined.

-ludev needs to be added to LDLIBS.

The build failure was against the systemd version of udev.

Signed-off-by: Christian Stewart <christian@aperture.us>
---
 package/mdadm/mdadm.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/mdadm/mdadm.mk b/package/mdadm/mdadm.mk
index 6de9467092..6365c4607a 100644
--- a/package/mdadm/mdadm.mk
+++ b/package/mdadm/mdadm.mk
@@ -12,6 +12,7 @@ MDADM_LICENSE_FILES = COPYING
 MDADM_CPE_ID_VALID = YES
 
 MDADM_CXFLAGS = $(TARGET_CFLAGS)
+MDADM_LDLIBS = -ldl
 
 MDADM_BUILD_OPTS = \
 	CC=$(TARGET_CC) \
@@ -21,7 +22,7 @@ MDADM_BUILD_OPTS = \
 	CXFLAGS="$(MDADM_CXFLAGS)" \
 	CPPFLAGS="$(TARGET_CPPFLAGS) -DBINDIR=\\\"/sbin\\\"" \
 	CHECK_RUN_DIR=0 \
-	LDLIBS=-ldl
+	LDLIBS="$(MDADM_LDLIBS)"
 
 MDADM_INSTALL_TARGET_OPTS = install-bin
 
@@ -32,6 +33,7 @@ endif
 ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
 MDADM_DEPENDENCIES += udev
 MDADM_INSTALL_TARGET_OPTS += install-udev
+MDADM_LDLIBS += -ludev
 else
 MDADM_CXFLAGS += -DNO_LIBUDEV
 endif
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v1 1/1] package/mdadm: add udev to ldlibs if enabled

[Christian Stewart via buildroot]

Hi all,

On Tue, May 7, 2024 at 9:02 PM Christian Stewart <christian@aperture.us> wrote:
>
> Fixes a build failure where the udev_ functions are undefined.


Here is the CI failure for the issue:
https://github.com/skiffos/SkiffOS/actions/runs/8993394462/job/24705117557

Thanks,
Christian Stewart
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v1 1/1] package/mdadm: add udev to ldlibs if enabled

[Thomas Petazzoni via buildroot]

Hello,

On Tue,  7 May 2024 21:02:20 -0700
Christian Stewart <christian@aperture.us> wrote:

> Fixes a build failure where the udev_ functions are undefined.
> 
> -ludev needs to be added to LDLIBS.
> 
> The build failure was against the systemd version of udev.
> 
> Signed-off-by: Christian Stewart <christian@aperture.us>

Thanks, but I've instead applied
https://patchwork.ozlabs.org/project/buildroot/patch/20240508120057.791378-1-fontaine.fabrice@gmail.com/,
which fixes the same issue.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot