Re: [Buildroot] [PATCH 1/1] package/pcsc-lite: bump version to 2.1.0

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Zenichi,

Thanks a lot for your patch! I have a request below.

On Tue, 23 Apr 2024 15:20:20 +0900
Zenichi Amano <zenichi.amano@gahojin.co.jp> wrote:

> +ifneq ($(BR2_PACKAGE_POLKIT),y)
> +PCSC_LITE_CONF_OPTS += --disable-polkit
> +endif

We really like to have both sides of the conditions explicitly, i.e
something like:

ifeq ($(BR2_PACKAGE_POLKIT),y)
PCSC_LITE_CONF_OPTS += --enable-polkit
PCSC_LITE_DEPENDENCIES += polkit
else
PCSC_LITE_CONF_OPTS += --disable-polkit
endif

or, if you're not interested in testing the polkit support, you can
also just unconditionally pass --disable-polkit, and let someone else
interested by polkit support look into this topic.

Indeed, your change is incorrect, as BR2_PACKAGE_POLKIT=y implies that
polkit is enabled, but not that it has been built before. So with your
change, it is possible that pcsc-lite gets built before polkit... and
you don't pass --disable-polkit in this case.

Could you have a look at providing an updated patch?

Thanks a lot,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot