Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/pcsc-lite: bump version to 2.1.0
@ 2024-04-23  6:20 Zenichi Amano
  2024-05-09 16:07 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 4+ messages in thread
From: Zenichi Amano @ 2024-04-23  6:20 UTC (permalink / raw)
  To: buildroot; +Cc: Zenichi Amano

add configuration to disable polkit if it is not available since polkit is enabled by default in 2.0.1.

https://github.com/LudovicRousseau/PCSC/releases/tag/2.1.0
https://github.com/LudovicRousseau/PCSC/releases/tag/2.0.3
https://github.com/LudovicRousseau/PCSC/releases/tag/2.0.2
https://github.com/LudovicRousseau/PCSC/releases/tag/2.0.1

Signed-off-by: Zenichi Amano <zenichi.amano@gahojin.co.jp>
---
 package/pcsc-lite/pcsc-lite.hash | 2 +-
 package/pcsc-lite/pcsc-lite.mk   | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/package/pcsc-lite/pcsc-lite.hash b/package/pcsc-lite/pcsc-lite.hash
index e0face9ddb..806792faee 100644
--- a/package/pcsc-lite/pcsc-lite.hash
+++ b/package/pcsc-lite/pcsc-lite.hash
@@ -1,4 +1,4 @@
 # Locally calculated
-sha256  d6c3e2b64510e5ed6fcd3323febf2cc2a8e5fda5a6588c7671f2d77f9f189356  pcsc-lite-2.0.0.tar.bz2
+sha256  85cab61cc744c81e2bc432656863293b8428d0136f079e3b12a84b335b5b35aa  pcsc-lite-2.1.0.tar.bz2
 sha256  40d4358bb8dc8d30f5365ae6d999b6f820bbc051b292912482f2e4d0ebd837e1  COPYING
 sha256  8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903  GPL-3.0.txt
diff --git a/package/pcsc-lite/pcsc-lite.mk b/package/pcsc-lite/pcsc-lite.mk
index 2b2114835e..e873c23bd0 100644
--- a/package/pcsc-lite/pcsc-lite.mk
+++ b/package/pcsc-lite/pcsc-lite.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-PCSC_LITE_VERSION = 2.0.0
+PCSC_LITE_VERSION = 2.1.0
 PCSC_LITE_SOURCE = pcsc-lite-$(PCSC_LITE_VERSION).tar.bz2
 PCSC_LITE_SITE = https://pcsclite.apdu.fr/files
 PCSC_LITE_INSTALL_STAGING = YES
@@ -45,6 +45,10 @@ ifeq ($(BR2_PACKAGE_PCSC_LITE_EMBEDDED),y)
 PCSC_LITE_CONF_OPTS += --enable-embedded
 endif
 
+ifneq ($(BR2_PACKAGE_POLKIT),y)
+PCSC_LITE_CONF_OPTS += --disable-polkit
+endif
+
 ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
 PCSC_LITE_CONF_ENV += LIBS=-latomic
 endif
-- 
2.44.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/pcsc-lite: bump version to 2.1.0
  2024-04-23  6:20 [Buildroot] [PATCH 1/1] package/pcsc-lite: bump version to 2.1.0 Zenichi Amano
@ 2024-05-09 16:07 ` Thomas Petazzoni via buildroot
  2024-05-10  2:43   ` [Buildroot] [PATCH v2 " Zenichi Amano
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-05-09 16:07 UTC (permalink / raw)
  To: Zenichi Amano; +Cc: buildroot

Hello Zenichi,

Thanks a lot for your patch! I have a request below.

On Tue, 23 Apr 2024 15:20:20 +0900
Zenichi Amano <zenichi.amano@gahojin.co.jp> wrote:

> +ifneq ($(BR2_PACKAGE_POLKIT),y)
> +PCSC_LITE_CONF_OPTS += --disable-polkit
> +endif

We really like to have both sides of the conditions explicitly, i.e
something like:

ifeq ($(BR2_PACKAGE_POLKIT),y)
PCSC_LITE_CONF_OPTS += --enable-polkit
PCSC_LITE_DEPENDENCIES += polkit
else
PCSC_LITE_CONF_OPTS += --disable-polkit
endif

or, if you're not interested in testing the polkit support, you can
also just unconditionally pass --disable-polkit, and let someone else
interested by polkit support look into this topic.

Indeed, your change is incorrect, as BR2_PACKAGE_POLKIT=y implies that
polkit is enabled, but not that it has been built before. So with your
change, it is possible that pcsc-lite gets built before polkit... and
you don't pass --disable-polkit in this case.

Could you have a look at providing an updated patch?

Thanks a lot,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/pcsc-lite: bump version to 2.1.0
  2024-05-09 16:07 ` Thomas Petazzoni via buildroot
@ 2024-05-10  2:43   ` Zenichi Amano
  2024-05-10 11:21     ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 4+ messages in thread
From: Zenichi Amano @ 2024-05-10  2:43 UTC (permalink / raw)
  To: buildroot; +Cc: Zenichi Amano

add configuration to disable polkit if it is not available since polkit is enabled by default in 2.0.1.

https://github.com/LudovicRousseau/PCSC/releases/tag/2.1.0
https://github.com/LudovicRousseau/PCSC/releases/tag/2.0.3
https://github.com/LudovicRousseau/PCSC/releases/tag/2.0.2
https://github.com/LudovicRousseau/PCSC/releases/tag/2.0.1

Signed-off-by: Zenichi Amano <zenichi.amano@gahojin.co.jp>
---
 package/pcsc-lite/pcsc-lite.hash | 2 +-
 package/pcsc-lite/pcsc-lite.mk   | 9 ++++++++-
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/package/pcsc-lite/pcsc-lite.hash b/package/pcsc-lite/pcsc-lite.hash
index e0face9ddb..806792faee 100644
--- a/package/pcsc-lite/pcsc-lite.hash
+++ b/package/pcsc-lite/pcsc-lite.hash
@@ -1,4 +1,4 @@
 # Locally calculated
-sha256  d6c3e2b64510e5ed6fcd3323febf2cc2a8e5fda5a6588c7671f2d77f9f189356  pcsc-lite-2.0.0.tar.bz2
+sha256  85cab61cc744c81e2bc432656863293b8428d0136f079e3b12a84b335b5b35aa  pcsc-lite-2.1.0.tar.bz2
 sha256  40d4358bb8dc8d30f5365ae6d999b6f820bbc051b292912482f2e4d0ebd837e1  COPYING
 sha256  8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903  GPL-3.0.txt
diff --git a/package/pcsc-lite/pcsc-lite.mk b/package/pcsc-lite/pcsc-lite.mk
index 2b2114835e..8418d6a32a 100644
--- a/package/pcsc-lite/pcsc-lite.mk
+++ b/package/pcsc-lite/pcsc-lite.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-PCSC_LITE_VERSION = 2.0.0
+PCSC_LITE_VERSION = 2.1.0
 PCSC_LITE_SOURCE = pcsc-lite-$(PCSC_LITE_VERSION).tar.bz2
 PCSC_LITE_SITE = https://pcsclite.apdu.fr/files
 PCSC_LITE_INSTALL_STAGING = YES
@@ -45,6 +45,13 @@ ifeq ($(BR2_PACKAGE_PCSC_LITE_EMBEDDED),y)
 PCSC_LITE_CONF_OPTS += --enable-embedded
 endif
 
+ifeq ($(BR2_PACKAGE_POLKIT),y)
+PCSC_LITE_CONF_OPTS += --enable-polkit
+PCSC_LITE_DEPENDENCIES += polkit
+else
+PCSC_LITE_CONF_OPTS += --disable-polkit
+endif
+
 ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
 PCSC_LITE_CONF_ENV += LIBS=-latomic
 endif
-- 
2.44.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH v2 1/1] package/pcsc-lite: bump version to 2.1.0
  2024-05-10  2:43   ` [Buildroot] [PATCH v2 " Zenichi Amano
@ 2024-05-10 11:21     ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-05-10 11:21 UTC (permalink / raw)
  To: Zenichi Amano; +Cc: buildroot

On Fri, 10 May 2024 11:43:51 +0900
Zenichi Amano <zenichi.amano@gahojin.co.jp> wrote:

> add configuration to disable polkit if it is not available since polkit is enabled by default in 2.0.1.
> 
> https://github.com/LudovicRousseau/PCSC/releases/tag/2.1.0
> https://github.com/LudovicRousseau/PCSC/releases/tag/2.0.3
> https://github.com/LudovicRousseau/PCSC/releases/tag/2.0.2
> https://github.com/LudovicRousseau/PCSC/releases/tag/2.0.1
> 
> Signed-off-by: Zenichi Amano <zenichi.amano@gahojin.co.jp>
> ---
>  package/pcsc-lite/pcsc-lite.hash | 2 +-
>  package/pcsc-lite/pcsc-lite.mk   | 9 ++++++++-
>  2 files changed, 9 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-10 11:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-23  6:20 [Buildroot] [PATCH 1/1] package/pcsc-lite: bump version to 2.1.0 Zenichi Amano
2024-05-09 16:07 ` Thomas Petazzoni via buildroot
2024-05-10  2:43   ` [Buildroot] [PATCH v2 " Zenichi Amano
2024-05-10 11:21     ` Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox