[Buildroot] [PATCH 1/1] package/privoxy: fix build with root

[Buildroot] [PATCH 1/1] package/privoxy: fix build with root

[Fabrice Fontaine]

Set GROUP_T when installing configuration files as root to avoid the
following build failure raised since commit
b6816034ebddd522a8fef9daa454c28fa1230dd6:

/usr/bin/install: missing destination file operand after '/home/buildroot/instance-0/output-1/target/etc'

Fixes: b6816034ebddd522a8fef9daa454c28fa1230dd6
 - http://autobuild.buildroot.org/results/eb4ccf248c9c5048e9b71058bb0311b1e0763883

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 ...0002-GNUMakefile.in-fix-root-install.patch | 35 +++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 package/privoxy/0002-GNUMakefile.in-fix-root-install.patch

diff --git a/package/privoxy/0002-GNUMakefile.in-fix-root-install.patch b/package/privoxy/0002-GNUMakefile.in-fix-root-install.patch
new file mode 100644
index 0000000000..89347c214e
--- /dev/null
+++ b/package/privoxy/0002-GNUMakefile.in-fix-root-install.patch
@@ -0,0 +1,35 @@
+From 25bd5ae1664f5603c05c72b2c38525602f33da0a Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Sun, 31 Mar 2024 19:17:45 +0200
+Subject: [PATCH] GNUMakefile.in: fix root install
+
+Set GROUP_T when installing configuration files as root to avoid the
+following build failure since commit
+4b3b267db159dc23314de3062859481b7c397e32:
+
+/usr/bin/install: missing destination file operand after '/home/buildroot/instance-0/output-1/target/etc'
+
+Fixes:
+ - http://autobuild.buildroot.org/results/eb4ccf248c9c5048e9b71058bb0311b1e0763883
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Upstream: https://lists.privoxy.org/pipermail/privoxy-devel/2024-March/000760.html
+---
+ GNUmakefile.in | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/GNUmakefile.in b/GNUmakefile.in
+index cf79aae1..db1bab59 100644
+--- a/GNUmakefile.in
++++ b/GNUmakefile.in
+@@ -927,6 +927,7 @@ install: CONF_DEST LOG_DEST PID_DEST check_doc GROUP_T
+ 					$(ECHO)  " and to install the config files as that user and/or group!" ;\
+ 					$(ECHO)  " Please read INSTALL, and create a privoxy user and group!" ;\
+ 					$(ECHO)  "*******************************************************************" ;\
++					GROUP_T=$(GROUP) ;\
+ 				fi ;\
+ 			else \
+ 				GROUP_T=$(GROUP) ;\
+-- 
+2.43.0
+
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/privoxy: fix build with root

[Thomas Petazzoni via buildroot]

On Thu,  4 Apr 2024 21:47:23 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Set GROUP_T when installing configuration files as root to avoid the
> following build failure raised since commit
> b6816034ebddd522a8fef9daa454c28fa1230dd6:
> 
> /usr/bin/install: missing destination file operand after '/home/buildroot/instance-0/output-1/target/etc'
> 
> Fixes: b6816034ebddd522a8fef9daa454c28fa1230dd6
>  - http://autobuild.buildroot.org/results/eb4ccf248c9c5048e9b71058bb0311b1e0763883
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  ...0002-GNUMakefile.in-fix-root-install.patch | 35 +++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 package/privoxy/0002-GNUMakefile.in-fix-root-install.patch

I'm confused because the Buildroot build does not run as root. So why
does this happen?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/privoxy: fix build with root

[Fabrice Fontaine]

Hi,

Le lun. 8 avr. 2024 à 23:08, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a écrit :
>
> On Thu,  4 Apr 2024 21:47:23 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > Set GROUP_T when installing configuration files as root to avoid the
> > following build failure raised since commit
> > b6816034ebddd522a8fef9daa454c28fa1230dd6:
> >
> > /usr/bin/install: missing destination file operand after '/home/buildroot/instance-0/output-1/target/etc'
> >
> > Fixes: b6816034ebddd522a8fef9daa454c28fa1230dd6
> >  - http://autobuild.buildroot.org/results/eb4ccf248c9c5048e9b71058bb0311b1e0763883
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  ...0002-GNUMakefile.in-fix-root-install.patch | 35 +++++++++++++++++++
> >  1 file changed, 35 insertions(+)
> >  create mode 100644 package/privoxy/0002-GNUMakefile.in-fix-root-install.patch
>
> I'm confused because the Buildroot build does not run as root. So why
> does this happen?

This only happens with armabuilder from Sébastien Szymanski and I
assume that the buildroot build on this autobuilder really runs as
root.

>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/privoxy: fix build with root

[Yann E. MORIN]

Fabrice, Thomas, All,

On 2024-04-08 23:11 +0200, Fabrice Fontaine spake thusly:
> Le lun. 8 avr. 2024 à 23:08, Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> a écrit :
> > On Thu,  4 Apr 2024 21:47:23 +0200
> > Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> > > Set GROUP_T when installing configuration files as root to avoid the
> > > following build failure raised since commit
> > > b6816034ebddd522a8fef9daa454c28fa1230dd6:
[--SNIP--]
> > I'm confused because the Buildroot build does not run as root. So why
> > does this happen?
> This only happens with armabuilder from Sébastien Szymanski and I
> assume that the buildroot build on this autobuilder really runs as
> root.

Indeed, Sébatien was running their auotbuilder as root in a container.
They've now switched to running as a non-root user.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/privoxy: fix build with root

[Thomas Petazzoni via buildroot]

On Thu, 9 May 2024 23:17:53 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> > This only happens with armabuilder from Sébastien Szymanski and I
> > assume that the buildroot build on this autobuilder really runs as
> > root.  
> 
> Indeed, Sébatien was running their auotbuilder as root in a container.
> They've now switched to running as a non-root user.

I have nevertheless applied the patch. It was a fairly trivial thing.
We can always drop it if we think this use-case of building as root is
too bogus. I don't have a strong opinion on this.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/privoxy: fix build with root

[Thomas Petazzoni via buildroot]

On Thu,  4 Apr 2024 21:47:23 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Set GROUP_T when installing configuration files as root to avoid the
> following build failure raised since commit
> b6816034ebddd522a8fef9daa454c28fa1230dd6:
> 
> /usr/bin/install: missing destination file operand after '/home/buildroot/instance-0/output-1/target/etc'
> 
> Fixes: b6816034ebddd522a8fef9daa454c28fa1230dd6
>  - http://autobuild.buildroot.org/results/eb4ccf248c9c5048e9b71058bb0311b1e0763883
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  ...0002-GNUMakefile.in-fix-root-install.patch | 35 +++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 package/privoxy/0002-GNUMakefile.in-fix-root-install.patch

Applied to master, thanks. Perhaps you can ping the upstream
maintainer, because he ignored your patch it seems :-/

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/privoxy: fix build with root

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Set GROUP_T when installing configuration files as root to avoid the
 > following build failure raised since commit
 > b6816034ebddd522a8fef9daa454c28fa1230dd6:

 > /usr/bin/install: missing destination file operand after '/home/buildroot/instance-0/output-1/target/etc'

 > Fixes: b6816034ebddd522a8fef9daa454c28fa1230dd6
 >  - http://autobuild.buildroot.org/results/eb4ccf248c9c5048e9b71058bb0311b1e0763883

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2024.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 1/1] package/privoxy: fix build with root

[Fabrice Fontaine]

Fix the following build failure when the configuration files are
installed as root:

id: 'privoxy': no such user
******************************************************************
 WARNING! WARNING! installing config files as root!
 It is strongly recommended to run privoxy as a non-root user,
 and to install the config files as that user and/or group!
 Please read INSTALL, and create a privoxy user and group!
*******************************************************************
make[1]: *** [GNUmakefile:861: install] Error 1

This failure is probably raised since the addition of the package in
commit f8a263fe361ab37ec6765b9ff6478c3b15e3d139 and
https://www.privoxy.org/gitweb/?p=privoxy.git;a=commit;h=26baf6bcc0b5db47b8cf5c55eece0614712b5180

Fixes:
 - http://autobuild.buildroot.org/results/28d8ca6f0e2d81d62196a0958c9274ad2c8c9871

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 ...on-t-exit-if-configuration-files-are.patch | 30 +++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 package/privoxy/0001-GNUmakefile-in-Don-t-exit-if-configuration-files-are.patch

diff --git a/package/privoxy/0001-GNUmakefile-in-Don-t-exit-if-configuration-files-are.patch b/package/privoxy/0001-GNUmakefile-in-Don-t-exit-if-configuration-files-are.patch
new file mode 100644
index 0000000000..e04d191ce0
--- /dev/null
+++ b/package/privoxy/0001-GNUmakefile-in-Don-t-exit-if-configuration-files-are.patch
@@ -0,0 +1,30 @@
+From 4b3b267db159dc23314de3062859481b7c397e32 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Sun, 17 Mar 2024 12:36:31 +0100
+Subject: [PATCH] GNUmakefile.in: Don't exit if configuration files are
+ installed as root
+
+... as this can be considered acceptable when cross-compiling
+Privoxy inside an autobuilder with only a root user.
+
+Upstream: https://www.privoxy.org/gitweb/?p=privoxy.git;a=commit;h=4b3b267db159dc23314de3062859481b7c397e32
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+---
+ GNUmakefile.in | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/GNUmakefile.in b/GNUmakefile.in
+index 04cceb15..cf79aae1 100644
+--- a/GNUmakefile.in
++++ b/GNUmakefile.in
+@@ -927,7 +927,6 @@ install: CONF_DEST LOG_DEST PID_DEST check_doc GROUP_T
+ 					$(ECHO)  " and to install the config files as that user and/or group!" ;\
+ 					$(ECHO)  " Please read INSTALL, and create a privoxy user and group!" ;\
+ 					$(ECHO)  "*******************************************************************" ;\
+-					exit 1 ;\
+ 				fi ;\
+ 			else \
+ 				GROUP_T=$(GROUP) ;\
+-- 
+2.39.2
+
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/privoxy: fix build with root

[Arnout Vandecappelle via buildroot]

On 17/03/2024 15:14, Fabrice Fontaine wrote:
> Fix the following build failure when the configuration files are
> installed as root:
> 
> id: 'privoxy': no such user
> ******************************************************************
>   WARNING! WARNING! installing config files as root!
>   It is strongly recommended to run privoxy as a non-root user,
>   and to install the config files as that user and/or group!
>   Please read INSTALL, and create a privoxy user and group!
> *******************************************************************
> make[1]: *** [GNUmakefile:861: install] Error 1
> 
> This failure is probably raised since the addition of the package in
> commit f8a263fe361ab37ec6765b9ff6478c3b15e3d139 and
> https://www.privoxy.org/gitweb/?p=privoxy.git;a=commit;h=26baf6bcc0b5db47b8cf5c55eece0614712b5180
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/28d8ca6f0e2d81d62196a0958c9274ad2c8c9871
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   ...on-t-exit-if-configuration-files-are.patch | 30 +++++++++++++++++++
>   1 file changed, 30 insertions(+)
>   create mode 100644 package/privoxy/0001-GNUmakefile-in-Don-t-exit-if-configuration-files-are.patch
> 
> diff --git a/package/privoxy/0001-GNUmakefile-in-Don-t-exit-if-configuration-files-are.patch b/package/privoxy/0001-GNUmakefile-in-Don-t-exit-if-configuration-files-are.patch
> new file mode 100644
> index 0000000000..e04d191ce0
> --- /dev/null
> +++ b/package/privoxy/0001-GNUmakefile-in-Don-t-exit-if-configuration-files-are.patch
> @@ -0,0 +1,30 @@
> +From 4b3b267db159dc23314de3062859481b7c397e32 Mon Sep 17 00:00:00 2001
> +From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +Date: Sun, 17 Mar 2024 12:36:31 +0100
> +Subject: [PATCH] GNUmakefile.in: Don't exit if configuration files are
> + installed as root
> +
> +... as this can be considered acceptable when cross-compiling
> +Privoxy inside an autobuilder with only a root user.
> +
> +Upstream: https://www.privoxy.org/gitweb/?p=privoxy.git;a=commit;h=4b3b267db159dc23314de3062859481b7c397e32
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +---
> + GNUmakefile.in | 1 -
> + 1 file changed, 1 deletion(-)
> +
> +diff --git a/GNUmakefile.in b/GNUmakefile.in
> +index 04cceb15..cf79aae1 100644
> +--- a/GNUmakefile.in
> ++++ b/GNUmakefile.in
> +@@ -927,7 +927,6 @@ install: CONF_DEST LOG_DEST PID_DEST check_doc GROUP_T
> + 					$(ECHO)  " and to install the config files as that user and/or group!" ;\
> + 					$(ECHO)  " Please read INSTALL, and create a privoxy user and group!" ;\
> + 					$(ECHO)  "*******************************************************************" ;\
> +-					exit 1 ;\
> + 				fi ;\
> + 			else \
> + 				GROUP_T=$(GROUP) ;\
> +--
> +2.39.2
> +
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/privoxy: fix build with root

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fix the following build failure when the configuration files are
 > installed as root:

 > id: 'privoxy': no such user
 > ******************************************************************
 >  WARNING! WARNING! installing config files as root!
 >  It is strongly recommended to run privoxy as a non-root user,
 >  and to install the config files as that user and/or group!
 >  Please read INSTALL, and create a privoxy user and group!
 > *******************************************************************
 > make[1]: *** [GNUmakefile:861: install] Error 1

 > This failure is probably raised since the addition of the package in
 > commit f8a263fe361ab37ec6765b9ff6478c3b15e3d139 and
 > https://www.privoxy.org/gitweb/?p=privoxy.git;a=commit;h=26baf6bcc0b5db47b8cf5c55eece0614712b5180

 > Fixes:
 >  - http://autobuild.buildroot.org/results/28d8ca6f0e2d81d62196a0958c9274ad2c8c9871

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2024.02.x, 2023.02.x and 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot