From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Kilian Zinnecker via buildroot <buildroot@buildroot.org>
Cc: Kilian Zinnecker <kilian.zinnecker@mail.de>
Subject: Re: [Buildroot] [PATCH] configs/rock5b: Remove futile unsetting of rock5b_defconfig param
Date: Fri, 10 May 2024 22:32:58 +0200 [thread overview]
Message-ID: <20240510223258.255bafa5@windsurf> (raw)
In-Reply-To: <20240310104807.10227-1-kilian.zinnecker@mail.de>
On Sun, 10 Mar 2024 11:48:07 +0100
Kilian Zinnecker via buildroot <buildroot@buildroot.org> wrote:
> The rock5b_defconfig contained a
> "# BR2BR2_LINUX_KERNEL_INTREE_DTS_NAME is not set" line. This
> caused check-dotconfig.py to throw a warning in the buildroot CI,
> because the explicit unsetting of the parameter is not taken on in
> the actual dotconfig, but instead the dotconfig will contain the
> line 'BR2BR2_LINUX_KERNEL_INTREE_DTS_NAME=""'.
>
> This patch removes the parameter from the rock5b_defconfig. The
> resulting dotconfig from the original rock5b_defconfig and the
> rock5b_defconfig without the parameter is identical, but the
> check-dotconfig.py does not throw a warning anymore.
>
> Signed-off-by: Kilian Zinnecker <kilian.zinnecker@mail.de>
> ---
> configs/rock5b_defconfig | 1 -
> 1 file changed, 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-05-10 20:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 10:48 [Buildroot] [PATCH] configs/rock5b: Remove futile unsetting of rock5b_defconfig param Kilian Zinnecker via buildroot
2024-05-10 20:32 ` Thomas Petazzoni via buildroot [this message]
2024-06-08 7:09 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510223258.255bafa5@windsurf \
--to=buildroot@buildroot.org \
--cc=kilian.zinnecker@mail.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox