[Buildroot] [PATCH] configs/rock5b: Remove futile unsetting of rock5b_defconfig param

[Buildroot] [PATCH] configs/rock5b: Remove futile unsetting of rock5b_defconfig param

[Kilian Zinnecker via buildroot]

The rock5b_defconfig contained a
"# BR2BR2_LINUX_KERNEL_INTREE_DTS_NAME is not set" line. This
caused check-dotconfig.py to throw a warning in the buildroot CI,
because the explicit unsetting of the parameter is not taken on in
the actual dotconfig, but instead the dotconfig will contain the
line 'BR2BR2_LINUX_KERNEL_INTREE_DTS_NAME=""'.

This patch removes the parameter from the rock5b_defconfig. The
resulting dotconfig from the original rock5b_defconfig and the
rock5b_defconfig without the parameter is identical, but the
check-dotconfig.py does not throw a warning anymore.

Signed-off-by: Kilian Zinnecker <kilian.zinnecker@mail.de>
---
 configs/rock5b_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configs/rock5b_defconfig b/configs/rock5b_defconfig
index 7175aa66bf..1ac42c8dc5 100644
--- a/configs/rock5b_defconfig
+++ b/configs/rock5b_defconfig
@@ -14,7 +14,6 @@ BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/radxa/kernel.git"
 BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="52f51a2b5ba178f331af62260d2da86d7472c14b"
 BR2_LINUX_KERNEL_DEFCONFIG="rockchip_linux"
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
-# BR2_LINUX_KERNEL_INTREE_DTS_NAME is not set
 BR2_LINUX_KERNEL_CUSTOM_DTS_PATH="board/radxa/rock5b/rock5b.dts"
 BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT=y
 BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/radxa/rock5b/linux.fragment"
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] configs/rock5b: Remove futile unsetting of rock5b_defconfig param

[Thomas Petazzoni via buildroot]

On Sun, 10 Mar 2024 11:48:07 +0100
Kilian Zinnecker via buildroot <buildroot@buildroot.org> wrote:

> The rock5b_defconfig contained a
> "# BR2BR2_LINUX_KERNEL_INTREE_DTS_NAME is not set" line. This
> caused check-dotconfig.py to throw a warning in the buildroot CI,
> because the explicit unsetting of the parameter is not taken on in
> the actual dotconfig, but instead the dotconfig will contain the
> line 'BR2BR2_LINUX_KERNEL_INTREE_DTS_NAME=""'.
> 
> This patch removes the parameter from the rock5b_defconfig. The
> resulting dotconfig from the original rock5b_defconfig and the
> rock5b_defconfig without the parameter is identical, but the
> check-dotconfig.py does not throw a warning anymore.
> 
> Signed-off-by: Kilian Zinnecker <kilian.zinnecker@mail.de>
> ---
>  configs/rock5b_defconfig | 1 -
>  1 file changed, 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] configs/rock5b: Remove futile unsetting of rock5b_defconfig param

[Peter Korsgaard]

>>>>> "Kilian" == Kilian Zinnecker via buildroot <buildroot@buildroot.org> writes:

 > The rock5b_defconfig contained a
 > "# BR2BR2_LINUX_KERNEL_INTREE_DTS_NAME is not set" line. This
 > caused check-dotconfig.py to throw a warning in the buildroot CI,
 > because the explicit unsetting of the parameter is not taken on in
 > the actual dotconfig, but instead the dotconfig will contain the
 > line 'BR2BR2_LINUX_KERNEL_INTREE_DTS_NAME=""'.

 > This patch removes the parameter from the rock5b_defconfig. The
 > resulting dotconfig from the original rock5b_defconfig and the
 > rock5b_defconfig without the parameter is identical, but the
 > check-dotconfig.py does not throw a warning anymore.

 > Signed-off-by: Kilian Zinnecker <kilian.zinnecker@mail.de>

Committed to 2024.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot