* [Buildroot] [PATCH 1/1] package/openblas: fix build without MMU
@ 2024-03-10 18:24 Fabrice Fontaine
2024-05-10 20:53 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 3+ messages in thread
From: Fabrice Fontaine @ 2024-03-10 18:24 UTC (permalink / raw)
To: buildroot; +Cc: Julien Olivain, Fabrice Fontaine
Fix the following build failure without MMU:
/home/buildroot/autobuild/instance-1/output-1/host/riscv64-buildroot-linux-uclibc/bin/ld.real: test_fork.o: in function `.L6':
test_fork.c:(.text+0x120): undefined reference to `fork'
autobuilder failure is raised since the addition of RISC-V support by
commit c789bcddf0fb17580bef0cdc45b5334a90ecdf13
Fixes:
- http://autobuild.buildroot.org/results/b9d097ae077f2cb40fc60de94bf25423636af005
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
...ding-against-an-uClibc-that-does-not.patch | 28 +++++++++++++++++++
...-uclibc-that-does-not-implement-fork.patch | 28 +++++++++++++++++++
2 files changed, 56 insertions(+)
create mode 100644 package/openblas/0002-Skip-the-fork-test-when-building-against-an-uClibc-that-does-not.patch
create mode 100644 package/openblas/0003-Skip-test-when-building-with-a-uclibc-that-does-not-implement-fork.patch
diff --git a/package/openblas/0002-Skip-the-fork-test-when-building-against-an-uClibc-that-does-not.patch b/package/openblas/0002-Skip-the-fork-test-when-building-against-an-uClibc-that-does-not.patch
new file mode 100644
index 0000000000..9b52dbfe05
--- /dev/null
+++ b/package/openblas/0002-Skip-the-fork-test-when-building-against-an-uClibc-that-does-not.patch
@@ -0,0 +1,28 @@
+From 30e8d255de4cfdfa2fdd7272e12d1efd6e74bc7b Mon Sep 17 00:00:00 2001
+From: Martin Kroeker <martin@ruby.chemie.uni-freiburg.de>
+Date: Sun, 10 Mar 2024 00:05:01 +0100
+Subject: [PATCH] Skip the fork test when building against an uClibc that does
+ not implement fork
+
+Signed-off-bt: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Upstream: https://github.com/OpenMathLib/OpenBLAS/commit/91b1fb7f9b9f053919e79e9b898060b90f5b0af3
+---
+ utest/test_fork.c | 5 +++++
+ 1 file changed, 5 insertions(+)
+
+diff --git a/utest/test_fork.c b/utest/test_fork.c
+index bd531e7fb8..558026031b 100644
+--- a/utest/test_fork.c
++++ b/utest/test_fork.c
+@@ -64,6 +64,11 @@ static void check_dgemm(double *a, double *b, double *result, double *expected,
+
+ CTEST(fork, safety)
+ {
++#ifdef __UCLIBC__
++#if !defined __UCLIBC_HAS_STUBS__ && !defined __ARCH_USE_MMU__
++exit(0);
++#endif
++#endif
+ #ifndef BUILD_DOUBLE
+ exit(0);
+ #else
diff --git a/package/openblas/0003-Skip-test-when-building-with-a-uclibc-that-does-not-implement-fork.patch b/package/openblas/0003-Skip-test-when-building-with-a-uclibc-that-does-not-implement-fork.patch
new file mode 100644
index 0000000000..2e46266331
--- /dev/null
+++ b/package/openblas/0003-Skip-test-when-building-with-a-uclibc-that-does-not-implement-fork.patch
@@ -0,0 +1,28 @@
+From 8a665f0d57a355932e9571449f4cf30caed56ae1 Mon Sep 17 00:00:00 2001
+From: Martin Kroeker <martin@ruby.chemie.uni-freiburg.de>
+Date: Sun, 10 Mar 2024 19:08:03 +0100
+Subject: [PATCH] Skip test when building with a uclibc that does not implement
+ fork
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Upstream: https://github.com/OpenMathLib/OpenBLAS/pull/4546
+---
+ utest/test_post_fork.c | 5 +++++
+ 1 file changed, 5 insertions(+)
+
+diff --git a/utest/test_post_fork.c b/utest/test_post_fork.c
+index 9370a02cee..6d640aebb6 100644
+--- a/utest/test_post_fork.c
++++ b/utest/test_post_fork.c
+@@ -67,6 +67,11 @@ static void check_dgemm(double *a, double *b, double *result, double *expected,
+
+ CTEST(fork, safety_after_fork_in_parent)
+ {
++#ifdef __UCLIBC__
++#if !defined __UCLIBC_HAS_STUBS__ && !defined __ARCH_USE_MMU__
++exit(0);
++#endif
++#endif
+ #ifndef BUILD_DOUBLE
+ exit(0);
+ #else
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/openblas: fix build without MMU
2024-03-10 18:24 [Buildroot] [PATCH 1/1] package/openblas: fix build without MMU Fabrice Fontaine
@ 2024-05-10 20:53 ` Thomas Petazzoni via buildroot
2024-05-13 10:55 ` Fabrice Fontaine
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-05-10 20:53 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Julien Olivain, buildroot
On Sun, 10 Mar 2024 19:24:39 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fix the following build failure without MMU:
>
> /home/buildroot/autobuild/instance-1/output-1/host/riscv64-buildroot-linux-uclibc/bin/ld.real: test_fork.o: in function `.L6':
> test_fork.c:(.text+0x120): undefined reference to `fork'
>
> autobuilder failure is raised since the addition of RISC-V support by
> commit c789bcddf0fb17580bef0cdc45b5334a90ecdf13
>
> Fixes:
> - http://autobuild.buildroot.org/results/b9d097ae077f2cb40fc60de94bf25423636af005
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> ...ding-against-an-uClibc-that-does-not.patch | 28 +++++++++++++++++++
> ...-uclibc-that-does-not-implement-fork.patch | 28 +++++++++++++++++++
> 2 files changed, 56 insertions(+)
> create mode 100644 package/openblas/0002-Skip-the-fork-test-when-building-against-an-uClibc-that-does-not.patch
> create mode 100644 package/openblas/0003-Skip-test-when-building-with-a-uclibc-that-does-not-implement-fork.patch
It seems like following the bump in
59b48b5cff057f2429b1143d6f50c39d93ca8ef3, these patches are no longer
needed. Could you confirm? At least patch 0002 no longer applies.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/openblas: fix build without MMU
2024-05-10 20:53 ` Thomas Petazzoni via buildroot
@ 2024-05-13 10:55 ` Fabrice Fontaine
0 siblings, 0 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2024-05-13 10:55 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Julien Olivain, buildroot
Hello,
Le ven. 10 mai 2024 à 22:53, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a écrit :
>
> On Sun, 10 Mar 2024 19:24:39 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > Fix the following build failure without MMU:
> >
> > /home/buildroot/autobuild/instance-1/output-1/host/riscv64-buildroot-linux-uclibc/bin/ld.real: test_fork.o: in function `.L6':
> > test_fork.c:(.text+0x120): undefined reference to `fork'
> >
> > autobuilder failure is raised since the addition of RISC-V support by
> > commit c789bcddf0fb17580bef0cdc45b5334a90ecdf13
> >
> > Fixes:
> > - http://autobuild.buildroot.org/results/b9d097ae077f2cb40fc60de94bf25423636af005
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > ...ding-against-an-uClibc-that-does-not.patch | 28 +++++++++++++++++++
> > ...-uclibc-that-does-not-implement-fork.patch | 28 +++++++++++++++++++
> > 2 files changed, 56 insertions(+)
> > create mode 100644 package/openblas/0002-Skip-the-fork-test-when-building-against-an-uClibc-that-does-not.patch
> > create mode 100644 package/openblas/0003-Skip-test-when-building-with-a-uclibc-that-does-not-implement-fork.patch
>
> It seems like following the bump in
> 59b48b5cff057f2429b1143d6f50c39d93ca8ef3, these patches are no longer
> needed. Could you confirm? At least patch 0002 no longer applies.
Yes, I confirm that both patches are included in version 0.3.27.
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,
Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-13 10:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-10 18:24 [Buildroot] [PATCH 1/1] package/openblas: fix build without MMU Fabrice Fontaine
2024-05-10 20:53 ` Thomas Petazzoni via buildroot
2024-05-13 10:55 ` Fabrice Fontaine
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox