[Buildroot] [PATCH 1/1] package/zxing-cpp: needs threads

[Buildroot] [PATCH 1/1] package/zxing-cpp: needs threads

[Fabrice Fontaine]

threads are mandatory since switch to an active fork in commit
456a7398316655ad0b669635f580e4887c24a700:

CMake Error at /home/buildroot/autobuild/run/instance-1/output-1/host/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Threads (missing: Threads_FOUND)

Fixes: 456a7398316655ad0b669635f580e4887c24a700
 - http://autobuild.buildroot.org/results/b600582d9c5407c7324af70d61fa5c1f96d929f6

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/gstreamer1/gst1-plugins-bad/Config.in | 5 +++--
 package/zxing-cpp/Config.in                   | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/package/gstreamer1/gst1-plugins-bad/Config.in b/package/gstreamer1/gst1-plugins-bad/Config.in
index cad02a18d4..26cdf87d39 100644
--- a/package/gstreamer1/gst1-plugins-bad/Config.in
+++ b/package/gstreamer1/gst1-plugins-bad/Config.in
@@ -748,11 +748,12 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_ZXING
 	depends on !BR2_STATIC_LIBS # zxing-cpp
 	depends on BR2_USE_WCHAR # zxing-cpp
 	depends on BR2_INSTALL_LIBSTDCPP # zxing-cpp
+	depends on BR2_TOOLCHAIN_HAS_THREADS # zxing-cpp
 	select BR2_PACKAGE_ZXING_CPP
 
-comment "zxing plugin needs a toolchain w/ C++, wchar, dynamic library"
+comment "zxing plugin needs a toolchain w/ C++, wchar, dynamic library, threads"
 	depends on BR2_STATIC_LIBS || !BR2_USE_WCHAR || \
-		!BR2_INSTALL_LIBSTDCPP
+		!BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
 
 endif
 
diff --git a/package/zxing-cpp/Config.in b/package/zxing-cpp/Config.in
index 0d8b79538d..b72a00ec35 100644
--- a/package/zxing-cpp/Config.in
+++ b/package/zxing-cpp/Config.in
@@ -1,12 +1,13 @@
-comment "zxing-cpp needs a toolchain w/ C++, wchar, dynamic library"
+comment "zxing-cpp needs a toolchain w/ C++, wchar, dynamic library, threads"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
-		BR2_STATIC_LIBS
+		BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
 
 config BR2_PACKAGE_ZXING_CPP
 	bool "zxing-cpp"
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_USE_WCHAR
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_STB
 	select BR2_PACKAGE_PYTHON_PYBIND if BR2_PACKAGE_PYTHON3
 	help
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/zxing-cpp: needs threads

[Thomas Petazzoni via buildroot]

On Thu,  7 Mar 2024 11:16:38 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> threads are mandatory since switch to an active fork in commit
> 456a7398316655ad0b669635f580e4887c24a700:
> 
> CMake Error at /home/buildroot/autobuild/run/instance-1/output-1/host/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
>   Could NOT find Threads (missing: Threads_FOUND)
> 
> Fixes: 456a7398316655ad0b669635f580e4887c24a700
>  - http://autobuild.buildroot.org/results/b600582d9c5407c7324af70d61fa5c1f96d929f6
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/gstreamer1/gst1-plugins-bad/Config.in | 5 +++--
>  package/zxing-cpp/Config.in                   | 5 +++--
>  2 files changed, 6 insertions(+), 4 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/zxing-cpp: needs threads

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > threads are mandatory since switch to an active fork in commit
 > 456a7398316655ad0b669635f580e4887c24a700:

 > CMake Error at /home/buildroot/autobuild/run/instance-1/output-1/host/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
 >   Could NOT find Threads (missing: Threads_FOUND)

 > Fixes: 456a7398316655ad0b669635f580e4887c24a700
 >  - http://autobuild.buildroot.org/results/b600582d9c5407c7324af70d61fa5c1f96d929f6

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2024.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot