From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: friedtj@free.fr
Cc: buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] package/gnuradio: activate gr-iio
Date: Sun, 12 May 2024 09:59:11 +0200 [thread overview]
Message-ID: <20240512095911.17df30df@windsurf> (raw)
In-Reply-To: <1322751925.1056008247.1711141112983.JavaMail.zimbra@free.fr>
Hello Jean-Michel,
On Fri, 22 Mar 2024 21:58:32 +0100 (CET)
friedtj@free.fr wrote:
> From e26989cc30d4476d7384e62064cfa6486706bf8b Mon Sep 17 00:00:00 2001
> From: JM Friedt <jmfriedt@femto-st.fr>
> Date: Fri, 22 Mar 2024 20:55:44 +0000
> Subject: [PATCH 1/1] package/gnuradio: add IIO as optional feature of GNU Radio
I'm not sure what happened, but your patch is badly formatted. Also
your Signed-off-by line is missing.
> +config BR2_PACKAGE_GNURADIO_IIO
> + bool "gr-iio support"
> + select BR2_PACKAGE_LIBIIO
Since you select libiio...
> + select BR2_PACKAGE_GNURADIO_BLOCKS
> + help
> + IIO support
> +
> config BR2_PACKAGE_GNURADIO_NETWORK
> bool "gr-network support"
> select BR2_PACKAGE_GNURADIO_BLOCKS
> diff --git a/package/gnuradio/gnuradio.mk b/package/gnuradio/gnuradio.mk
> index 4e82c9e129..2267e7561a 100644
> --- a/package/gnuradio/gnuradio.mk
> +++ b/package/gnuradio/gnuradio.mk
> @@ -112,6 +112,12 @@ else
> GNURADIO_CONF_OPTS += -DENABLE_GR_NETWORK=OFF
> endif
>
> +ifeq ($(BR2_PACKAGE_GNURADIO_IIO),y)
> +GNURADIO_CONF_OPTS += -DENABLE_GR_IIO=ON
don't you need libiio as a build dependency?
> +else
> +GNURADIO_CONF_OPTS += -DENABLE_GR_IIO=OFF
> +endif
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-05-12 7:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 6:03 [Buildroot] package/gnuradio: activate gr-iio friedtj
2024-03-22 20:58 ` friedtj
2024-05-12 7:59 ` Thomas Petazzoni via buildroot [this message]
2024-05-16 8:34 ` [Buildroot] [PATCH 1/1] package/gnuradio: add optional IIO support to GNU Radio friedtj
2024-06-19 19:39 ` Arnout Vandecappelle via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240512095911.17df30df@windsurf \
--to=buildroot@buildroot.org \
--cc=friedtj@free.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox