Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] package/gnuradio: activate gr-iio
@ 2024-03-22  6:03 friedtj
  2024-03-22 20:58 ` friedtj
  0 siblings, 1 reply; 5+ messages in thread
From: friedtj @ 2024-03-22  6:03 UTC (permalink / raw)
  To: buildroot

From 3b5476d595b8db8a9920fb83348eaf5e2047b0d3 Mon Sep 17 00:00:00 2001
From: JM Friedt <jmfriedt@femto-st.fr>
Date: Fri, 22 Mar 2024 05:56:38 +0000
Subject: [PATCH 1/1] package/gnuradio: activate gr-iio

---
 package/gnuradio/gnuradio.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/gnuradio/gnuradio.mk b/package/gnuradio/gnuradio.mk
index 4e82c9e129..ef4965c578 100644
--- a/package/gnuradio/gnuradio.mk
+++ b/package/gnuradio/gnuradio.mk
@@ -25,6 +25,7 @@ GNURADIO_CONF_OPTS = \
        -DENABLE_EXAMPLES=OFF \
        -DENABLE_GNURADIO_RUNTIME=ON \
        -DENABLE_TESTING=OFF \
+       -DENABLE_GR_IIO=ON \
        -DXMLTO_EXECUTABLE=NOTFOUND
 
 # For third-party blocks, the gnuradio libraries are mandatory at
-- 
2.43.0

Signed-off-by: Jean-Michel Friedt <jmfriedt@femto-st.fr> 

Prior to GNU Radio 3.10, gr-iio, Analog Device's Industrial I/O driver for
GNU Radio, used to be shipped as an out of tree (OOT) module. Since GNU
Radio 3.10, gr-iio is part of the main software but not active by default.
This patch activates the gr-iio option.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Buildroot] package/gnuradio: activate gr-iio
  2024-03-22  6:03 [Buildroot] package/gnuradio: activate gr-iio friedtj
@ 2024-03-22 20:58 ` friedtj
  2024-05-12  7:59   ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 5+ messages in thread
From: friedtj @ 2024-03-22 20:58 UTC (permalink / raw)
  To: buildroot

From e26989cc30d4476d7384e62064cfa6486706bf8b Mon Sep 17 00:00:00 2001
From: JM Friedt <jmfriedt@femto-st.fr>
Date: Fri, 22 Mar 2024 20:55:44 +0000
Subject: [PATCH 1/1] package/gnuradio: add IIO as optional feature of GNU Radio

---
 package/gnuradio/Config.in   | 7 +++++++
 package/gnuradio/gnuradio.mk | 6 ++++++
 2 files changed, 13 insertions(+)

diff --git a/package/gnuradio/Config.in b/package/gnuradio/Config.in
index be997e91e2..d9ad650672 100644
--- a/package/gnuradio/Config.in
+++ b/package/gnuradio/Config.in
@@ -136,6 +136,13 @@ config BR2_PACKAGE_GNURADIO_FILTER
        help
          Filter signal processing blocks
 
+config BR2_PACKAGE_GNURADIO_IIO
+       bool "gr-iio support"
+       select BR2_PACKAGE_LIBIIO
+       select BR2_PACKAGE_GNURADIO_BLOCKS
+       help
+         IIO support
+
 config BR2_PACKAGE_GNURADIO_NETWORK
        bool "gr-network support"
        select BR2_PACKAGE_GNURADIO_BLOCKS
diff --git a/package/gnuradio/gnuradio.mk b/package/gnuradio/gnuradio.mk
index 4e82c9e129..2267e7561a 100644
--- a/package/gnuradio/gnuradio.mk
+++ b/package/gnuradio/gnuradio.mk
@@ -112,6 +112,12 @@ else
 GNURADIO_CONF_OPTS += -DENABLE_GR_NETWORK=OFF
 endif
 
+ifeq ($(BR2_PACKAGE_GNURADIO_IIO),y)
+GNURADIO_CONF_OPTS += -DENABLE_GR_IIO=ON
+else
+GNURADIO_CONF_OPTS += -DENABLE_GR_IIO=OFF
+endif
+
 ifeq ($(BR2_PACKAGE_GNURADIO_PYTHON),y)
 GNURADIO_DEPENDENCIES += python3 python-pybind \
        host-python-numpy host-python-packaging
-- 
2.43.0

Signed-off-by: Jean-Michel Friedt <jmfriedt@femto-st.fr>

Optional activation of the gr-iio option rather than forced activation of the option.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Buildroot] package/gnuradio: activate gr-iio
  2024-03-22 20:58 ` friedtj
@ 2024-05-12  7:59   ` Thomas Petazzoni via buildroot
  2024-05-16  8:34     ` [Buildroot] [PATCH 1/1] package/gnuradio: add optional IIO support to GNU Radio friedtj
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-05-12  7:59 UTC (permalink / raw)
  To: friedtj; +Cc: buildroot

Hello Jean-Michel,

On Fri, 22 Mar 2024 21:58:32 +0100 (CET)
friedtj@free.fr wrote:

> From e26989cc30d4476d7384e62064cfa6486706bf8b Mon Sep 17 00:00:00 2001
> From: JM Friedt <jmfriedt@femto-st.fr>
> Date: Fri, 22 Mar 2024 20:55:44 +0000
> Subject: [PATCH 1/1] package/gnuradio: add IIO as optional feature of GNU Radio

I'm not sure what happened, but your patch is badly formatted. Also
your Signed-off-by line is missing.

> +config BR2_PACKAGE_GNURADIO_IIO
> +       bool "gr-iio support"
> +       select BR2_PACKAGE_LIBIIO

Since you select libiio...

> +       select BR2_PACKAGE_GNURADIO_BLOCKS
> +       help
> +         IIO support
> +
>  config BR2_PACKAGE_GNURADIO_NETWORK
>         bool "gr-network support"
>         select BR2_PACKAGE_GNURADIO_BLOCKS
> diff --git a/package/gnuradio/gnuradio.mk b/package/gnuradio/gnuradio.mk
> index 4e82c9e129..2267e7561a 100644
> --- a/package/gnuradio/gnuradio.mk
> +++ b/package/gnuradio/gnuradio.mk
> @@ -112,6 +112,12 @@ else
>  GNURADIO_CONF_OPTS += -DENABLE_GR_NETWORK=OFF
>  endif
>  
> +ifeq ($(BR2_PACKAGE_GNURADIO_IIO),y)
> +GNURADIO_CONF_OPTS += -DENABLE_GR_IIO=ON

don't you need libiio as a build dependency?

> +else
> +GNURADIO_CONF_OPTS += -DENABLE_GR_IIO=OFF
> +endif

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 1/1] package/gnuradio: add optional IIO support to GNU Radio
  2024-05-12  7:59   ` Thomas Petazzoni via buildroot
@ 2024-05-16  8:34     ` friedtj
  2024-06-19 19:39       ` Arnout Vandecappelle via buildroot
  0 siblings, 1 reply; 5+ messages in thread
From: friedtj @ 2024-05-16  8:34 UTC (permalink / raw)
  To: buildroot; +Cc: gwenhael.goavec-merou

Indeed libiio dependency must be activated. The following patch aims at
providing optional IIO support in GNU Radio since it is now included and
no longer an external package:


Signed-off-by: Jean-Michel Friedt <jmfriedt@femto-st.fr>
---
 package/gnuradio/Config.in   | 7 +++++++
 package/gnuradio/gnuradio.mk | 7 +++++++
 2 files changed, 14 insertions(+)

diff --git a/package/gnuradio/Config.in b/package/gnuradio/Config.in
index be997e91e2..78bee9e221 100644
--- a/package/gnuradio/Config.in
+++ b/package/gnuradio/Config.in
@@ -136,6 +136,13 @@ config BR2_PACKAGE_GNURADIO_FILTER
        help
          Filter signal processing blocks
 
+config BR2_PACKAGE_GNURADIO_IIO
+        bool "gr-iio support"
+        select BR2_PACKAGE_LIBIIO
+        select BR2_PACKAGE_GNURADIO_BLOCKS
+        help
+          IIO support
+
 config BR2_PACKAGE_GNURADIO_NETWORK
        bool "gr-network support"
        select BR2_PACKAGE_GNURADIO_BLOCKS
diff --git a/package/gnuradio/gnuradio.mk b/package/gnuradio/gnuradio.mk
index 4e82c9e129..bdaab86f35 100644
--- a/package/gnuradio/gnuradio.mk
+++ b/package/gnuradio/gnuradio.mk
@@ -112,6 +112,13 @@ else
 GNURADIO_CONF_OPTS += -DENABLE_GR_NETWORK=OFF
 endif
 
+ifeq ($(BR2_PACKAGE_GNURADIO_IIO),y)
+GNURADIO_CONF_OPTS += -DENABLE_GR_IIO=ON
+GNURADIO_DEPENDENCIES += libiio
+else
+GNURADIO_CONF_OPTS += -DENABLE_GR_IIO=OFF
+endif
+
 ifeq ($(BR2_PACKAGE_GNURADIO_PYTHON),y)
 GNURADIO_DEPENDENCIES += python3 python-pybind \
        host-python-numpy host-python-packaging
-- 
2.43.0

Thanks, 

----- Mail original -----
De: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
À: "friedtj" <friedtj@free.fr>
Cc: "buildroot" <buildroot@buildroot.org>
Envoyé: Dimanche 12 Mai 2024 09:59:11
Objet: Re: [Buildroot] package/gnuradio: activate gr-iio

Hello Jean-Michel,

On Fri, 22 Mar 2024 21:58:32 +0100 (CET)
friedtj@free.fr wrote:

> From e26989cc30d4476d7384e62064cfa6486706bf8b Mon Sep 17 00:00:00 2001
> From: JM Friedt <jmfriedt@femto-st.fr>
> Date: Fri, 22 Mar 2024 20:55:44 +0000
> Subject: [PATCH 1/1] package/gnuradio: add IIO as optional feature of GNU Radio

I'm not sure what happened, but your patch is badly formatted. Also
your Signed-off-by line is missing.

> +config BR2_PACKAGE_GNURADIO_IIO
> +       bool "gr-iio support"
> +       select BR2_PACKAGE_LIBIIO

Since you select libiio...

> +       select BR2_PACKAGE_GNURADIO_BLOCKS
> +       help
> +         IIO support
> +
>  config BR2_PACKAGE_GNURADIO_NETWORK
>         bool "gr-network support"
>         select BR2_PACKAGE_GNURADIO_BLOCKS
> diff --git a/package/gnuradio/gnuradio.mk b/package/gnuradio/gnuradio.mk
> index 4e82c9e129..2267e7561a 100644
> --- a/package/gnuradio/gnuradio.mk
> +++ b/package/gnuradio/gnuradio.mk
> @@ -112,6 +112,12 @@ else
>  GNURADIO_CONF_OPTS += -DENABLE_GR_NETWORK=OFF
>  endif
>  
> +ifeq ($(BR2_PACKAGE_GNURADIO_IIO),y)
> +GNURADIO_CONF_OPTS += -DENABLE_GR_IIO=ON

don't you need libiio as a build dependency?

> +else
> +GNURADIO_CONF_OPTS += -DENABLE_GR_IIO=OFF
> +endif

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/gnuradio: add optional IIO support to GNU Radio
  2024-05-16  8:34     ` [Buildroot] [PATCH 1/1] package/gnuradio: add optional IIO support to GNU Radio friedtj
@ 2024-06-19 19:39       ` Arnout Vandecappelle via buildroot
  0 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle via buildroot @ 2024-06-19 19:39 UTC (permalink / raw)
  To: friedtj, buildroot; +Cc: gwenhael.goavec-merou



On 16/05/2024 10:34, friedtj@free.fr wrote:
> Indeed libiio dependency must be activated. The following patch aims at
> providing optional IIO support in GNU Radio since it is now included and
> no longer an external package:
> 
> 
> Signed-off-by: Jean-Michel Friedt <jmfriedt@femto-st.fr>

  tabs/spaces were again mangled in this patched, but I managed to fix that and 
applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/gnuradio/Config.in   | 7 +++++++
>   package/gnuradio/gnuradio.mk | 7 +++++++
>   2 files changed, 14 insertions(+)
> 
> diff --git a/package/gnuradio/Config.in b/package/gnuradio/Config.in
> index be997e91e2..78bee9e221 100644
> --- a/package/gnuradio/Config.in
> +++ b/package/gnuradio/Config.in
> @@ -136,6 +136,13 @@ config BR2_PACKAGE_GNURADIO_FILTER
>          help
>            Filter signal processing blocks
>   
> +config BR2_PACKAGE_GNURADIO_IIO
> +        bool "gr-iio support"
> +        select BR2_PACKAGE_LIBIIO
> +        select BR2_PACKAGE_GNURADIO_BLOCKS
> +        help
> +          IIO support
> +
>   config BR2_PACKAGE_GNURADIO_NETWORK
>          bool "gr-network support"
>          select BR2_PACKAGE_GNURADIO_BLOCKS
> diff --git a/package/gnuradio/gnuradio.mk b/package/gnuradio/gnuradio.mk
> index 4e82c9e129..bdaab86f35 100644
> --- a/package/gnuradio/gnuradio.mk
> +++ b/package/gnuradio/gnuradio.mk
> @@ -112,6 +112,13 @@ else
>   GNURADIO_CONF_OPTS += -DENABLE_GR_NETWORK=OFF
>   endif
>   
> +ifeq ($(BR2_PACKAGE_GNURADIO_IIO),y)
> +GNURADIO_CONF_OPTS += -DENABLE_GR_IIO=ON
> +GNURADIO_DEPENDENCIES += libiio
> +else
> +GNURADIO_CONF_OPTS += -DENABLE_GR_IIO=OFF
> +endif
> +
>   ifeq ($(BR2_PACKAGE_GNURADIO_PYTHON),y)
>   GNURADIO_DEPENDENCIES += python3 python-pybind \
>          host-python-numpy host-python-packaging
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-06-19 19:40 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-22  6:03 [Buildroot] package/gnuradio: activate gr-iio friedtj
2024-03-22 20:58 ` friedtj
2024-05-12  7:59   ` Thomas Petazzoni via buildroot
2024-05-16  8:34     ` [Buildroot] [PATCH 1/1] package/gnuradio: add optional IIO support to GNU Radio friedtj
2024-06-19 19:39       ` Arnout Vandecappelle via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox