[Buildroot] [PATCH v1 1/1] boot/xilinx-prebuilt/Config.in: versal needs bootgen

[Buildroot] [PATCH v1 1/1] boot/xilinx-prebuilt/Config.in: versal needs bootgen

[Neal Frager via buildroot]

When building for versal targets, bootgen is required for packaging the
boot.bin.  This patch adds the dependency.

Signed-off-by: Neal Frager <neal.frager@amd.com>
---
 boot/xilinx-prebuilt/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/boot/xilinx-prebuilt/Config.in b/boot/xilinx-prebuilt/Config.in
index d3df1c06e7..a1c2075d7c 100644
--- a/boot/xilinx-prebuilt/Config.in
+++ b/boot/xilinx-prebuilt/Config.in
@@ -28,6 +28,7 @@ config BR2_TARGET_XILINX_PREBUILT_KRIA
 
 config BR2_TARGET_XILINX_PREBUILT_VERSAL
 	bool "versal"
+	depends on BR2_PACKAGE_HOST_BOOTGEN
 
 endchoice
 
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v1 1/1] boot/xilinx-prebuilt/Config.in: versal needs bootgen

[Luca Ceresoli via buildroot]

Hi Neal,

On Fri, 28 Jun 2024 13:24:36 +0100
Neal Frager <neal.frager@amd.com> wrote:

> When building for versal targets, bootgen is required for packaging the
> boot.bin.  This patch adds the dependency.
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
>  boot/xilinx-prebuilt/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/boot/xilinx-prebuilt/Config.in b/boot/xilinx-prebuilt/Config.in
> index d3df1c06e7..a1c2075d7c 100644
> --- a/boot/xilinx-prebuilt/Config.in
> +++ b/boot/xilinx-prebuilt/Config.in
> @@ -28,6 +28,7 @@ config BR2_TARGET_XILINX_PREBUILT_KRIA
>  
>  config BR2_TARGET_XILINX_PREBUILT_VERSAL
>  	bool "versal"
> +	depends on BR2_PACKAGE_HOST_BOOTGEN

Looking at this better, I'm not sure it's the right thing to do.

xilinx-prebuilt can "build" perfectly without bootgen.

This is similar to genimage, which is not needed to build any Buildroot
package, but is used by several defconfigs to generate a bootable SD
card image afterwards. Thus each of these defconfigs also sets
BR2_PACKAGE_HOST_GENIMAGE=y.

Sure bootgen differs in that (as far as I understand) the *typical*
usage of xilinx-prebuilt requires host-bootgen in a post-build script.
However in principle another tool could be used in its place.

So as I said I'm not sure. Adding the 'depends on', possibly with a
line of comment to clarify this, could still be seen as a convenience,
but it would break existing defconfigs if the 'depends on' were removed
later on to accommodate other use cases that do not involve bootgen.

If there are no stronger opinions I'd vote to not add this.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v1 1/1] boot/xilinx-prebuilt/Config.in: versal needs bootgen

[Frager, Neal via buildroot]

Hi Luca,

> When building for versal targets, bootgen is required for packaging the
> boot.bin.  This patch adds the dependency.
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
>  boot/xilinx-prebuilt/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/boot/xilinx-prebuilt/Config.in b/boot/xilinx-prebuilt/Config.in
> index d3df1c06e7..a1c2075d7c 100644
> --- a/boot/xilinx-prebuilt/Config.in
> +++ b/boot/xilinx-prebuilt/Config.in
> @@ -28,6 +28,7 @@ config BR2_TARGET_XILINX_PREBUILT_KRIA
>  
>  config BR2_TARGET_XILINX_PREBUILT_VERSAL
>  	bool "versal"
> +	depends on BR2_PACKAGE_HOST_BOOTGEN

> Looking at this better, I'm not sure it's the right thing to do.

> xilinx-prebuilt can "build" perfectly without bootgen.

> This is similar to genimage, which is not needed to build any Buildroot
> package, but is used by several defconfigs to generate a bootable SD
> card image afterwards. Thus each of these defconfigs also sets
> BR2_PACKAGE_HOST_GENIMAGE=y.

> Sure bootgen differs in that (as far as I understand) the *typical*
> usage of xilinx-prebuilt requires host-bootgen in a post-build script.
> However in principle another tool could be used in its place.

> So as I said I'm not sure. Adding the 'depends on', possibly with a
> line of comment to clarify this, could still be seen as a convenience,
> but it would break existing defconfigs if the 'depends on' were removed
> later on to accommodate other use cases that do not involve bootgen.

> If there are no stronger opinions I'd vote to not add this.

I see your point, and I do not have a strong opinion on this.

I am fine with leaving it out.

Best regards,
Neal Frager
AMD
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot