[Buildroot] [PATCH 0/8] Various skarnet.org updates and new tipidee package

[Buildroot] [PATCH 0/8] Various skarnet.org updates and new tipidee package

[J. Neuschäfer via buildroot]

Signed-off-by: J. Neuschäfer <j.neuschaefer@gmx.net>
---
J. Neuschäfer (8):
      skalibs: bump to version 2.14.2.0
      s6: bump to version 2.13.0.1
      execline: bump to version 2.9.6.0
      s6-networking: bump to version 2.7.0.3
      s6-rc: bump to version 0.5.4.3
      mdevd: bump to version 0.1.6.4
      s6-dns: bump to version 2.3.7.2
      tipidee: new package

 package/Config.in                        |  1 +
 package/Config.in.host                   |  1 +
 package/execline/execline.hash           |  2 +-
 package/execline/execline.mk             |  2 +-
 package/mdevd/mdevd.hash                 |  2 +-
 package/mdevd/mdevd.mk                   |  2 +-
 package/s6-dns/s6-dns.hash               |  2 +-
 package/s6-dns/s6-dns.mk                 |  2 +-
 package/s6-networking/s6-networking.hash |  2 +-
 package/s6-networking/s6-networking.mk   |  2 +-
 package/s6-rc/s6-rc.hash                 |  2 +-
 package/s6-rc/s6-rc.mk                   |  2 +-
 package/s6/s6.hash                       |  2 +-
 package/s6/s6.mk                         |  2 +-
 package/skalibs/skalibs.hash             |  2 +-
 package/skalibs/skalibs.mk               |  2 +-
 package/tipidee/Config.in                | 37 ++++++++++++++++
 package/tipidee/Config.in.host           |  8 ++++
 package/tipidee/tipidee.hash             |  3 ++
 package/tipidee/tipidee.mk               | 72 ++++++++++++++++++++++++++++++++
 20 files changed, 136 insertions(+), 14 deletions(-)
---
base-commit: 3ebc7c69d56430c34eba4c869d1d4fe4d1e8de55
change-id: 20240704-tipidee-ee20ac10c7fa

Best regards,
--
J. Neuschäfer <j.neuschaefer@gmx.net>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 1/8] skalibs: bump to version 2.14.2.0

[J. Neuschäfer via buildroot]

Signed-off-by: J. Neuschäfer <j.neuschaefer@gmx.net>
---
 package/skalibs/skalibs.hash | 2 +-
 package/skalibs/skalibs.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/skalibs/skalibs.hash b/package/skalibs/skalibs.hash
index d871ee6503..1e6bd96671 100644
--- a/package/skalibs/skalibs.hash
+++ b/package/skalibs/skalibs.hash
@@ -1,3 +1,3 @@
 # Locally generated
-sha256  b6b79b816f4ba0b6801676b0ed4179b59c8c7809eeffe26db672e404636befc3  skalibs-2.14.1.1.tar.gz
+sha256  ddfec5730e5b2f19d0381ecf7f796b39a6e473236bda0ad8d3776a3fe7b07e43  skalibs-2.14.2.0.tar.gz
 sha256  fdc931295525dd0009cdf339189cbecd228d65cefe33402f037f9b046f07989e  COPYING
diff --git a/package/skalibs/skalibs.mk b/package/skalibs/skalibs.mk
index 67e3c694fc..45f3e15a7b 100644
--- a/package/skalibs/skalibs.mk
+++ b/package/skalibs/skalibs.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################

-SKALIBS_VERSION = 2.14.1.1
+SKALIBS_VERSION = 2.14.2.0
 SKALIBS_SITE = https://skarnet.org/software/skalibs
 SKALIBS_LICENSE = ISC
 SKALIBS_LICENSE_FILES = COPYING

--
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/8] s6: bump to version 2.13.0.1

[J. Neuschäfer via buildroot]

---
 package/s6/s6.hash | 2 +-
 package/s6/s6.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/s6/s6.hash b/package/s6/s6.hash
index fb5e74e403..6abeb8066a 100644
--- a/package/s6/s6.hash
+++ b/package/s6/s6.hash
@@ -1,3 +1,3 @@
 # Locally generated
-sha256  c95d51787602e0c8c8e4f92a710cbdaa4ee797ee886e71342727e2974f95c06b  s6-2.12.0.4.tar.gz
+sha256  7e46f8f55d80bb0e2025a64d5d649af4a4ac21e348020caaadde30ba5e5b4830  s6-2.13.0.0.tar.gz
 sha256  fdc931295525dd0009cdf339189cbecd228d65cefe33402f037f9b046f07989e  COPYING
diff --git a/package/s6/s6.mk b/package/s6/s6.mk
index fb4910e28b..7e02c26d03 100644
--- a/package/s6/s6.mk
+++ b/package/s6/s6.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################

-S6_VERSION = 2.12.0.4
+S6_VERSION = 2.13.0.0
 S6_SITE = https://skarnet.org/software/s6
 S6_LICENSE = ISC
 S6_LICENSE_FILES = COPYING

--
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 3/8] execline: bump to version 2.9.6.0

[J. Neuschäfer via buildroot]

---
 package/execline/execline.hash | 2 +-
 package/execline/execline.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/execline/execline.hash b/package/execline/execline.hash
index 3f9ff8a138..76412978b9 100644
--- a/package/execline/execline.hash
+++ b/package/execline/execline.hash
@@ -1,3 +1,3 @@
 # Locally generated
-sha256  df750035d0fb21c7265bffb7ed7e1b661de1e842944a2252bdcddc32d0d97217  execline-2.9.5.1.tar.gz
+sha256  ba2a27e97c5eb6bd7ca6a0987a8925e44465a5be996daa0d18f8feca37d7571a  execline-2.9.6.0.tar.gz
 sha256  fdc931295525dd0009cdf339189cbecd228d65cefe33402f037f9b046f07989e  COPYING
diff --git a/package/execline/execline.mk b/package/execline/execline.mk
index b3d2d98216..ee38d3ed3c 100644
--- a/package/execline/execline.mk
+++ b/package/execline/execline.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################

-EXECLINE_VERSION = 2.9.5.1
+EXECLINE_VERSION = 2.9.6.0
 EXECLINE_SITE = https://skarnet.org/software/execline
 EXECLINE_LICENSE = ISC
 EXECLINE_LICENSE_FILES = COPYING

--
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 4/8] s6-networking: bump to version 2.7.0.3

[J. Neuschäfer via buildroot]

---
 package/s6-networking/s6-networking.hash | 2 +-
 package/s6-networking/s6-networking.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/s6-networking/s6-networking.hash b/package/s6-networking/s6-networking.hash
index df65274b3d..4eff4d49f4 100644
--- a/package/s6-networking/s6-networking.hash
+++ b/package/s6-networking/s6-networking.hash
@@ -1,3 +1,3 @@
 # Locally generated
-sha256  c33c6f1b2be16f89a21af946cfd06242a12f98184c898b755ddb24338671ceb1  s6-networking-2.7.0.2.tar.gz
+sha256  db411c54371a17ed7d4543dd86cf9530ce25fcf624bef83ae2b579520e5e70bf  s6-networking-2.7.0.3.tar.gz
 sha256  fdc931295525dd0009cdf339189cbecd228d65cefe33402f037f9b046f07989e  COPYING
diff --git a/package/s6-networking/s6-networking.mk b/package/s6-networking/s6-networking.mk
index 239d8a679e..212fae7361 100644
--- a/package/s6-networking/s6-networking.mk
+++ b/package/s6-networking/s6-networking.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################

-S6_NETWORKING_VERSION = 2.7.0.2
+S6_NETWORKING_VERSION = 2.7.0.3
 S6_NETWORKING_SITE = https://skarnet.org/software/s6-networking
 S6_NETWORKING_LICENSE = ISC
 S6_NETWORKING_LICENSE_FILES = COPYING

--
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 5/8] s6-rc: bump to version 0.5.4.3

[J. Neuschäfer via buildroot]

---
 package/s6-rc/s6-rc.hash | 2 +-
 package/s6-rc/s6-rc.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/s6-rc/s6-rc.hash b/package/s6-rc/s6-rc.hash
index a09c08ba3c..2cc308ef95 100644
--- a/package/s6-rc/s6-rc.hash
+++ b/package/s6-rc/s6-rc.hash
@@ -1,3 +1,3 @@
 # Locally generated
-sha256  00bdfa596fa7161512e972ec9282a2abd8fd0e31f09177bad7a2bc3d8f283982  s6-rc-0.5.4.2.tar.gz
+sha256  e3272796a947904de37ab34ec10430e26107b8ef05210d81059c8b36203e6a9f  s6-rc-0.5.4.3.tar.gz
 sha256  f68451e55e6686dc187df1ca427c574d9ac0d6f6926e1bdb909ad8b657668fe5  COPYING
diff --git a/package/s6-rc/s6-rc.mk b/package/s6-rc/s6-rc.mk
index 61090c9a27..301c705910 100644
--- a/package/s6-rc/s6-rc.mk
+++ b/package/s6-rc/s6-rc.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################

-S6_RC_VERSION = 0.5.4.2
+S6_RC_VERSION = 0.5.4.3
 S6_RC_SITE = https://skarnet.org/software/s6-rc
 S6_RC_LICENSE = ISC
 S6_RC_LICENSE_FILES = COPYING

--
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 6/8] mdevd: bump to version 0.1.6.4

[J. Neuschäfer via buildroot]

---
 package/mdevd/mdevd.hash | 2 +-
 package/mdevd/mdevd.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/mdevd/mdevd.hash b/package/mdevd/mdevd.hash
index 9436ed8b01..daf2f48c04 100644
--- a/package/mdevd/mdevd.hash
+++ b/package/mdevd/mdevd.hash
@@ -1,3 +1,3 @@
 # Locally generated
-sha256  f6ecf0ef7cd48d04efc75acb2dad967d850bc8815bdb0098f1c9ef043394d430  mdevd-0.1.6.3.tar.gz
+sha256  7358ce530b6b9befb715e48190981e9b69a12cca858519e6d2e4b46eab7e2470  mdevd-0.1.6.4.tar.gz
 sha256  b2edd59a202a710440522f05dcbf418b0493540120efcb407876772ee42d2c7c  COPYING
diff --git a/package/mdevd/mdevd.mk b/package/mdevd/mdevd.mk
index c92659d961..a1d9e17cef 100644
--- a/package/mdevd/mdevd.mk
+++ b/package/mdevd/mdevd.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################

-MDEVD_VERSION = 0.1.6.3
+MDEVD_VERSION = 0.1.6.4
 MDEVD_SITE = https://skarnet.org/software/mdevd
 MDEVD_LICENSE = ISC
 MDEVD_LICENSE_FILES = COPYING

--
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 7/8] s6-dns: bump to version 2.3.7.2

[J. Neuschäfer via buildroot]

---
 package/s6-dns/s6-dns.hash | 2 +-
 package/s6-dns/s6-dns.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/s6-dns/s6-dns.hash b/package/s6-dns/s6-dns.hash
index 334ea1667c..2c9023ec28 100644
--- a/package/s6-dns/s6-dns.hash
+++ b/package/s6-dns/s6-dns.hash
@@ -1,3 +1,3 @@
 # Locally generated
-sha256  cf0258574ec7d62b654e0c2ad78af4c7d67ac4c9cb37f781480f597e54b30f6d  s6-dns-2.3.7.1.tar.gz
+sha256  6aee32bb68d01f5109f71e31a283213c668cd3c0e79fb9e469e6cabb58079f2b  s6-dns-2.3.7.2.tar.gz
 sha256  aafa4f6a12b5b24ab2ae8ead5174e1ec03aecb5eb0e82012d74fd47ccfc57607  COPYING
diff --git a/package/s6-dns/s6-dns.mk b/package/s6-dns/s6-dns.mk
index a848f2e6c0..8e175431a4 100644
--- a/package/s6-dns/s6-dns.mk
+++ b/package/s6-dns/s6-dns.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################

-S6_DNS_VERSION = 2.3.7.1
+S6_DNS_VERSION = 2.3.7.2
 S6_DNS_SITE = https://skarnet.org/software/s6-dns
 S6_DNS_LICENSE = ISC
 S6_DNS_LICENSE_FILES = COPYING

--
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 8/8] tipidee: new package

[J. Neuschäfer via buildroot]

Signed-off-by: J. Neuschäfer <j.neuschaefer@gmx.net>
---
 package/Config.in              |  1 +
 package/Config.in.host         |  1 +
 package/tipidee/Config.in      | 37 ++++++++++++++++++++++
 package/tipidee/Config.in.host |  8 +++++
 package/tipidee/tipidee.hash   |  3 ++
 package/tipidee/tipidee.mk     | 72 ++++++++++++++++++++++++++++++++++++++++++
 6 files changed, 122 insertions(+)

diff --git a/package/Config.in b/package/Config.in
index 48ef1a6fdc..8f199b832b 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -2595,6 +2595,7 @@ endif
 	source "package/tinc/Config.in"
 	source "package/tinyproxy/Config.in"
 	source "package/tinyssh/Config.in"
+	source "package/tipidee/Config.in"
 	source "package/tor/Config.in"
 	source "package/traceroute/Config.in"
 	source "package/transmission/Config.in"
diff --git a/package/Config.in.host b/package/Config.in.host
index 9cdca62633..d1e3c0a45b 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -112,6 +112,7 @@ menu "Host utilities"
 	source "package/systemd/Config.in.host"
 	source "package/tegrarcm/Config.in.host"
 	source "package/ti-cgt-pru/Config.in.host"
+	source "package/tipidee/Config.in.host"
 	source "package/uboot-tools/Config.in.host"
 	source "package/util-linux/Config.in.host"
 	source "package/utp_com/Config.in.host"
diff --git a/package/tipidee/Config.in b/package/tipidee/Config.in
new file mode 100644
index 0000000000..cc1c91a47c
--- /dev/null
+++ b/package/tipidee/Config.in
@@ -0,0 +1,37 @@
+config BR2_PACKAGE_TIPIDEE
+	bool "tipidee"
+	depends on BR2_USE_MMU # skalibs
+	select BR2_PACKAGE_SKALIBS
+	help
+	  tipidee is a web server. It supports HTTP 1.0 and 1.1. It aims
+	  to be compliant with RFC 9112: while it only implements a very
+	  limited subset of the optional functionality in HTTP 1.1, it
+	  implements all the mandatory parts. It is usable with both
+	  HTTP and HTTPS.
+
+	  It runs under a super-server, e.g. inetd, s6-tcpserver, or
+	  s6-tlsserver (for HTTPS). Traditionally, inetd-mode web
+	  servers aren't considered performant, but tipidee aims to eke
+	  out every single drop of performance that is attainable with
+	  its programming model.
+
+	  https://skarnet.org/software/tipidee/
+
+if BR2_PACKAGE_TIPIDEE
+
+config BR2_PACKAGE_TIPIDEE_CONFIGURATION
+	bool "install a configuration file to /etc/tipidee.conf.cdb"
+	select BR2_PACKAGE_HOST_TIPIDEE
+	help
+	  Build a tipidee configuration and install it to the target.
+
+config BR2_PACKAGE_TIPIDEE_CONFIGURATION_FILE
+	string "configuration source file"
+	default "$(CONFIG_DIR)/tipidee.conf"
+	depends on BR2_PACKAGE_TIPIDEE_CONFIGURATION
+	help
+	  The configuration file in source (text) format, documented at:
+
+	  https://skarnet.org/software/tipidee/tipidee.conf.html
+
+endif
diff --git a/package/tipidee/Config.in.host b/package/tipidee/Config.in.host
new file mode 100644
index 0000000000..93e548df1e
--- /dev/null
+++ b/package/tipidee/Config.in.host
@@ -0,0 +1,8 @@
+config BR2_HOST_PACKAGE_TIPIDEE
+	bool "host tipidee"
+	depends on BR2_USE_MMU # skalibs
+	select BR2_PACKAGE_SKALIBS
+	help
+	  This package builds the tipidee-config tool for the host.
+
+	  https://skarnet.org/software/tipidee/
diff --git a/package/tipidee/tipidee.hash b/package/tipidee/tipidee.hash
new file mode 100644
index 0000000000..ecc1ab34b4
--- /dev/null
+++ b/package/tipidee/tipidee.hash
@@ -0,0 +1,3 @@
+# Locally generated
+sha256  d9e91fc719879a43d54329b99b02c6649c54e428e77bc96a0573506b52bf1422  tipidee-0.0.5.0.tar.gz
+sha256  8feb7933c6e6506a7f20fbfc03fd37df3caff4becdf3b7a0ffad5016277e441e  COPYING
diff --git a/package/tipidee/tipidee.mk b/package/tipidee/tipidee.mk
new file mode 100644
index 0000000000..2fde75b87d
--- /dev/null
+++ b/package/tipidee/tipidee.mk
@@ -0,0 +1,72 @@
+################################################################################
+#
+# tipidee
+#
+################################################################################
+
+TIPIDEE_VERSION = 0.0.5.0
+TIPIDEE_SITE = https://skarnet.org/software/tipidee
+TIPIDEE_LICENSE = ISC
+TIPIDEE_LICENSE_FILES = COPYING
+TIPIDEE_INSTALL_STAGING = YES
+TIPIDEE_DEPENDENCIES = skalibs
+
+TIPIDEE_CONF_OPTS = \
+	--prefix=/ \
+	--with-sysdeps=$(STAGING_DIR)/lib/skalibs/sysdeps \
+	--with-include=$(STAGING_DIR)/include \
+	--with-dynlib=$(STAGING_DIR)/lib \
+	--with-lib=$(STAGING_DIR)/lib/skalibs \
+	$(if $(BR2_STATIC_LIBS),,--disable-allstatic) \
+	$(SHARED_STATIC_LIBS_OPTS)
+
+define TIPIDEE_CONFIGURE_CMDS
+	(cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure $(TIPIDEE_CONF_OPTS))
+endef
+
+define TIPIDEE_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
+endef
+
+define TIPIDEE_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
+	rm -f $(TARGET_DIR)/bin/tipidee-config
+	rm -f $(TARGET_DIR)/libexec/tipidee-config-preprocess
+endef
+
+ifeq ($(BR2_PACKAGE_TIPIDEE_CONFIGURATION),y)
+TIPIDEE_DEPENDENCIES += host-tipidee
+
+define TIPIDEE_INSTALL_CONFIG
+	$(HOST_DIR)/bin/tipidee-config -i $(BR2_PACKAGE_TIPIDEE_CONFIGURATION_FILE) \
+		-o $(TARGET_DIR)/etc/tipidee.conf.cdb
+endef
+TIPIDEE_POST_INSTALL_TARGET_HOOKS += TIPIDEE_INSTALL_CONFIG
+
+endif
+
+HOST_TIPIDEE_DEPENDENCIES = host-skalibs
+
+HOST_TIPIDEE_CONF_OPTS = \
+	--prefix=$(HOST_DIR) \
+	--with-sysdeps=$(HOST_DIR)/lib/skalibs/sysdeps \
+	--with-include=$(HOST_DIR)/include \
+	--with-dynlib=$(HOST_DIR)/lib \
+	--disable-static \
+	--enable-shared \
+	--disable-allstatic
+
+define HOST_TIPIDEE_CONFIGURE_CMDS
+	(cd $(@D); $(HOST_CONFIGURE_OPTS) ./configure $(HOST_TIPIDEE_CONF_OPTS))
+endef
+
+define HOST_TIPIDEE_BUILD_CMDS
+	$(HOST_MAKE_ENV) $(MAKE) -C $(@D)
+endef
+
+define HOST_TIPIDEE_INSTALL_CMDS
+	$(HOST_MAKE_ENV) $(MAKE) -C $(@D) install-dynlib install-bin install-libexec
+endef
+
+$(eval $(generic-package))
+$(eval $(host-generic-package))

--
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 0/8] Various skarnet.org updates and new tipidee package

[J. Neuschäfer via buildroot]

On Thu, Jul 04, 2024 at 09:40:26PM +0200, J. Neuschäfer wrote:
> Signed-off-by: J. Neuschäfer <j.neuschaefer@gmx.net>
> ---
> J. Neuschäfer (8):
>       skalibs: bump to version 2.14.2.0
>       s6: bump to version 2.13.0.1
>       execline: bump to version 2.9.6.0
>       s6-networking: bump to version 2.7.0.3
>       s6-rc: bump to version 0.5.4.3
>       mdevd: bump to version 0.1.6.4
>       s6-dns: bump to version 2.3.7.2
>       tipidee: new package

Ah sorry, I forgot to add the Signed-off-by line in few of these. I'll
fix it in the next version.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 0/8] Various skarnet.org updates and new tipidee package

[Thomas Petazzoni via buildroot]

Hello,

On Thu, 04 Jul 2024 21:40:26 +0200
J. Neuschäfer via buildroot <buildroot@buildroot.org> wrote:

> Signed-off-by: J. Neuschäfer <j.neuschaefer@gmx.net>
> ---
> J. Neuschäfer (8):
>       skalibs: bump to version 2.14.2.0
>       s6: bump to version 2.13.0.1
>       execline: bump to version 2.9.6.0
>       s6-networking: bump to version 2.7.0.3
>       s6-rc: bump to version 0.5.4.3
>       mdevd: bump to version 0.1.6.4
>       s6-dns: bump to version 2.3.7.2
>       tipidee: new package

Thanks for your patch series. Unfortunately none of the patches, except
1/8 and 8/8 have your Signed-off-by line. Could you resend with your
Signed-off-by line added?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 8/8] tipidee: new package

[Thomas Petazzoni via buildroot]

Hello,

On Thu, 04 Jul 2024 21:40:34 +0200
J. Neuschäfer via buildroot <buildroot@buildroot.org> wrote:

> Signed-off-by: J. Neuschäfer <j.neuschaefer@gmx.net>

Thanks for this contribution!

> +if BR2_PACKAGE_TIPIDEE
> +
> +config BR2_PACKAGE_TIPIDEE_CONFIGURATION
> +	bool "install a configuration file to /etc/tipidee.conf.cdb"
> +	select BR2_PACKAGE_HOST_TIPIDEE
> +	help
> +	  Build a tipidee configuration and install it to the target.
> +
> +config BR2_PACKAGE_TIPIDEE_CONFIGURATION_FILE
> +	string "configuration source file"
> +	default "$(CONFIG_DIR)/tipidee.conf"
> +	depends on BR2_PACKAGE_TIPIDEE_CONFIGURATION
> +	help
> +	  The configuration file in source (text) format, documented at:
> +
> +	  https://skarnet.org/software/tipidee/tipidee.conf.html

I'm not sure those configuration options are really needed. We usually
don't make the configuration file configurable, and leave that up to a
rootfs-overlay. I understand that the configuration is apparently
"compiled", but I would perhaps leave that up to be overridden by a
post-build script? Or perhaps we should do this configuration file
"compilation" as a TARGET_FINALIZE_HOOKS so that it happens after
rootfs-overlay are copied, allowing the user to override the
configuration file, while still seeing it "compiled"?

> diff --git a/package/tipidee/Config.in.host b/package/tipidee/Config.in.host
> new file mode 100644
> index 0000000000..93e548df1e
> --- /dev/null
> +++ b/package/tipidee/Config.in.host
> @@ -0,0 +1,8 @@
> +config BR2_HOST_PACKAGE_TIPIDEE
> +	bool "host tipidee"
> +	depends on BR2_USE_MMU # skalibs
> +	select BR2_PACKAGE_SKALIBS
> +	help
> +	  This package builds the tipidee-config tool for the host.
> +
> +	  https://skarnet.org/software/tipidee/

I'm not sure we really need a visible config option for this,
host-tipidee is going to be a dependency of tipidee anyway.

> diff --git a/package/tipidee/tipidee.mk b/package/tipidee/tipidee.mk
> new file mode 100644
> index 0000000000..2fde75b87d
> --- /dev/null
> +++ b/package/tipidee/tipidee.mk
> @@ -0,0 +1,72 @@
> +################################################################################
> +#
> +# tipidee
> +#
> +################################################################################
> +
> +TIPIDEE_VERSION = 0.0.5.0
> +TIPIDEE_SITE = https://skarnet.org/software/tipidee
> +TIPIDEE_LICENSE = ISC
> +TIPIDEE_LICENSE_FILES = COPYING
> +TIPIDEE_INSTALL_STAGING = YES
> +TIPIDEE_DEPENDENCIES = skalibs
> +
> +TIPIDEE_CONF_OPTS = \
> +	--prefix=/ \

This looks odd, why not --prefix=/usr ?

The rest really looks super reasonable to me, good work!

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 0/8] Various skarnet.org updates and new tipidee package

[J. Neuschäfer via buildroot]

On Mon, Jul 08, 2024 at 11:13:44PM +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 04 Jul 2024 21:40:26 +0200
> J. Neuschäfer via buildroot <buildroot@buildroot.org> wrote:
>
> > Signed-off-by: J. Neuschäfer <j.neuschaefer@gmx.net>
> > ---
> > J. Neuschäfer (8):
> >       skalibs: bump to version 2.14.2.0
> >       s6: bump to version 2.13.0.1
> >       execline: bump to version 2.9.6.0
> >       s6-networking: bump to version 2.7.0.3
> >       s6-rc: bump to version 0.5.4.3
> >       mdevd: bump to version 0.1.6.4
> >       s6-dns: bump to version 2.3.7.2
> >       tipidee: new package
>
> Thanks for your patch series. Unfortunately none of the patches, except
> 1/8 and 8/8 have your Signed-off-by line. Could you resend with your
> Signed-off-by line added?

Yep, I forgot those. Will do.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 8/8] tipidee: new package

[J. Neuschäfer via buildroot]

On Mon, Jul 08, 2024 at 11:24:40PM +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 04 Jul 2024 21:40:34 +0200
> J. Neuschäfer via buildroot <buildroot@buildroot.org> wrote:
>
> > Signed-off-by: J. Neuschäfer <j.neuschaefer@gmx.net>
>
> Thanks for this contribution!
>
> > +if BR2_PACKAGE_TIPIDEE
> > +
> > +config BR2_PACKAGE_TIPIDEE_CONFIGURATION
> > +	bool "install a configuration file to /etc/tipidee.conf.cdb"
> > +	select BR2_PACKAGE_HOST_TIPIDEE
> > +	help
> > +	  Build a tipidee configuration and install it to the target.
> > +
> > +config BR2_PACKAGE_TIPIDEE_CONFIGURATION_FILE
> > +	string "configuration source file"
> > +	default "$(CONFIG_DIR)/tipidee.conf"
> > +	depends on BR2_PACKAGE_TIPIDEE_CONFIGURATION
> > +	help
> > +	  The configuration file in source (text) format, documented at:
> > +
> > +	  https://skarnet.org/software/tipidee/tipidee.conf.html
>
> I'm not sure those configuration options are really needed. We usually
> don't make the configuration file configurable, and leave that up to a
> rootfs-overlay. I understand that the configuration is apparently
> "compiled", but I would perhaps leave that up to be overridden by a
> post-build script? Or perhaps we should do this configuration file
> "compilation" as a TARGET_FINALIZE_HOOKS so that it happens after
> rootfs-overlay are copied, allowing the user to override the
> configuration file, while still seeing it "compiled"?

I'm not sure about the different options for hooks, etc., in buildroot,
but my reasoning was that I find it easier to set an option than to
write a custom script.

> > diff --git a/package/tipidee/Config.in.host b/package/tipidee/Config.in.host
> > new file mode 100644
> > index 0000000000..93e548df1e
> > --- /dev/null
> > +++ b/package/tipidee/Config.in.host
> > @@ -0,0 +1,8 @@
> > +config BR2_HOST_PACKAGE_TIPIDEE
> > +	bool "host tipidee"
> > +	depends on BR2_USE_MMU # skalibs

I just noticed this dependency only makes sense for the target package,
I'll remove it for version 3.

> > +	select BR2_PACKAGE_SKALIBS
> > +	help
> > +	  This package builds the tipidee-config tool for the host.
> > +
> > +	  https://skarnet.org/software/tipidee/
>
> I'm not sure we really need a visible config option for this,
> host-tipidee is going to be a dependency of tipidee anyway.

I'll remove the name so it's hidden from manual selection.

However, this only makes sense if the current approach
(BR2_PACKAGE_TIPIDEE_CONFIGURATION) is kept or if
BR2_PACKAGE_TIPIDEE unconditionally selects BR2_HOST_PACKAGE_TIPIDEE.

>
> > diff --git a/package/tipidee/tipidee.mk b/package/tipidee/tipidee.mk
> > new file mode 100644
> > index 0000000000..2fde75b87d
> > --- /dev/null
> > +++ b/package/tipidee/tipidee.mk
> > @@ -0,0 +1,72 @@
> > +################################################################################
> > +#
> > +# tipidee
> > +#
> > +################################################################################
> > +
> > +TIPIDEE_VERSION = 0.0.5.0
> > +TIPIDEE_SITE = https://skarnet.org/software/tipidee
> > +TIPIDEE_LICENSE = ISC
> > +TIPIDEE_LICENSE_FILES = COPYING
> > +TIPIDEE_INSTALL_STAGING = YES
> > +TIPIDEE_DEPENDENCIES = skalibs
> > +
> > +TIPIDEE_CONF_OPTS = \
> > +	--prefix=/ \
>
> This looks odd, why not --prefix=/usr ?

I copied this from other skarnet.org packages, but --prefix=/usr would
work too.

> The rest really looks super reasonable to me, good work!

Thanks for your review!
jn
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot