[Buildroot] [PATCH 0/2] board/ti/am6{2, 4}x-sk: update custom hashes

[Buildroot] [PATCH 0/2] board/ti/am6{2, 4}x-sk: update custom hashes

[Gero Schwäricke via buildroot]

The following two commits bumped the u-boot version, but missed updating
the custom hashes:

  cc2910a7db configs/ti_am62x_sk_defconfig: update U-Boot to v2024.04
  7efd75867c configs/ti_am64x_sk_defconfig: update U-Boot to v2024.04

Generated with

  ./utils/add-custom-hashes

Build succeeded since u-boot latest is currenly also v2024.04, but this
will break in the future.

--
Gero Schwäricke (2):
  board/ti/am62x-sk: update custom hashes
  board/ti/am64x-sk: update custom hashes

 .../patches/arm-trusted-firmware/arm-trusted-firmware.hash    | 2 +-
 .../ti/am62x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash  | 4 ++--
 board/ti/am62x-sk/patches/uboot/uboot.hash                    | 4 ++--
 .../patches/arm-trusted-firmware/arm-trusted-firmware.hash    | 2 +-
 .../ti/am64x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash  | 3 ++-
 board/ti/am64x-sk/patches/uboot/uboot.hash                    | 4 ++--
 6 files changed, 10 insertions(+), 9 deletions(-)

-- 
2.45.2


-- 



–––


grandcentrix GmbH | A Vodafone Company · Holzmarkt 1 · 50676 
*Cologne* | Phoenixseestrasse 18 · 44263 *Dortmund* · Germany
| in 
<https://www.linkedin.com/company/grandcentrix> | phone: +49-221-677-860-0 
| email: hello@grandcentrix.net <mailto:hello@grandcentrix.net>


grandcentrix cares about privacy 
<https://grandcentrix.net/de/pages/privacymail/>

Amtsgericht Köln | HRB  
70119 | Geschäftsführer: M. Krömer,  R. Hänel | USt.-IdNr.: DE266333969

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 1/2] board/ti/am62x-sk: update custom hashes

[Gero Schwäricke via buildroot]

Signed-off-by: Gero Schwäricke <gero.schwaericke@grandcentrix.net>
---
 .../patches/arm-trusted-firmware/arm-trusted-firmware.hash    | 2 +-
 .../ti/am62x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash  | 4 ++--
 board/ti/am62x-sk/patches/uboot/uboot.hash                    | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/board/ti/am62x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash b/board/ti/am62x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
index 8f60864fbf..7494e04ead 100644
--- a/board/ti/am62x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
+++ b/board/ti/am62x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
@@ -1,2 +1,2 @@
-# Locally computed:
+# Locally calculated
 sha256  ba215404fe9db26e5f2cef3fdce17b7c8ed344a2a1d592dd01a5f1c5e72cfdbd  arm-trusted-firmware-lts-v2.10.4.tar.gz
diff --git a/board/ti/am62x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash b/board/ti/am62x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
index 0e171c56f5..97a2b4eaf9 100644
--- a/board/ti/am62x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
+++ b/board/ti/am62x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
@@ -1,2 +1,2 @@
-# Locally computed:
-sha256  b99611f1ed237bf3541bdc8434b68c96a6e05967061f992443cb30aabebef5b3  u-boot-2024.01.tar.bz2
+# Locally calculated
+sha256  18a853fe39fad7ad03a90cc2d4275aeaed6da69735defac3492b80508843dd4a  u-boot-2024.04.tar.bz2
diff --git a/board/ti/am62x-sk/patches/uboot/uboot.hash b/board/ti/am62x-sk/patches/uboot/uboot.hash
index 0e171c56f5..97a2b4eaf9 100644
--- a/board/ti/am62x-sk/patches/uboot/uboot.hash
+++ b/board/ti/am62x-sk/patches/uboot/uboot.hash
@@ -1,2 +1,2 @@
-# Locally computed:
-sha256  b99611f1ed237bf3541bdc8434b68c96a6e05967061f992443cb30aabebef5b3  u-boot-2024.01.tar.bz2
+# Locally calculated
+sha256  18a853fe39fad7ad03a90cc2d4275aeaed6da69735defac3492b80508843dd4a  u-boot-2024.04.tar.bz2
-- 
2.45.2


-- 



–––


grandcentrix GmbH | A Vodafone Company · Holzmarkt 1 · 50676 
*Cologne* | Phoenixseestrasse 18 · 44263 *Dortmund* · Germany
| in 
<https://www.linkedin.com/company/grandcentrix> | phone: +49-221-677-860-0 
| email: hello@grandcentrix.net <mailto:hello@grandcentrix.net>


grandcentrix cares about privacy 
<https://grandcentrix.net/de/pages/privacymail/>

Amtsgericht Köln | HRB  
70119 | Geschäftsführer: M. Krömer,  R. Hänel | USt.-IdNr.: DE266333969

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] board/ti/am62x-sk: update custom hashes

[Thomas Petazzoni via buildroot]

On Thu, 20 Jun 2024 13:08:20 +0200
Gero Schwäricke via buildroot <buildroot@buildroot.org> wrote:

> Signed-off-by: Gero Schwäricke <gero.schwaericke@grandcentrix.net>
> ---
>  .../patches/arm-trusted-firmware/arm-trusted-firmware.hash    | 2 +-
>  .../ti/am62x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash  | 4 ++--
>  board/ti/am62x-sk/patches/uboot/uboot.hash                    | 4 ++--
>  3 files changed, 5 insertions(+), 5 deletions(-)

Thanks for your two patches. They are both correct indeed, but the
commit log should have explained what happened. So here is what I added
(so that you can see the sort of explanation we expect to see in commit
logs):

    board/ti/am62x-sk: update custom hashes
    
    Commit
    cc2910a7dbd331ae0ad6a8f06ce7cd0559a1ebe1 ("configs/ti_am62x_sk_defconfig:
    update U-Boot to v2024.04") updated U-Boot and the ti-k3-r5-loader to
    2024.04, but did not update the hash files in board/ti/am62x-sk/. It
    ended up working for now, because the official versions of boot/uboot
    and boot/ti-k3-r5-loader/ also use 2024.04 and therefore have this
    hash, but it would have started failing as soon as boot/uboot and/or
    boot/ti-k3-r5-loader official version were updated.
    
    Signed-off-by: Gero Schwäricke <gero.schwaericke@grandcentrix.net>
    Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Both patches applied with those improved commit messages. Thanks again!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] board/ti/am62x-sk: update custom hashes

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > On Thu, 20 Jun 2024 13:08:20 +0200
 > Gero Schwäricke via buildroot <buildroot@buildroot.org> wrote:

 >> Signed-off-by: Gero Schwäricke <gero.schwaericke@grandcentrix.net>
 >> ---
 >> .../patches/arm-trusted-firmware/arm-trusted-firmware.hash    | 2 +-
 >> .../ti/am62x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash  | 4 ++--
 >> board/ti/am62x-sk/patches/uboot/uboot.hash                    | 4 ++--
 >> 3 files changed, 5 insertions(+), 5 deletions(-)

 > Thanks for your two patches. They are both correct indeed, but the
 > commit log should have explained what happened. So here is what I added
 > (so that you can see the sort of explanation we expect to see in commit
 > logs):

 >     board/ti/am62x-sk: update custom hashes
    
 >     Commit
 >     cc2910a7dbd331ae0ad6a8f06ce7cd0559a1ebe1 ("configs/ti_am62x_sk_defconfig:
 >     update U-Boot to v2024.04") updated U-Boot and the ti-k3-r5-loader to
 >     2024.04, but did not update the hash files in board/ti/am62x-sk/. It
 >     ended up working for now, because the official versions of boot/uboot
 >     and boot/ti-k3-r5-loader/ also use 2024.04 and therefore have this
 >     hash, but it would have started failing as soon as boot/uboot and/or
 >     boot/ti-k3-r5-loader official version were updated.
    
 >     Signed-off-by: Gero Schwäricke <gero.schwaericke@grandcentrix.net>
 >     Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

 > Both patches applied with those improved commit messages. Thanks again!

Committed both to 2024.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] board/ti/am64x-sk: update custom hashes

[Gero Schwäricke via buildroot]

Signed-off-by: Gero Schwäricke <gero.schwaericke@grandcentrix.net>
---
 .../patches/arm-trusted-firmware/arm-trusted-firmware.hash    | 2 +-
 .../ti/am64x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash  | 3 ++-
 board/ti/am64x-sk/patches/uboot/uboot.hash                    | 4 ++--
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/board/ti/am64x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash b/board/ti/am64x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
index 8f60864fbf..7494e04ead 100644
--- a/board/ti/am64x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
+++ b/board/ti/am64x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
@@ -1,2 +1,2 @@
-# Locally computed:
+# Locally calculated
 sha256  ba215404fe9db26e5f2cef3fdce17b7c8ed344a2a1d592dd01a5f1c5e72cfdbd  arm-trusted-firmware-lts-v2.10.4.tar.gz
diff --git a/board/ti/am64x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash b/board/ti/am64x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
index dbb4428738..97a2b4eaf9 100644
--- a/board/ti/am64x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
+++ b/board/ti/am64x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
@@ -1 +1,2 @@
-sha256  b99611f1ed237bf3541bdc8434b68c96a6e05967061f992443cb30aabebef5b3  u-boot-2024.01.tar.bz2
+# Locally calculated
+sha256  18a853fe39fad7ad03a90cc2d4275aeaed6da69735defac3492b80508843dd4a  u-boot-2024.04.tar.bz2
diff --git a/board/ti/am64x-sk/patches/uboot/uboot.hash b/board/ti/am64x-sk/patches/uboot/uboot.hash
index 0e171c56f5..97a2b4eaf9 100644
--- a/board/ti/am64x-sk/patches/uboot/uboot.hash
+++ b/board/ti/am64x-sk/patches/uboot/uboot.hash
@@ -1,2 +1,2 @@
-# Locally computed:
-sha256  b99611f1ed237bf3541bdc8434b68c96a6e05967061f992443cb30aabebef5b3  u-boot-2024.01.tar.bz2
+# Locally calculated
+sha256  18a853fe39fad7ad03a90cc2d4275aeaed6da69735defac3492b80508843dd4a  u-boot-2024.04.tar.bz2
-- 
2.45.2


-- 



–––


grandcentrix GmbH | A Vodafone Company · Holzmarkt 1 · 50676 
*Cologne* | Phoenixseestrasse 18 · 44263 *Dortmund* · Germany
| in 
<https://www.linkedin.com/company/grandcentrix> | phone: +49-221-677-860-0 
| email: hello@grandcentrix.net <mailto:hello@grandcentrix.net>


grandcentrix cares about privacy 
<https://grandcentrix.net/de/pages/privacymail/>

Amtsgericht Köln | HRB  
70119 | Geschäftsführer: M. Krömer,  R. Hänel | USt.-IdNr.: DE266333969

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 0/2] board/ti/am6{2, 4}x-sk: update custom hashes

[Bryan Brattlof via buildroot]

On June 20, 2024 thus sayeth Gero Schwäricke via buildroot:
> The following two commits bumped the u-boot version, but missed updating
> the custom hashes:
> 
>   cc2910a7db configs/ti_am62x_sk_defconfig: update U-Boot to v2024.04
>   7efd75867c configs/ti_am64x_sk_defconfig: update U-Boot to v2024.04
> 
> Generated with
> 
>   ./utils/add-custom-hashes
> 
> Build succeeded since u-boot latest is currenly also v2024.04, but this
> will break in the future.
> 
> --
> Gero Schwäricke (2):
>   board/ti/am62x-sk: update custom hashes
>   board/ti/am64x-sk: update custom hashes

Nice catch! Thank you

Reviewed-by: Bryan Brattlof <bb@ti.com>

~Bryan
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot