* [Buildroot] [PATCH 1/1] package/ubus: remove obsolete systemd option
@ 2024-06-16 14:19 Jan Havran
2024-07-11 19:24 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 4+ messages in thread
From: Jan Havran @ 2024-06-16 14:19 UTC (permalink / raw)
To: buildroot; +Cc: Sergio Prado
ENABLE_SYSTEMD option has been removed from ubus by commit:
96ab0b3032f5 ubusd: remove systemd socket activation support
Signed-off-by: Jan Havran <havran.jan@email.cz>
---
package/ubus/ubus.mk | 7 -------
1 file changed, 7 deletions(-)
diff --git a/package/ubus/ubus.mk b/package/ubus/ubus.mk
index 1f9891411a..cc2ed81786 100644
--- a/package/ubus/ubus.mk
+++ b/package/ubus/ubus.mk
@@ -25,13 +25,6 @@ else
UBUS_CONF_OPTS += -DBUILD_LUA=OFF
endif
-ifeq ($(BR2_PACKAGE_SYSTEMD),y)
-UBUS_DEPENDENCIES += systemd
-UBUS_CONF_OPTS += -DENABLE_SYSTEMD=ON
-else
-UBUS_CONF_OPTS += -DENABLE_SYSTEMD=OFF
-endif
-
ifeq ($(BR2_PACKAGE_UBUS_EXAMPLES),y)
UBUS_CONF_OPTS += -DBUILD_EXAMPLES=ON
else
--
2.45.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/ubus: remove obsolete systemd option
2024-06-16 14:19 [Buildroot] [PATCH 1/1] package/ubus: remove obsolete systemd option Jan Havran
@ 2024-07-11 19:24 ` Thomas Petazzoni via buildroot
2024-07-15 21:13 ` Jan Havran
2024-07-28 10:05 ` Peter Korsgaard
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-07-11 19:24 UTC (permalink / raw)
To: Jan Havran; +Cc: Sergio Prado, buildroot
On Sun, 16 Jun 2024 16:19:14 +0200
Jan Havran <havran.jan@email.cz> wrote:
> ENABLE_SYSTEMD option has been removed from ubus by commit:
> 96ab0b3032f5 ubusd: remove systemd socket activation support
>
> Signed-off-by: Jan Havran <havran.jan@email.cz>
> ---
> package/ubus/ubus.mk | 7 -------
> 1 file changed, 7 deletions(-)
I've done a bit more research to see from a Buildroot perspective since
when this obsolete systemd option has been dropped, and I added the
conclusion of this investigation in an improved commit message:
package/ubus: remove obsolete systemd option
ENABLE_SYSTEMD option has been removed from ubus by upstream commit:
96ab0b3032f5 ubusd: remove systemd socket activation support
From a Buildroot perspective, this means that this systemd socket
activation feature no longer exists since Buildroot commit
130be80d34905d3e79ff6b8f8fb31b3c3765eb96 ("ubus: bump version"), as we
bumped ubus from 259450f414d8c9ee41896e8e6d6bc57ec00e2b63 to
34c6e818e431cc53478a0f7c7c1eca07d194d692 in this commit, and the
96ab0b3032f5 ("ubusd: remove systemd socket activation support")
commit is in this range. It was therefore dropped upstream in 2016,
and in Buildroot in 2017.
Applied with this improved commit message. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/ubus: remove obsolete systemd option
2024-07-11 19:24 ` Thomas Petazzoni via buildroot
@ 2024-07-15 21:13 ` Jan Havran
2024-07-28 10:05 ` Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Jan Havran @ 2024-07-15 21:13 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Sergio Prado, buildroot
V Thu, Jul 11, 2024 at 09:24:50PM +0200, Thomas Petazzoni napsal(a):
> On Sun, 16 Jun 2024 16:19:14 +0200
> Jan Havran <havran.jan@email.cz> wrote:
>
> > ENABLE_SYSTEMD option has been removed from ubus by commit:
> > 96ab0b3032f5 ubusd: remove systemd socket activation support
> >
> > Signed-off-by: Jan Havran <havran.jan@email.cz>
> > ---
> > package/ubus/ubus.mk | 7 -------
> > 1 file changed, 7 deletions(-)
>
> I've done a bit more research to see from a Buildroot perspective since
> when this obsolete systemd option has been dropped, and I added the
> conclusion of this investigation in an improved commit message:
>
> package/ubus: remove obsolete systemd option
>
> ENABLE_SYSTEMD option has been removed from ubus by upstream commit:
>
> 96ab0b3032f5 ubusd: remove systemd socket activation support
>
> From a Buildroot perspective, this means that this systemd socket
> activation feature no longer exists since Buildroot commit
> 130be80d34905d3e79ff6b8f8fb31b3c3765eb96 ("ubus: bump version"), as we
> bumped ubus from 259450f414d8c9ee41896e8e6d6bc57ec00e2b63 to
> 34c6e818e431cc53478a0f7c7c1eca07d194d692 in this commit, and the
> 96ab0b3032f5 ("ubusd: remove systemd socket activation support")
> commit is in this range. It was therefore dropped upstream in 2016,
> and in Buildroot in 2017.
>
> Applied with this improved commit message. Thanks!
>
> Thomas
Oh yes, this message is much better.
Thank you, Thomas!
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/ubus: remove obsolete systemd option
2024-07-11 19:24 ` Thomas Petazzoni via buildroot
2024-07-15 21:13 ` Jan Havran
@ 2024-07-28 10:05 ` Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2024-07-28 10:05 UTC (permalink / raw)
To: Thomas Petazzoni via buildroot; +Cc: Sergio Prado, Jan Havran, Thomas Petazzoni
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> On Sun, 16 Jun 2024 16:19:14 +0200
> Jan Havran <havran.jan@email.cz> wrote:
>> ENABLE_SYSTEMD option has been removed from ubus by commit:
>> 96ab0b3032f5 ubusd: remove systemd socket activation support
>>
>> Signed-off-by: Jan Havran <havran.jan@email.cz>
>> ---
>> package/ubus/ubus.mk | 7 -------
>> 1 file changed, 7 deletions(-)
> I've done a bit more research to see from a Buildroot perspective since
> when this obsolete systemd option has been dropped, and I added the
> conclusion of this investigation in an improved commit message:
> package/ubus: remove obsolete systemd option
> ENABLE_SYSTEMD option has been removed from ubus by upstream commit:
> 96ab0b3032f5 ubusd: remove systemd socket activation support
> From a Buildroot perspective, this means that this systemd socket
> activation feature no longer exists since Buildroot commit
> 130be80d34905d3e79ff6b8f8fb31b3c3765eb96 ("ubus: bump version"), as we
> bumped ubus from 259450f414d8c9ee41896e8e6d6bc57ec00e2b63 to
> 34c6e818e431cc53478a0f7c7c1eca07d194d692 in this commit, and the
> 96ab0b3032f5 ("ubusd: remove systemd socket activation support")
> commit is in this range. It was therefore dropped upstream in 2016,
> and in Buildroot in 2017.
> Applied with this improved commit message. Thanks!
Committed to 2024.02.x and 2024.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-28 10:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-16 14:19 [Buildroot] [PATCH 1/1] package/ubus: remove obsolete systemd option Jan Havran
2024-07-11 19:24 ` Thomas Petazzoni via buildroot
2024-07-15 21:13 ` Jan Havran
2024-07-28 10:05 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox