From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2 v2] support/download: introduce curl backend for FTP transfers
Date: Fri, 12 Jul 2024 14:57:25 +0200 [thread overview]
Message-ID: <20240712145725.68e9c3cc@windsurf> (raw)
In-Reply-To: <149238f4ea82fd91fc1a880025ab8b38954da518.1717352584.git.yann.morin.1998@free.fr>
Hello Yann,
On Sun, 2 Jun 2024 20:23:07 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> diff --git a/Config.in b/Config.in
> index b5a94325c4..e0257ba3e8 100644
> --- a/Config.in
> +++ b/Config.in
> @@ -103,9 +103,13 @@ menu "Build options"
>
> menu "Commands"
>
> +config BR2_CURL
> + string "Curl command"
> + default "curl -q --ftp-pasv --retry 3"
> +
> config BR2_WGET
> string "Wget command"
> - default "wget --passive-ftp -nd -t 3"
> + default "wget -nd -t 3"
This change was not really related to introducing curl support... and
in fact Peter already applied 1a61c1d9b1919120883b689c3767925bd91d3028
doing such a change.
> diff --git a/utils/genrandconfig b/utils/genrandconfig
> index b838dda34d..b7d277105f 100755
> --- a/utils/genrandconfig
> +++ b/utils/genrandconfig
> @@ -688,7 +688,7 @@ async def gen_config(args):
> configlines += minimalf.readlines()
>
> # Allow hosts with old certificates to download over https
> - configlines.append("BR2_WGET=\"wget --passive-ftp -nd -t 3 --no-check-certificate\"\n")
> + configlines.append("BR2_WGET=\"wget -nd -t 3 --no-check-certificate\"\n")
>
> # Per-package folder
> if randint(0, 15) == 0:
Also, this was not directly related to the introduction of curl
support, so I split this out into a separate commit.
Applied, thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-12 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-02 18:23 [Buildroot] [PATCH 0/2 v2] support/download: fix running on hosts with wget2 (branch yem/dl-curl) Yann E. MORIN
2024-06-02 18:23 ` [Buildroot] [PATCH 1/2 v2] support/download: introduce curl backend for FTP transfers Yann E. MORIN
2024-07-12 12:57 ` Thomas Petazzoni via buildroot [this message]
2024-06-02 18:23 ` [Buildroot] [PATCH 2/2 v2] utils/genrandconfig: do not check certificates with curl Yann E. MORIN
2024-07-12 12:57 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240712145725.68e9c3cc@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox