Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2 v2] utils/genrandconfig: do not check certificates with curl
Date: Fri, 12 Jul 2024 14:57:28 +0200	[thread overview]
Message-ID: <20240712145728.25a4299e@windsurf> (raw)
In-Reply-To: <5278eb53136fe1fd8cc2591748a1cc968ece79ad.1717352584.git.yann.morin.1998@free.fr>

On Sun,  2 Jun 2024 20:23:08 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> genrandconfig is used in autobuilders, and some autobuilders are running
> on old distributions that are lacking the most recent CAs, causing build
> failures because package sources can't be retrieved.
> 
> Do for the curl backend what we already did a while back for the wget
> backend, with commit 0866a280e40a (utils/genrandconfig: use
> --no-check-certificate in wget by default); in curl, the equivalent
> would be --insecure, and applies to the ftps transport.
> 
> The integrity of the downloads are validated against our bundled hashes
> so there is no risk of corruption of the downloaded files. The only
> issue would be that an MITM could inspect the transaction, the same way
> as for the wget --no-check-certificate in 0866a280e40a, but this is not
> considered a high-level issue (we're anyway talking FTPS here, that's a
> legacy protocol that has other issues).
> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> 
> ---
> Note: this is totally untested, because FTPS is not widespread and no
> known package was available via FTPS. This patch can probably be dropped.
> ---
>  utils/genrandconfig | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-07-12 12:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-02 18:23 [Buildroot] [PATCH 0/2 v2] support/download: fix running on hosts with wget2 (branch yem/dl-curl) Yann E. MORIN
2024-06-02 18:23 ` [Buildroot] [PATCH 1/2 v2] support/download: introduce curl backend for FTP transfers Yann E. MORIN
2024-07-12 12:57   ` Thomas Petazzoni via buildroot
2024-06-02 18:23 ` [Buildroot] [PATCH 2/2 v2] utils/genrandconfig: do not check certificates with curl Yann E. MORIN
2024-07-12 12:57   ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240712145728.25a4299e@windsurf \
    --to=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox