[Buildroot] [PATCH] package/bcc: add missing dependencies to comment

[Buildroot] [PATCH] package/bcc: add missing dependencies to comment

[Yann E. MORIN]

Since its inception in 146498d13c48 (package/bcc: new package), not all
the dependencies of bcc are mirrored in the comment to be displayed when
those dependencies are not met.

Fix that by adding the missing pieces:
  - wchar,
  - threads
  - dynamic libs,

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Jugurtha BELKALEM <jugurtha.belkalem@smile.fr>
Cc: Romain Naour <romain.naour@gmail.com>
Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/bcc/Config.in | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/package/bcc/Config.in b/package/bcc/Config.in
index b91e0e5ee3..bf46f07d93 100644
--- a/package/bcc/Config.in
+++ b/package/bcc/Config.in
@@ -38,8 +38,13 @@ config BR2_PACKAGE_BCC
 	  https://github.com/iovisor/bcc
 	  http://www.ebpf.io
 
-comment "bcc needs a glibc toolchain, C++, gcc >= 7, host gcc >= 7"
+comment "bcc needs a glibc toolchain, C++, wchar, threads, dynamic libs, gcc >= 7, host gcc >= 7"
 	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
 	depends on BR2_USE_MMU
-	depends on !BR2_TOOLCHAIN_USES_GLIBC || !BR2_INSTALL_LIBSTDCPP \
-		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || !BR2_HOST_GCC_AT_LEAST_7
+	depends on !BR2_TOOLCHAIN_USES_GLIBC \
+		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_7 \
+		|| !BR2_INSTALL_LIBSTDCPP \
+		|| !BR2_HOST_GCC_AT_LEAST_7 \
+		|| !BR2_USE_WCHAR \
+		|| !BR2_TOOLCHAIN_HAS_THREADS \
+		|| BR2_STATIC_LIBS
-- 
2.45.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/bcc: add missing dependencies to comment

[Thomas Petazzoni via buildroot]

On Sun,  9 Jun 2024 21:55:19 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Since its inception in 146498d13c48 (package/bcc: new package), not all
> the dependencies of bcc are mirrored in the comment to be displayed when
> those dependencies are not met.
> 
> Fix that by adding the missing pieces:
>   - wchar,
>   - threads
>   - dynamic libs,
> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Jugurtha BELKALEM <jugurtha.belkalem@smile.fr>
> Cc: Romain Naour <romain.naour@gmail.com>
> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
>  package/bcc/Config.in | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/bcc: add missing dependencies to comment

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Since its inception in 146498d13c48 (package/bcc: new package), not all
 > the dependencies of bcc are mirrored in the comment to be displayed when
 > those dependencies are not met.

 > Fix that by adding the missing pieces:
 >   - wchar,
 >   - threads
 >   - dynamic libs,

 > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
 > Cc: Jugurtha BELKALEM <jugurtha.belkalem@smile.fr>
 > Cc: Romain Naour <romain.naour@gmail.com>
 > Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Committed to 2024.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot