[Buildroot] [PATCH 1/3] package/rpi-firmware: bump version to v1.20240529

[Buildroot] [PATCH 1/3] package/rpi-firmware: bump version to v1.20240529

[Athaariq Ardhiansyah]

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
---
 package/rpi-firmware/Config.in         | 5 +++++
 package/rpi-firmware/rpi-firmware.hash | 2 +-
 package/rpi-firmware/rpi-firmware.mk   | 2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/package/rpi-firmware/Config.in b/package/rpi-firmware/Config.in
index a9aeaed745..e4de5ddaa3 100644
--- a/package/rpi-firmware/Config.in
+++ b/package/rpi-firmware/Config.in
@@ -63,6 +63,11 @@ config BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI4_DB
 	help
 	  The debug set of files for versions 4.
 
+config BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI5
+	bool "rpi 5"
+	help
+	  The default set of files for versions 5.
+
 config BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE
 	string "Path to a file stored as boot/config.txt"
 	help
diff --git a/package/rpi-firmware/rpi-firmware.hash b/package/rpi-firmware/rpi-firmware.hash
index 33e05a2f4a..57afe3a1e5 100644
--- a/package/rpi-firmware/rpi-firmware.hash
+++ b/package/rpi-firmware/rpi-firmware.hash
@@ -1,3 +1,3 @@
 # Locally computed
-sha256  dd43e77ca1a8969cdb7f05dd72a57f90862071d5a93bdd6aea8246aba85689cf  rpi-firmware-83dafbc92c0e63f76ca2ecdd42462d56489d1c77.tar.gz
+sha256  a116479e4e8e3bae354860d00321e5df5010cdbe10a3db9e59c81858a0aec84d  rpi-firmware-3590de0c181d433af368a95f15bc480bdaff8b47.tar.gz
 sha256  c7283ff51f863d93a275c66e3b4cb08021a5dd4d8c1e7acc47d872fbe52d3d6b  boot/LICENCE.broadcom
diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
index 11177aee02..5eef3974d3 100644
--- a/package/rpi-firmware/rpi-firmware.mk
+++ b/package/rpi-firmware/rpi-firmware.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-RPI_FIRMWARE_VERSION = 83dafbc92c0e63f76ca2ecdd42462d56489d1c77
+RPI_FIRMWARE_VERSION = 3590de0c181d433af368a95f15bc480bdaff8b47
 RPI_FIRMWARE_SITE = $(call github,raspberrypi,firmware,$(RPI_FIRMWARE_VERSION))
 RPI_FIRMWARE_LICENSE = BSD-3-Clause
 RPI_FIRMWARE_LICENSE_FILES = boot/LICENCE.broadcom
-- 
2.45.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/3] package/raspberrypi-usbboot: bump version to 20221215-105525

[Athaariq Ardhiansyah]

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
---
 ...akefile-allow-passing-CFLAGS-LDFLAGS.patch | 23 ++++++++++---------
 .../raspberrypi-usbboot.hash                  |  2 +-
 .../raspberrypi-usbboot.mk                    |  4 ++--
 3 files changed, 15 insertions(+), 14 deletions(-)

diff --git a/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch b/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch
index d482b0b9d4..4a0db4d5d4 100644
--- a/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch
+++ b/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch
@@ -1,30 +1,31 @@
-From 38b730c00f45abf324caf687b5b00662ff4252c2 Mon Sep 17 00:00:00 2001
-From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-Date: Fri, 2 Dec 2016 23:09:44 +0100
+From 26048a4b79b97bfef72aa62c9e3aaf2fe88e58a3 Mon Sep 17 00:00:00 2001
+From: Athaariq Ardhiansyah <foss@athaariq.my.id>
+Date: Mon, 3 Jun 2024 12:58:28 +0700
 Subject: [PATCH] Makefile: allow passing CFLAGS/LDFLAGS
 
-This might be needed to pass some custom CFLAGS/LDFLAGS when building
-rpiboot.
+This might be needed to pass some custom CFLAGS/LDFLAGS when building rpiboot.
 
 Submitted-upstream: https://github.com/raspberrypi/usbboot/pull/2
 Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-[Rebased on 9324fd7]
 Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
 ---
  Makefile | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/Makefile b/Makefile
-index 822e714..875e717 100755
+index dc78cfe..c9d4910 100755
 --- a/Makefile
 +++ b/Makefile
-@@ -1,5 +1,5 @@
+@@ -1,7 +1,7 @@
+ PKG_VER=$(shell grep rpiboot debian/changelog | head -n1 | sed 's/.*(\(.*\)).*/\1/g')
+ GIT_VER=$(shell git rev-parse HEAD 2>/dev/null | cut -c1-8 || echo "")
  rpiboot: main.c msd/bootcode.h msd/start.h msd/bootcode4.h msd/start4.h
--	$(CC) -Wall -Wextra -g -o $@ $< -lusb-1.0
-+	$(CC) -Wall -Wextra -g $(CFLAGS) -o $@ $< -lusb-1.0 $(LDFLAGS)
+-	$(CC) -Wall -Wextra -g -o $@ $< `pkg-config --cflags --libs libusb-1.0` -DGIT_VER="\"$(GIT_VER)\"" -DPKG_VER="\"$(PKG_VER)\""
++	$(CC) -Wall -Wextra -g $(CFLAGS) -o $@ $< `pkg-config --cflags --libs libusb-1.0` -DGIT_VER="\"$(GIT_VER)\"" -DPKG_VER="\"$(PKG_VER)\"" $(LDFLAGS)
  
  %.h: %.bin ./bin2c
  	./bin2c $< $@
 -- 
-2.31.1
+2.45.2
 
diff --git a/package/raspberrypi-usbboot/raspberrypi-usbboot.hash b/package/raspberrypi-usbboot/raspberrypi-usbboot.hash
index cedc5fb7e1..830ead8243 100644
--- a/package/raspberrypi-usbboot/raspberrypi-usbboot.hash
+++ b/package/raspberrypi-usbboot/raspberrypi-usbboot.hash
@@ -1,5 +1,5 @@
 # Locally calculated
-sha256  4565314b38e7c7505b7d32a3b51b49f79c7dd5767d45b86d38e5255ae7489a43  raspberrypi-usbboot-2021.07.01.tar.gz
+sha256  2f02dbe9a88e9dfad5f05e513e1f30afd47b1575820f7c3b09665dfefc45bbaa  raspberrypi-usbboot-20221215-105525.tar.gz
 
 # License files
 sha256  b40930bbcf80744c86c46a12bc9da056641d722716c378f5659b9e555ef833e1  LICENSE
diff --git a/package/raspberrypi-usbboot/raspberrypi-usbboot.mk b/package/raspberrypi-usbboot/raspberrypi-usbboot.mk
index 2e4194da0b..24a1f6d906 100644
--- a/package/raspberrypi-usbboot/raspberrypi-usbboot.mk
+++ b/package/raspberrypi-usbboot/raspberrypi-usbboot.mk
@@ -4,9 +4,9 @@
 #
 ################################################################################
 
-RASPBERRYPI_USBBOOT_VERSION = 2021.07.01
+RASPBERRYPI_USBBOOT_VERSION = 20221215-105525
 RASPBERRYPI_USBBOOT_SITE = \
-	$(call github,raspberrypi,usbboot,v$(RASPBERRYPI_USBBOOT_VERSION))
+	$(call github,raspberrypi,usbboot,$(RASPBERRYPI_USBBOOT_VERSION))
 RASPBERRYPI_USBBOOT_LICENSE = Apache-2.0
 RASPBERRYPI_USBBOOT_LICENSE_FILES = LICENSE
 
-- 
2.45.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 3/3] board/raspberrypi: add support for Raspberry Pi 5

[Athaariq Ardhiansyah]

Since the last Raspberry Pi 5 submission has no progress, I am submitting these patches anyway. The newly released Raspberry Pi 5 board shares similar software structure except it has less proprietary API. Therefore, rpi-userland and all of raspberry-centric GPIO utilities are no longer supported. Also keep in mind that RPi 5 has no native 32-bit support for both kernel and userspace binary due to Cortex-A76 processor specification. That is the reason why I did not add _64.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
---
 board/raspberrypi/config_5.txt | 65 ++++++++++++++++++++++++++++++++++
 board/raspberrypi5             |  1 +
 configs/raspberrypi5_defconfig | 46 ++++++++++++++++++++++++
 package/raspi-gpio/Config.in   |  4 +++
 package/rpi-userland/Config.in |  3 ++
 5 files changed, 119 insertions(+)
 create mode 100644 board/raspberrypi/config_5.txt
 create mode 120000 board/raspberrypi5
 create mode 100644 configs/raspberrypi5_defconfig

diff --git a/board/raspberrypi/config_5.txt b/board/raspberrypi/config_5.txt
new file mode 100644
index 0000000000..2e470fff99
--- /dev/null
+++ b/board/raspberrypi/config_5.txt
@@ -0,0 +1,65 @@
+# Please note that this is only a sample, we recommend you to change it to fit
+# your needs.
+# You should override this file using BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE.
+# See http://buildroot.org/manual.html#rootfs-custom
+# and http://elinux.org/RPiconfig for a description of config.txt syntax
+
+# Raspberry Pi 5 has no start.elf and fixup.dat files due to the existence of
+# Bootloader EEPROM
+
+kernel=Image
+
+# To use an external initramfs file
+#initramfs rootfs.cpio.gz
+
+# Automatically load initramfs files, if found
+auto_initramfs=1
+
+# Uncomment some or all of these to enable the optional hardware interfaces
+#dtparam=i2c_arm=on
+#dtparam=i2s=on
+#dtparam=spi=on
+
+# Enable audio (loads snd_bcm2835)
+dtparam=audio=on
+
+# Automatically load overlays for detected cameras
+camera_auto_detect=1
+
+# Automatically load overlays for detected DSI displays
+display_auto_detect=1
+
+# Enable DRM VC4 V3D driver
+dtoverlay=vc4-kms-v3d-pi5
+max_framebuffers=2
+
+# Don't have the firmware create an initial video= setting in cmdline.txt.
+# Use the kernel's default instead.
+disable_fw_kms_setup=1
+
+# Disable overscan assuming the display supports displaying the full resolution
+# If the text shown on the screen disappears off the edge, comment this out
+disable_overscan=1
+
+# How much memory in MB to assign to the GPU on Pi models having
+# 256, 512 or 1024 MB total memory
+gpu_mem_256=100
+gpu_mem_512=100
+gpu_mem_1024=100
+
+# fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
+dtoverlay=miniuart-bt
+
+# enable autoprobing of Bluetooth driver without need of hciattach/btattach
+dtparam=krnbt=on
+
+# enable 64bits support
+arm_64bit=1
+
+# Run as fast as firmware / board allows
+arm_boost=1
+
+# Raspberry PI 5 won't use UART0 as terminal out of the box. We need to enable
+# this through config.txt
+enable_uart=1
+dtoverlay=uart0-pi5
diff --git a/board/raspberrypi5 b/board/raspberrypi5
new file mode 120000
index 0000000000..fcdafc81ed
--- /dev/null
+++ b/board/raspberrypi5
@@ -0,0 +1 @@
+raspberrypi
\ No newline at end of file
diff --git a/configs/raspberrypi5_defconfig b/configs/raspberrypi5_defconfig
new file mode 100644
index 0000000000..733838ab2e
--- /dev/null
+++ b/configs/raspberrypi5_defconfig
@@ -0,0 +1,46 @@
+BR2_aarch64=y
+BR2_cortex_a76=y
+
+# patches
+BR2_GLOBAL_PATCH_DIR="board/raspberrypi/patches"
+BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
+
+BR2_SYSTEM_DHCP="eth0"
+
+# Linux headers same as kernel, a 6.6 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_6=y
+
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
+BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,c1432b4bae5b6582f4d32ba381459f33c34d1424)/linux-c1432b4bae5b6582f4d32ba381459f33c34d1424.tar.gz"
+BR2_LINUX_KERNEL_DEFCONFIG="bcm2712"
+
+# Build the DTB from the kernel sources
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="broadcom/bcm2712-rpi-5-b"
+
+BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
+
+BR2_PACKAGE_RPI_FIRMWARE=y
+BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI5=y
+BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE="board/raspberrypi5/config_5.txt"
+
+# Required tools to create the SD image
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y
+
+# Filesystem / image
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="256M"
+BR2_TARGET_ROOTFS_EXT2_MKFS_OPTIONS="-O 64bit"
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi5/post-build.sh"
+BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi5/post-image.sh"
+
+# Enable compressed kernel module support
+BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y
+BR2_PACKAGE_KMOD_TOOLS=y
+BR2_PACKAGE_XZ=y
+BR2_PACKAGE_KMOD=y
+BR2_PACKAGE_HOST_KMOD_XZ=y
diff --git a/package/raspi-gpio/Config.in b/package/raspi-gpio/Config.in
index 32a9448335..19c796e4a7 100644
--- a/package/raspi-gpio/Config.in
+++ b/package/raspi-gpio/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_RASPI_GPIO
 	bool "raspi-gpio"
+	depends on !BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI5
 	help
 	  Tool to help debug / hack at the BCM283x GPIO. You can dump
 	  the state of a GPIO or (all GPIOs). You can change a GPIO
@@ -9,4 +10,7 @@ config BR2_PACKAGE_RASPI_GPIO
 	  registers, ignoring anything else that may be using them
 	  (like Linux drivers).
 
+	  WARNING: Raspberry Pi 5 is NOT supported. Use libgpiod2
+	           instead.
+
 	  https://github.com/RPi-Distro/raspi-gpio
diff --git a/package/rpi-userland/Config.in b/package/rpi-userland/Config.in
index 4219bdb9c4..a4fff821e1 100644
--- a/package/rpi-userland/Config.in
+++ b/package/rpi-userland/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_RPI_USERLAND
 	depends on BR2_arm || BR2_aarch64
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI5
 	depends on !BR2_STATIC_LIBS
 	select BR2_PACKAGE_HAS_LIBEGL if BR2_arm
 	select BR2_PACKAGE_HAS_LIBGLES if BR2_arm
@@ -16,6 +17,8 @@ config BR2_PACKAGE_RPI_USERLAND
 	  mmal, GLESv2, vcos, openmaxil, vchiq_arm, bcm_host, WFC,
 	  OpenVG.
 
+	  WARNING: Raspberry Pi 5 is NOT supported. Use mesa3d instead.
+
 	  https://github.com/raspberrypi/userland/
 
 if BR2_PACKAGE_RPI_USERLAND && BR2_arm
-- 
2.45.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 1/3] package/rpi-firmware: bump version to v1.20240529

[Athaariq Ardhiansyah]

Latest RPi firmware already provided support for Raspberry Pi 5.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

---
Changes v1 -> v2:
  - Fix missing description due to terminal issue
---
 package/rpi-firmware/Config.in         | 5 +++++
 package/rpi-firmware/rpi-firmware.hash | 2 +-
 package/rpi-firmware/rpi-firmware.mk   | 2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/package/rpi-firmware/Config.in b/package/rpi-firmware/Config.in
index a9aeaed745..e4de5ddaa3 100644
--- a/package/rpi-firmware/Config.in
+++ b/package/rpi-firmware/Config.in
@@ -63,6 +63,11 @@ config BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI4_DB
 	help
 	  The debug set of files for versions 4.
 
+config BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI5
+	bool "rpi 5"
+	help
+	  The default set of files for versions 5.
+
 config BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE
 	string "Path to a file stored as boot/config.txt"
 	help
diff --git a/package/rpi-firmware/rpi-firmware.hash b/package/rpi-firmware/rpi-firmware.hash
index 33e05a2f4a..57afe3a1e5 100644
--- a/package/rpi-firmware/rpi-firmware.hash
+++ b/package/rpi-firmware/rpi-firmware.hash
@@ -1,3 +1,3 @@
 # Locally computed
-sha256  dd43e77ca1a8969cdb7f05dd72a57f90862071d5a93bdd6aea8246aba85689cf  rpi-firmware-83dafbc92c0e63f76ca2ecdd42462d56489d1c77.tar.gz
+sha256  a116479e4e8e3bae354860d00321e5df5010cdbe10a3db9e59c81858a0aec84d  rpi-firmware-3590de0c181d433af368a95f15bc480bdaff8b47.tar.gz
 sha256  c7283ff51f863d93a275c66e3b4cb08021a5dd4d8c1e7acc47d872fbe52d3d6b  boot/LICENCE.broadcom
diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
index 11177aee02..5eef3974d3 100644
--- a/package/rpi-firmware/rpi-firmware.mk
+++ b/package/rpi-firmware/rpi-firmware.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-RPI_FIRMWARE_VERSION = 83dafbc92c0e63f76ca2ecdd42462d56489d1c77
+RPI_FIRMWARE_VERSION = 3590de0c181d433af368a95f15bc480bdaff8b47
 RPI_FIRMWARE_SITE = $(call github,raspberrypi,firmware,$(RPI_FIRMWARE_VERSION))
 RPI_FIRMWARE_LICENSE = BSD-3-Clause
 RPI_FIRMWARE_LICENSE_FILES = boot/LICENCE.broadcom
-- 
2.45.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 2/3] package/raspberrypi-usbboot: bump version to 20221215-105525

[Athaariq Ardhiansyah]

Latest raspberrypi-usbboot package has Raspberry Pi 5 support.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

---
Changes v1 -> v2:
  - Fix missing description due to terminal issue
  - Use the latest commit instead of the latest tag
---
 ...akefile-allow-passing-CFLAGS-LDFLAGS.patch | 25 ++++++++++---------
 .../raspberrypi-usbboot.hash                  |  2 +-
 .../raspberrypi-usbboot.mk                    |  4 +--
 3 files changed, 16 insertions(+), 15 deletions(-)

diff --git a/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch b/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch
index d482b0b9d4..ea53f8360a 100644
--- a/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch
+++ b/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch
@@ -1,30 +1,31 @@
-From 38b730c00f45abf324caf687b5b00662ff4252c2 Mon Sep 17 00:00:00 2001
-From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-Date: Fri, 2 Dec 2016 23:09:44 +0100
+From e09c92d68efa4efbd48a3366f9053a4f8c275091 Mon Sep 17 00:00:00 2001
+From: Athaariq Ardhiansyah <foss@athaariq.my.id>
+Date: Mon, 3 Jun 2024 15:35:49 +0700
 Subject: [PATCH] Makefile: allow passing CFLAGS/LDFLAGS
 
-This might be needed to pass some custom CFLAGS/LDFLAGS when building
-rpiboot.
+This might be needed to pass some custom CFLAGS/LDFLAGS when building rpiboot.
 
 Submitted-upstream: https://github.com/raspberrypi/usbboot/pull/2
 Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-[Rebased on 9324fd7]
 Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
 ---
  Makefile | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/Makefile b/Makefile
-index 822e714..875e717 100755
+index 4479b1b..076ae43 100755
 --- a/Makefile
 +++ b/Makefile
-@@ -1,5 +1,5 @@
- rpiboot: main.c msd/bootcode.h msd/start.h msd/bootcode4.h msd/start4.h
--	$(CC) -Wall -Wextra -g -o $@ $< -lusb-1.0
-+	$(CC) -Wall -Wextra -g $(CFLAGS) -o $@ $< -lusb-1.0 $(LDFLAGS)
+@@ -3,7 +3,7 @@ GIT_VER=$(shell git rev-parse HEAD 2>/dev/null | cut -c1-8 || echo "")
+ INSTALL_PREFIX?=/usr
+ 
+ rpiboot: main.c bootfiles.c msd/bootcode.h msd/start.h msd/bootcode4.h msd/start4.h
+-	$(CC) -Wall -Wextra -g -o $@ main.c bootfiles.c `pkg-config --cflags --libs libusb-1.0` -DGIT_VER="\"$(GIT_VER)\"" -DPKG_VER="\"$(PKG_VER)\"" -DINSTALL_PREFIX=\"$(INSTALL_PREFIX)\"
++	$(CC) -Wall -Wextra -g $(CFLAGS) -o $@ main.c bootfiles.c `pkg-config --cflags --libs libusb-1.0` -DGIT_VER="\"$(GIT_VER)\"" -DPKG_VER="\"$(PKG_VER)\"" -DINSTALL_PREFIX=\"$(INSTALL_PREFIX)\" $(LDFLAGS)
  
  %.h: %.bin ./bin2c
  	./bin2c $< $@
 -- 
-2.31.1
+2.45.2
 
diff --git a/package/raspberrypi-usbboot/raspberrypi-usbboot.hash b/package/raspberrypi-usbboot/raspberrypi-usbboot.hash
index cedc5fb7e1..1a183bf47f 100644
--- a/package/raspberrypi-usbboot/raspberrypi-usbboot.hash
+++ b/package/raspberrypi-usbboot/raspberrypi-usbboot.hash
@@ -1,5 +1,5 @@
 # Locally calculated
-sha256  4565314b38e7c7505b7d32a3b51b49f79c7dd5767d45b86d38e5255ae7489a43  raspberrypi-usbboot-2021.07.01.tar.gz
+sha256  2182a6bf5ca9cd54ee3bca2d7667758ceac685fa78a3a6ae663762bde03e781a  raspberrypi-usbboot-4a3d31171769f87d919340778e5aaeaba01e10b5.tar.gz
 
 # License files
 sha256  b40930bbcf80744c86c46a12bc9da056641d722716c378f5659b9e555ef833e1  LICENSE
diff --git a/package/raspberrypi-usbboot/raspberrypi-usbboot.mk b/package/raspberrypi-usbboot/raspberrypi-usbboot.mk
index 2e4194da0b..7eef7df600 100644
--- a/package/raspberrypi-usbboot/raspberrypi-usbboot.mk
+++ b/package/raspberrypi-usbboot/raspberrypi-usbboot.mk
@@ -4,9 +4,9 @@
 #
 ################################################################################
 
-RASPBERRYPI_USBBOOT_VERSION = 2021.07.01
+RASPBERRYPI_USBBOOT_VERSION = 4a3d31171769f87d919340778e5aaeaba01e10b5
 RASPBERRYPI_USBBOOT_SITE = \
-	$(call github,raspberrypi,usbboot,v$(RASPBERRYPI_USBBOOT_VERSION))
+	$(call github,raspberrypi,usbboot,$(RASPBERRYPI_USBBOOT_VERSION))
 RASPBERRYPI_USBBOOT_LICENSE = Apache-2.0
 RASPBERRYPI_USBBOOT_LICENSE_FILES = LICENSE
 
-- 
2.45.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 2/3] package/raspberrypi-usbboot: bump version to 20221215-105525

[Fiona Klute via buildroot]

Hi Athaariq!

Am 03.06.24 um 10:46 schrieb Athaariq Ardhiansyah:
> Latest raspberrypi-usbboot package has Raspberry Pi 5 support.
>
> Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
>
> ---
> Changes v1 -> v2:
>    - Fix missing description due to terminal issue
>    - Use the latest commit instead of the latest tag
> ---
>   ...akefile-allow-passing-CFLAGS-LDFLAGS.patch | 25 ++++++++++---------
>   .../raspberrypi-usbboot.hash                  |  2 +-
>   .../raspberrypi-usbboot.mk                    |  4 +--
>   3 files changed, 16 insertions(+), 15 deletions(-)
>
> diff --git a/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch b/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch
> index d482b0b9d4..ea53f8360a 100644
> --- a/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch
> +++ b/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch
> @@ -1,30 +1,31 @@
> -From 38b730c00f45abf324caf687b5b00662ff4252c2 Mon Sep 17 00:00:00 2001
> -From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> -Date: Fri, 2 Dec 2016 23:09:44 +0100
> +From e09c92d68efa4efbd48a3366f9053a4f8c275091 Mon Sep 17 00:00:00 2001
> +From: Athaariq Ardhiansyah <foss@athaariq.my.id>
> +Date: Mon, 3 Jun 2024 15:35:49 +0700
>   Subject: [PATCH] Makefile: allow passing CFLAGS/LDFLAGS
>
> -This might be needed to pass some custom CFLAGS/LDFLAGS when building
> -rpiboot.
> +This might be needed to pass some custom CFLAGS/LDFLAGS when building rpiboot.
>
>   Submitted-upstream: https://github.com/raspberrypi/usbboot/pull/2
>   Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> -[Rebased on 9324fd7]
>   Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> +Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
>   ---
>    Makefile | 2 +-
>    1 file changed, 1 insertion(+), 1 deletion(-)
>
>   diff --git a/Makefile b/Makefile
> -index 822e714..875e717 100755
> +index 4479b1b..076ae43 100755
>   --- a/Makefile
>   +++ b/Makefile
> -@@ -1,5 +1,5 @@
> - rpiboot: main.c msd/bootcode.h msd/start.h msd/bootcode4.h msd/start4.h
> --	$(CC) -Wall -Wextra -g -o $@ $< -lusb-1.0
> -+	$(CC) -Wall -Wextra -g $(CFLAGS) -o $@ $< -lusb-1.0 $(LDFLAGS)
> +@@ -3,7 +3,7 @@ GIT_VER=$(shell git rev-parse HEAD 2>/dev/null | cut -c1-8 || echo "")
> + INSTALL_PREFIX?=/usr
> +
> + rpiboot: main.c bootfiles.c msd/bootcode.h msd/start.h msd/bootcode4.h msd/start4.h
> +-	$(CC) -Wall -Wextra -g -o $@ main.c bootfiles.c `pkg-config --cflags --libs libusb-1.0` -DGIT_VER="\"$(GIT_VER)\"" -DPKG_VER="\"$(PKG_VER)\"" -DINSTALL_PREFIX=\"$(INSTALL_PREFIX)\"
> ++	$(CC) -Wall -Wextra -g $(CFLAGS) -o $@ main.c bootfiles.c `pkg-config --cflags --libs libusb-1.0` -DGIT_VER="\"$(GIT_VER)\"" -DPKG_VER="\"$(PKG_VER)\"" -DINSTALL_PREFIX=\"$(INSTALL_PREFIX)\" $(LDFLAGS)
>
>    %.h: %.bin ./bin2c
>    	./bin2c $< $@
>   --
> -2.31.1
> +2.45.2
>
> diff --git a/package/raspberrypi-usbboot/raspberrypi-usbboot.hash b/package/raspberrypi-usbboot/raspberrypi-usbboot.hash
> index cedc5fb7e1..1a183bf47f 100644
> --- a/package/raspberrypi-usbboot/raspberrypi-usbboot.hash
> +++ b/package/raspberrypi-usbboot/raspberrypi-usbboot.hash
> @@ -1,5 +1,5 @@
>   # Locally calculated
> -sha256  4565314b38e7c7505b7d32a3b51b49f79c7dd5767d45b86d38e5255ae7489a43  raspberrypi-usbboot-2021.07.01.tar.gz
> +sha256  2182a6bf5ca9cd54ee3bca2d7667758ceac685fa78a3a6ae663762bde03e781a  raspberrypi-usbboot-4a3d31171769f87d919340778e5aaeaba01e10b5.tar.gz
>
>   # License files
>   sha256  b40930bbcf80744c86c46a12bc9da056641d722716c378f5659b9e555ef833e1  LICENSE
> diff --git a/package/raspberrypi-usbboot/raspberrypi-usbboot.mk b/package/raspberrypi-usbboot/raspberrypi-usbboot.mk
> index 2e4194da0b..7eef7df600 100644
> --- a/package/raspberrypi-usbboot/raspberrypi-usbboot.mk
> +++ b/package/raspberrypi-usbboot/raspberrypi-usbboot.mk
> @@ -4,9 +4,9 @@
>   #
>   ################################################################################
>
> -RASPBERRYPI_USBBOOT_VERSION = 2021.07.01
> +RASPBERRYPI_USBBOOT_VERSION = 4a3d31171769f87d919340778e5aaeaba01e10b5

This commit is (as of typing) the latest commit on the master branch of
the GitHub repository, not version 20221215-105525. I sent a patch to
update to 20221215-105525 in late April because I need it for certain
CM4 devices, so I noticed the difference. Including RPi 5 support as
well makes sense to me, but the commit message should mention the actual
version.

Best regards,
Fiona

>   RASPBERRYPI_USBBOOT_SITE = \
> -	$(call github,raspberrypi,usbboot,v$(RASPBERRYPI_USBBOOT_VERSION))
> +	$(call github,raspberrypi,usbboot,$(RASPBERRYPI_USBBOOT_VERSION))
>   RASPBERRYPI_USBBOOT_LICENSE = Apache-2.0
>   RASPBERRYPI_USBBOOT_LICENSE_FILES = LICENSE
>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 2/3] package/raspberrypi-usbboot: bump version to 20221215-105525

[Athaariq Ardhiansyah]

Hi Fiona!

 > the commit message should mention the actual version.

The upstream maintainer won't tag the version anymore since December
18th, 2022. So, I have no idea what version of the latest commit. Last
tagged version has no Raspberry Pi 5 support, unfortunately. From your
perspective, should we ask the maintainer to tag again or we can safely
use the latest commit possible similar as rpi-firmware? Thanks.

Best regards,
Athaariq Ardhiansyah
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 2/3] package/raspberrypi-usbboot: bump version to 20221215-105525

[Fiona Klute via buildroot]

Am 04.06.24 um 00:58 schrieb Athaariq Ardhiansyah:
>  > the commit message should mention the actual version.
>
> The upstream maintainer won't tag the version anymore since December
> 18th, 2022. So, I have no idea what version of the latest commit. Last
> tagged version has no Raspberry Pi 5 support, unfortunately.

I hope one of the Buildroot maintainers can clarify what you should do
here. Personally, I'd probably use the commit as version in the commit
message too, and mention the reason (upstream hasn't done tags, this
commit adds RPi 5 support, something like that).

> From your
> perspective, should we ask the maintainer to tag again or we can safely
> use the latest commit possible similar as rpi-firmware? Thanks.

Can't hurt, but I have no idea if they'll follow the request, and
Buildroot shouldn't depend on it either way. The commit ID and source
hash will ensure it's well-defined what version you're using.

Mostly I just want an update that supports the CM4 version I have here
merged ASAP so I can drop the patch from my work branch. :-)

Best regards,
Fiona

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v3 1/3] package/rpi-firmware: bump version to v1.20240529

[Athaariq Ardhiansyah]

Latest RPi firmware already provided support for Raspberry Pi 5.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

---
Changes v1 -> v2:
  - Fix missing description due to terminal issue
---
 package/rpi-firmware/Config.in         | 5 +++++
 package/rpi-firmware/rpi-firmware.hash | 2 +-
 package/rpi-firmware/rpi-firmware.mk   | 2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/package/rpi-firmware/Config.in b/package/rpi-firmware/Config.in
index a9aeaed745..e4de5ddaa3 100644
--- a/package/rpi-firmware/Config.in
+++ b/package/rpi-firmware/Config.in
@@ -63,6 +63,11 @@ config BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI4_DB
 	help
 	  The debug set of files for versions 4.
 
+config BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI5
+	bool "rpi 5"
+	help
+	  The default set of files for versions 5.
+
 config BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE
 	string "Path to a file stored as boot/config.txt"
 	help
diff --git a/package/rpi-firmware/rpi-firmware.hash b/package/rpi-firmware/rpi-firmware.hash
index 33e05a2f4a..57afe3a1e5 100644
--- a/package/rpi-firmware/rpi-firmware.hash
+++ b/package/rpi-firmware/rpi-firmware.hash
@@ -1,3 +1,3 @@
 # Locally computed
-sha256  dd43e77ca1a8969cdb7f05dd72a57f90862071d5a93bdd6aea8246aba85689cf  rpi-firmware-83dafbc92c0e63f76ca2ecdd42462d56489d1c77.tar.gz
+sha256  a116479e4e8e3bae354860d00321e5df5010cdbe10a3db9e59c81858a0aec84d  rpi-firmware-3590de0c181d433af368a95f15bc480bdaff8b47.tar.gz
 sha256  c7283ff51f863d93a275c66e3b4cb08021a5dd4d8c1e7acc47d872fbe52d3d6b  boot/LICENCE.broadcom
diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
index 11177aee02..5eef3974d3 100644
--- a/package/rpi-firmware/rpi-firmware.mk
+++ b/package/rpi-firmware/rpi-firmware.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-RPI_FIRMWARE_VERSION = 83dafbc92c0e63f76ca2ecdd42462d56489d1c77
+RPI_FIRMWARE_VERSION = 3590de0c181d433af368a95f15bc480bdaff8b47
 RPI_FIRMWARE_SITE = $(call github,raspberrypi,firmware,$(RPI_FIRMWARE_VERSION))
 RPI_FIRMWARE_LICENSE = BSD-3-Clause
 RPI_FIRMWARE_LICENSE_FILES = boot/LICENCE.broadcom
-- 
2.45.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v3 2/3] package/raspberrypi-usbboot: bump version to master (commit 4a3d311)

[Athaariq Ardhiansyah]

Latest raspberrypi-usbboot package has Raspberry Pi 5 support. It is
considerably matured at commit 4a3d31171769f87d919340778e5aaeaba01e10b5.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

---
Changes v1 -> v2:
  - Fix missing description due to terminal issue
  - Use the latest commit instead of the latest tag

Changes v2 -> v3:
  - Update the commit title
  - Add more explanation on commit description
---
 ...akefile-allow-passing-CFLAGS-LDFLAGS.patch | 25 ++++++++++---------
 .../raspberrypi-usbboot.hash                  |  2 +-
 .../raspberrypi-usbboot.mk                    |  4 +--
 3 files changed, 16 insertions(+), 15 deletions(-)

diff --git a/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch b/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch
index d482b0b9d4..ea53f8360a 100644
--- a/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch
+++ b/package/raspberrypi-usbboot/0001-Makefile-allow-passing-CFLAGS-LDFLAGS.patch
@@ -1,30 +1,31 @@
-From 38b730c00f45abf324caf687b5b00662ff4252c2 Mon Sep 17 00:00:00 2001
-From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-Date: Fri, 2 Dec 2016 23:09:44 +0100
+From e09c92d68efa4efbd48a3366f9053a4f8c275091 Mon Sep 17 00:00:00 2001
+From: Athaariq Ardhiansyah <foss@athaariq.my.id>
+Date: Mon, 3 Jun 2024 15:35:49 +0700
 Subject: [PATCH] Makefile: allow passing CFLAGS/LDFLAGS
 
-This might be needed to pass some custom CFLAGS/LDFLAGS when building
-rpiboot.
+This might be needed to pass some custom CFLAGS/LDFLAGS when building rpiboot.
 
 Submitted-upstream: https://github.com/raspberrypi/usbboot/pull/2
 Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-[Rebased on 9324fd7]
 Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
 ---
  Makefile | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/Makefile b/Makefile
-index 822e714..875e717 100755
+index 4479b1b..076ae43 100755
 --- a/Makefile
 +++ b/Makefile
-@@ -1,5 +1,5 @@
- rpiboot: main.c msd/bootcode.h msd/start.h msd/bootcode4.h msd/start4.h
--	$(CC) -Wall -Wextra -g -o $@ $< -lusb-1.0
-+	$(CC) -Wall -Wextra -g $(CFLAGS) -o $@ $< -lusb-1.0 $(LDFLAGS)
+@@ -3,7 +3,7 @@ GIT_VER=$(shell git rev-parse HEAD 2>/dev/null | cut -c1-8 || echo "")
+ INSTALL_PREFIX?=/usr
+ 
+ rpiboot: main.c bootfiles.c msd/bootcode.h msd/start.h msd/bootcode4.h msd/start4.h
+-	$(CC) -Wall -Wextra -g -o $@ main.c bootfiles.c `pkg-config --cflags --libs libusb-1.0` -DGIT_VER="\"$(GIT_VER)\"" -DPKG_VER="\"$(PKG_VER)\"" -DINSTALL_PREFIX=\"$(INSTALL_PREFIX)\"
++	$(CC) -Wall -Wextra -g $(CFLAGS) -o $@ main.c bootfiles.c `pkg-config --cflags --libs libusb-1.0` -DGIT_VER="\"$(GIT_VER)\"" -DPKG_VER="\"$(PKG_VER)\"" -DINSTALL_PREFIX=\"$(INSTALL_PREFIX)\" $(LDFLAGS)
  
  %.h: %.bin ./bin2c
  	./bin2c $< $@
 -- 
-2.31.1
+2.45.2
 
diff --git a/package/raspberrypi-usbboot/raspberrypi-usbboot.hash b/package/raspberrypi-usbboot/raspberrypi-usbboot.hash
index cedc5fb7e1..1a183bf47f 100644
--- a/package/raspberrypi-usbboot/raspberrypi-usbboot.hash
+++ b/package/raspberrypi-usbboot/raspberrypi-usbboot.hash
@@ -1,5 +1,5 @@
 # Locally calculated
-sha256  4565314b38e7c7505b7d32a3b51b49f79c7dd5767d45b86d38e5255ae7489a43  raspberrypi-usbboot-2021.07.01.tar.gz
+sha256  2182a6bf5ca9cd54ee3bca2d7667758ceac685fa78a3a6ae663762bde03e781a  raspberrypi-usbboot-4a3d31171769f87d919340778e5aaeaba01e10b5.tar.gz
 
 # License files
 sha256  b40930bbcf80744c86c46a12bc9da056641d722716c378f5659b9e555ef833e1  LICENSE
diff --git a/package/raspberrypi-usbboot/raspberrypi-usbboot.mk b/package/raspberrypi-usbboot/raspberrypi-usbboot.mk
index 2e4194da0b..7eef7df600 100644
--- a/package/raspberrypi-usbboot/raspberrypi-usbboot.mk
+++ b/package/raspberrypi-usbboot/raspberrypi-usbboot.mk
@@ -4,9 +4,9 @@
 #
 ################################################################################
 
-RASPBERRYPI_USBBOOT_VERSION = 2021.07.01
+RASPBERRYPI_USBBOOT_VERSION = 4a3d31171769f87d919340778e5aaeaba01e10b5
 RASPBERRYPI_USBBOOT_SITE = \
-	$(call github,raspberrypi,usbboot,v$(RASPBERRYPI_USBBOOT_VERSION))
+	$(call github,raspberrypi,usbboot,$(RASPBERRYPI_USBBOOT_VERSION))
 RASPBERRYPI_USBBOOT_LICENSE = Apache-2.0
 RASPBERRYPI_USBBOOT_LICENSE_FILES = LICENSE
 
-- 
2.45.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 2/3] package/raspberrypi-usbboot: bump version to master (commit 4a3d311)

[Thomas Petazzoni via buildroot]

Hello Athaariq,

On Tue,  4 Jun 2024 06:09:35 +0700
Athaariq Ardhiansyah <foss@athaariq.my.id> wrote:

> Latest raspberrypi-usbboot package has Raspberry Pi 5 support. It is
> considerably matured at commit 4a3d31171769f87d919340778e5aaeaba01e10b5.
> 
> Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

I have for now applied the older patch from Fiona Klute. Please submit
an updated patch if it still makes sense to update raspberry-usbboot
even further.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 2/3] package/raspberrypi-usbboot: bump version to master (commit 4a3d311)

[Athaariq Ardhiansyah]

Hello Thomas,

> I have for now applied the older patch from Fiona Klute. Please submit
> an updated patch if it still makes sense to update raspberry-usbboot
> even further.

Thank you for the Raspberry Pi 5 support! Unfortunately, I broke my
Raspberry Pi 5, so I can't do anything for now. Let's see if I can get a
new one on the next payday this month.

Regards,
Athaariq Ardhiansyah
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 2/3] package/raspberrypi-usbboot: bump version to master (commit 4a3d311)

[Gael PORTAY]

Hello Athaariq,

> ________________________________________
> De : buildroot <buildroot-bounces@buildroot.org> de la part de Athaariq Ardhiansyah <foss@athaariq.my.id>
> Envoyé : jeudi 11 juillet 2024 12:30
> À : Thomas Petazzoni
> Cc : Fiona Klute; buildroot@buildroot.org
> Objet : Re: [Buildroot] [PATCH v3 2/3] package/raspberrypi-usbboot: bump version to master (commit 4a3d311)
>
> Attention: Il s'agit d'un courriel externe et pourrait être malveillant. Veuillez vérifier que vous reconnaissez l'adresse e-mail avant d'ouvrir les liens ou pièces jointes.
>
>
> Hello Thomas,
>
> > I have for now applied the older patch from Fiona Klute. Please submit
> > an updated patch if it still makes sense to update raspberry-usbboot
> > even further.
>
> Thank you for the Raspberry Pi 5 support! Unfortunately, I broke my
> Raspberry Pi 5, so I can't do anything for now. Let's see if I can get a
> new one on the next payday this month.
>

I am sorry to hear that.
Do not worry, I can do the testing for you if you like (if you tell me how to proceed) ;)

> Regards,
> Athaariq Ardhiansyah
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

Regards,
Gaël
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v3 3/3] board/raspberrypi: add support for Raspberry Pi 5

[Athaariq Ardhiansyah]

Since the last Raspberry Pi 5 submission has no progress, I'm submitting
these patches anyway. The newly released Raspberry Pi 5 board shares
similar software structure except it has less proprietary API.
Therefore, rpi-userland and all of raspberry-centric GPIO utilities are
no longer supported.

Keep in mind that RPi 5 has no native 32-bit support for both kernel and
userspace binary due to Cortex-A76 processor specification. That is the
reason why I did not add _64.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

---
Changes v1 -> v2:
  - Fix missing newlines due to terminal issue
---
 board/raspberrypi/config_5.txt | 65 ++++++++++++++++++++++++++++++++++
 board/raspberrypi5             |  1 +
 configs/raspberrypi5_defconfig | 46 ++++++++++++++++++++++++
 package/raspi-gpio/Config.in   |  4 +++
 package/rpi-userland/Config.in |  3 ++
 5 files changed, 119 insertions(+)
 create mode 100644 board/raspberrypi/config_5.txt
 create mode 120000 board/raspberrypi5
 create mode 100644 configs/raspberrypi5_defconfig

diff --git a/board/raspberrypi/config_5.txt b/board/raspberrypi/config_5.txt
new file mode 100644
index 0000000000..2e470fff99
--- /dev/null
+++ b/board/raspberrypi/config_5.txt
@@ -0,0 +1,65 @@
+# Please note that this is only a sample, we recommend you to change it to fit
+# your needs.
+# You should override this file using BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE.
+# See http://buildroot.org/manual.html#rootfs-custom
+# and http://elinux.org/RPiconfig for a description of config.txt syntax
+
+# Raspberry Pi 5 has no start.elf and fixup.dat files due to the existence of
+# Bootloader EEPROM
+
+kernel=Image
+
+# To use an external initramfs file
+#initramfs rootfs.cpio.gz
+
+# Automatically load initramfs files, if found
+auto_initramfs=1
+
+# Uncomment some or all of these to enable the optional hardware interfaces
+#dtparam=i2c_arm=on
+#dtparam=i2s=on
+#dtparam=spi=on
+
+# Enable audio (loads snd_bcm2835)
+dtparam=audio=on
+
+# Automatically load overlays for detected cameras
+camera_auto_detect=1
+
+# Automatically load overlays for detected DSI displays
+display_auto_detect=1
+
+# Enable DRM VC4 V3D driver
+dtoverlay=vc4-kms-v3d-pi5
+max_framebuffers=2
+
+# Don't have the firmware create an initial video= setting in cmdline.txt.
+# Use the kernel's default instead.
+disable_fw_kms_setup=1
+
+# Disable overscan assuming the display supports displaying the full resolution
+# If the text shown on the screen disappears off the edge, comment this out
+disable_overscan=1
+
+# How much memory in MB to assign to the GPU on Pi models having
+# 256, 512 or 1024 MB total memory
+gpu_mem_256=100
+gpu_mem_512=100
+gpu_mem_1024=100
+
+# fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
+dtoverlay=miniuart-bt
+
+# enable autoprobing of Bluetooth driver without need of hciattach/btattach
+dtparam=krnbt=on
+
+# enable 64bits support
+arm_64bit=1
+
+# Run as fast as firmware / board allows
+arm_boost=1
+
+# Raspberry PI 5 won't use UART0 as terminal out of the box. We need to enable
+# this through config.txt
+enable_uart=1
+dtoverlay=uart0-pi5
diff --git a/board/raspberrypi5 b/board/raspberrypi5
new file mode 120000
index 0000000000..fcdafc81ed
--- /dev/null
+++ b/board/raspberrypi5
@@ -0,0 +1 @@
+raspberrypi
\ No newline at end of file
diff --git a/configs/raspberrypi5_defconfig b/configs/raspberrypi5_defconfig
new file mode 100644
index 0000000000..733838ab2e
--- /dev/null
+++ b/configs/raspberrypi5_defconfig
@@ -0,0 +1,46 @@
+BR2_aarch64=y
+BR2_cortex_a76=y
+
+# patches
+BR2_GLOBAL_PATCH_DIR="board/raspberrypi/patches"
+BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
+
+BR2_SYSTEM_DHCP="eth0"
+
+# Linux headers same as kernel, a 6.6 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_6=y
+
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
+BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,c1432b4bae5b6582f4d32ba381459f33c34d1424)/linux-c1432b4bae5b6582f4d32ba381459f33c34d1424.tar.gz"
+BR2_LINUX_KERNEL_DEFCONFIG="bcm2712"
+
+# Build the DTB from the kernel sources
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="broadcom/bcm2712-rpi-5-b"
+
+BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
+
+BR2_PACKAGE_RPI_FIRMWARE=y
+BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI5=y
+BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE="board/raspberrypi5/config_5.txt"
+
+# Required tools to create the SD image
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y
+
+# Filesystem / image
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="256M"
+BR2_TARGET_ROOTFS_EXT2_MKFS_OPTIONS="-O 64bit"
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi5/post-build.sh"
+BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi5/post-image.sh"
+
+# Enable compressed kernel module support
+BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y
+BR2_PACKAGE_KMOD_TOOLS=y
+BR2_PACKAGE_XZ=y
+BR2_PACKAGE_KMOD=y
+BR2_PACKAGE_HOST_KMOD_XZ=y
diff --git a/package/raspi-gpio/Config.in b/package/raspi-gpio/Config.in
index 32a9448335..19c796e4a7 100644
--- a/package/raspi-gpio/Config.in
+++ b/package/raspi-gpio/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_RASPI_GPIO
 	bool "raspi-gpio"
+	depends on !BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI5
 	help
 	  Tool to help debug / hack at the BCM283x GPIO. You can dump
 	  the state of a GPIO or (all GPIOs). You can change a GPIO
@@ -9,4 +10,7 @@ config BR2_PACKAGE_RASPI_GPIO
 	  registers, ignoring anything else that may be using them
 	  (like Linux drivers).
 
+	  WARNING: Raspberry Pi 5 is NOT supported. Use libgpiod2
+	           instead.
+
 	  https://github.com/RPi-Distro/raspi-gpio
diff --git a/package/rpi-userland/Config.in b/package/rpi-userland/Config.in
index 4219bdb9c4..a4fff821e1 100644
--- a/package/rpi-userland/Config.in
+++ b/package/rpi-userland/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_RPI_USERLAND
 	depends on BR2_arm || BR2_aarch64
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI5
 	depends on !BR2_STATIC_LIBS
 	select BR2_PACKAGE_HAS_LIBEGL if BR2_arm
 	select BR2_PACKAGE_HAS_LIBGLES if BR2_arm
@@ -16,6 +17,8 @@ config BR2_PACKAGE_RPI_USERLAND
 	  mmal, GLESv2, vcos, openmaxil, vchiq_arm, bcm_host, WFC,
 	  OpenVG.
 
+	  WARNING: Raspberry Pi 5 is NOT supported. Use mesa3d instead.
+
 	  https://github.com/raspberrypi/userland/
 
 if BR2_PACKAGE_RPI_USERLAND && BR2_arm
-- 
2.45.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 1/3] package/rpi-firmware: bump version to v1.20240529

[Arnout Vandecappelle via buildroot]

  Hi Athaariq,

On 04/06/2024 01:09, Athaariq Ardhiansyah wrote:
> Latest RPi firmware already provided support for Raspberry Pi 5.
> 
> Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
> 
> ---
> Changes v1 -> v2:
>    - Fix missing description due to terminal issue
> ---
>   package/rpi-firmware/Config.in         | 5 +++++
>   package/rpi-firmware/rpi-firmware.hash | 2 +-
>   package/rpi-firmware/rpi-firmware.mk   | 2 +-
>   3 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/package/rpi-firmware/Config.in b/package/rpi-firmware/Config.in
> index a9aeaed745..e4de5ddaa3 100644
> --- a/package/rpi-firmware/Config.in
> +++ b/package/rpi-firmware/Config.in
> @@ -63,6 +63,11 @@ config BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI4_DB
>   	help
>   	  The debug set of files for versions 4.
>   
> +config BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI5

  This symbol isn't used in the .mk file, so what's the point of defining it at 
all? These variant symbols are not part of a choice, which means that for 
variants that don't need specific boot firmware, you don't need to have an 
option at all.

  In fact, AFAICS for RPi5, no firmware is installed at all... The only thing 
that gets installed is the config.txt which is copied from board/raspberrypi. 
It's a bit silly to download a 185MB archive and then not use it at all! 
Wouldn't it make more sense to handle the config.txt in the post-image script?

  So, I think this symbol should be dropped, and I think that probably we 
shouldn't enable rpi-firmware in raspberrypi5_defconfig.


> +	bool "rpi 5"
> +	help
> +	  The default set of files for versions 5.
> +
>   config BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE
>   	string "Path to a file stored as boot/config.txt"
>   	help
> diff --git a/package/rpi-firmware/rpi-firmware.hash b/package/rpi-firmware/rpi-firmware.hash
> index 33e05a2f4a..57afe3a1e5 100644
> --- a/package/rpi-firmware/rpi-firmware.hash
> +++ b/package/rpi-firmware/rpi-firmware.hash
> @@ -1,3 +1,3 @@
>   # Locally computed
> -sha256  dd43e77ca1a8969cdb7f05dd72a57f90862071d5a93bdd6aea8246aba85689cf  rpi-firmware-83dafbc92c0e63f76ca2ecdd42462d56489d1c77.tar.gz
> +sha256  a116479e4e8e3bae354860d00321e5df5010cdbe10a3db9e59c81858a0aec84d  rpi-firmware-3590de0c181d433af368a95f15bc480bdaff8b47.tar.gz
>   sha256  c7283ff51f863d93a275c66e3b4cb08021a5dd4d8c1e7acc47d872fbe52d3d6b  boot/LICENCE.broadcom
> diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
> index 11177aee02..5eef3974d3 100644
> --- a/package/rpi-firmware/rpi-firmware.mk
> +++ b/package/rpi-firmware/rpi-firmware.mk
> @@ -4,7 +4,7 @@
>   #
>   ################################################################################
>   
> -RPI_FIRMWARE_VERSION = 83dafbc92c0e63f76ca2ecdd42462d56489d1c77
> +RPI_FIRMWARE_VERSION = 3590de0c181d433af368a95f15bc480bdaff8b47

  This version comes from the stable branch, while previous versions were on the 
master branch. I think that is a good idea in fact, but it should be mentioned 
in the commit message.

  Regards,
  Arnout


>   RPI_FIRMWARE_SITE = $(call github,raspberrypi,firmware,$(RPI_FIRMWARE_VERSION))
>   RPI_FIRMWARE_LICENSE = BSD-3-Clause
>   RPI_FIRMWARE_LICENSE_FILES = boot/LICENCE.broadcom
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 1/3] package/rpi-firmware: bump version to v1.20240529

[Gael PORTAY]

Hello,

[I hope I am not responding in HTML, I have no choice but to use a new e-mail since today].

________________________________________
De : buildroot <buildroot-bounces@buildroot.org> de la part de Arnout Vandecappelle via buildroot <buildroot@buildroot.org>
Envoyé : vendredi 21 juin 2024 23:49
À : Athaariq Ardhiansyah; buildroot@buildroot.org
Cc : Martin Bark; Mahyar Koshkouei; Fiona Klute
Objet : Re: [Buildroot] [PATCH v3 1/3] package/rpi-firmware: bump version to v1.20240529

  Hi Athaariq,

On 04/06/2024 01:09, Athaariq Ardhiansyah wrote:
> Latest RPi firmware already provided support for Raspberry Pi 5.
>

The raspberrypi firmware is embeeded in the EEPROM.

That package maintains the bootloader for pi, pi2, pi3, pi zero, pi zero 2 and their variants, and some videocore files for all pi at the exception of the pi5.

The bootloader and vc files are external files loaded by the SoC IIRC, few tips in my initial serie for pi5 https://lore.kernel.org/all/ZawN46u8W5x-Mj-T@landeda/T/ (and tell me if I am wrong).

Note: The bootloaders for the pi4, pi400, cm4, pi5 live there https://github.com/raspberrypi/rpi-eeprom

So, that comment is misleading to my eyes, unless if by firmware you think of device-tree blobs (required to boot the system and shipped by that package).

> Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
>
> ---
> Changes v1 -> v2:
>    - Fix missing description due to terminal issue
> ---
>   package/rpi-firmware/Config.in         | 5 +++++
>   package/rpi-firmware/rpi-firmware.hash | 2 +-
>   package/rpi-firmware/rpi-firmware.mk   | 2 +-
>   3 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/package/rpi-firmware/Config.in b/package/rpi-firmware/Config.in
> index a9aeaed745..e4de5ddaa3 100644
> --- a/package/rpi-firmware/Config.in
> +++ b/package/rpi-firmware/Config.in
> @@ -63,6 +63,11 @@ config BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI4_DB
>       help
>         The debug set of files for versions 4.
>
> +config BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI5

  This symbol isn't used in the .mk file, so what's the point of defining it at
all? These variant symbols are not part of a choice, which means that for
variants that don't need specific boot firmware, you don't need to have an
option at all.

  In fact, AFAICS for RPi5, no firmware is installed at all... The only thing
that gets installed is the config.txt which is copied from board/raspberrypi.
It's a bit silly to download a 185MB archive and then not use it at all!
Wouldn't it make more sense to handle the config.txt in the post-image script?

  So, I think this symbol should be dropped, and I think that probably we
shouldn't enable rpi-firmware in raspberrypi5_defconfig.

Arnout, I agree, that symbol is unneeded.

However, BR requires that package to install the device-tree to boot the system because of the device-trees and device-tree overlays.

And I agree, there is possible work to get rid of that package for pi5.

BR could provides its own bare minimal config.txt for every pi, it can be overriden by menuconfig.

Also, I have that attempt to install the dtb and dtbo from the kernel package instead of using the ones from the rpi-firmware package.

https://patchwork.ozlabs.org/project/buildroot/patch/20240412140945.1626579-2-gael.portay@rtone.fr/ 

> +     bool "rpi 5"
> +     help
> +       The default set of files for versions 5.
> +
>   config BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE
>       string "Path to a file stored as boot/config.txt"
>       help
> diff --git a/package/rpi-firmware/rpi-firmware.hash b/package/rpi-firmware/rpi-firmware.hash
> index 33e05a2f4a..57afe3a1e5 100644
> --- a/package/rpi-firmware/rpi-firmware.hash
> +++ b/package/rpi-firmware/rpi-firmware.hash
> @@ -1,3 +1,3 @@
>   # Locally computed
> -sha256  dd43e77ca1a8969cdb7f05dd72a57f90862071d5a93bdd6aea8246aba85689cf  rpi-firmware-83dafbc92c0e63f76ca2ecdd424> diff --git a/package/rpi-firmware/rpi-firmware.hash b/package/rpi-firmware/rpi-firmware.hash
> index 33e05a2f4a..57afe3a1e5 100644
> --- a/pac62d56489d1c77.tar.gz
> +sha256  a116479e4e8e3bae354860d00321e5df5010cdbe10a3db9e59c81858a0aec84d  rpi-firmware-3590de0c181d433af368a95f15bc480bdaff8b47.tar.gz
>   sha256  c7283ff51f863d93a275c66e3b4cb08021a5dd4d8c1e7acc47d872fbe52d3d6b  boot/LICENCE.broadcom
> diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
> index 11177aee02..5eef3974d3 100644
> --- a/package/rpi-firmware/rpi-firmware.mk
> +++ b/package/rpi-firmware/rpi-firmware.mk
> @@ -4,7 +4,7 @@
>   #
>   ################################################################################
>
> -RPI_FIRMWARE_VERSION = 83dafbc92c0e63f76ca2ecdd42462d56489d1c77
> +RPI_FIRMWARE_VERSION = 3590de0c181d433af368a95f15bc480bdaff8b47

  This version comes from the stable branch, while previous versions were on the
master branch. I think that is a good idea in fact, but it should be mentioned
in the commit message.

  Regards,
  Arnout


>   RPI_FIRMWARE_SITE = $(call github,raspberrypi,firmware,$(RPI_FIRMWARE_VERSION))
>   RPI_FIRMWARE_LICENSE = BSD-3-Clause
>   RPI_FIRMWARE_LICENSE_FILES = boot/LICENCE.broadcom
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Regards,
Gaël
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 1/3] package/rpi-firmware: bump version to v1.20240529

[Thomas Petazzoni via buildroot]

Hello,

On Mon, 24 Jun 2024 08:31:57 +0000
Gael PORTAY <gael.portay@rtone.fr> wrote:

> [I hope I am not responding in HTML, I have no choice but to use a new e-mail since today].

Argh, your HTML e-mail is a mess.

> Arnout, I agree, that symbol is unneeded.
> 
> However, BR requires that package to install the device-tree to boot
> the system because of the device-trees and device-tree overlays.

Apparently, not in the case of RPi5, because the patch from Athaariq
has:

+BR2_PACKAGE_RPI_FIRMWARE=y
+BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI5=y
+BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE="board/raspberrypi5/config_5.txt"

so neither BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS nor
BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS are enabled. Therefore
the rpi-firmware package does not install DTBs or DTBOs.

> And I agree, there is possible work to get rid of that package for
> pi5.
> 
> BR could provides its own bare minimal config.txt for every pi, it
> can be overriden by menuconfig.
> 
> Also, I have that attempt to install the dtb and dtbo from the kernel
> package instead of using the ones from the rpi-firmware package.
> 
> https://patchwork.ozlabs.org/project/buildroot/patch/20240412140945.1626579-2-gael.portay@rtone.fr/ 

OK, but for the time being, I wouldn't mind to see a RPi 5
configuration merged that works in the current setup. Then we can
improve later on. We really want to have a RPi5 configuration in
Buildroot soon.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 1/3] package/rpi-firmware: bump version to v1.20240529

[Gael PORTAY]

Hello all,

> ________________________________________
> De : Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Envoyé : vendredi 12 juillet 2024 16:48
> À : Gael PORTAY
> Cc : Athaariq Ardhiansyah; buildroot@buildroot.org; Arnout Vandecappelle; Martin Bark; Fiona Klute; Mahyar Koshkouei
> Objet : Re: [Buildroot] [PATCH v3 1/3] package/rpi-firmware: bump version to v1.20240529
>
> Attention: Il s'agit d'un courriel externe et pourrait être malveillant. Veuillez vérifier que vous reconnaissez l'adresse e-mail avant d'ouvrir les liens ou pièces jointes.
>
>
> Hello,
>
> On Mon, 24 Jun 2024 08:31:57 +0000
> Gael PORTAY <gael.portay@rtone.fr> wrote:
>
> > [I hope I am not responding in HTML, I have no choice but to use a new e-mail since today].
>
> Argh, your HTML e-mail is a mess.
>

Argh, I am fighting with that e-mail client...
The good new is I send e-mail in raw format, the bad is I HAVE TO format it myself (prefix every lines by >).
I have CC'ed myself with personnal e-mail to respond with an appropriate e-mail client in the future (saving my mind at the same time).
So this is an utlimate test (finger crossed).

> > Arnout, I agree, that symbol is unneeded.
> >
> > However, BR requires that package to install the device-tree to boot
> > the system because of the device-trees and device-tree overlays.
>
> Apparently, not in the case of RPi5, because the patch from Athaariq
> has:
>
> +BR2_PACKAGE_RPI_FIRMWARE=y
> +BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI5=y
> +BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE="board/raspberrypi5/config_5.txt"
>
> so neither BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS nor
> BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS are enabled. Therefore
> the rpi-firmware package does not install DTBs or DTBOs.
>

Indeed, you are right, neither dtb, nor dtbo are installed by rpi-firmware.

The current raspberrypi5_defconfig sets BR2_PACKAGE_RPI_FIRMWARE=y to install the file config.txt specific to pi5.

The BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS is unset since the config.txt does not need for overlays.
The pi5 has its own dedicated console, and thus, the miniuart-bt.dtbo, is uneeded.
Thus, there is no dtb-overlay that is required to boot a pi5 for hackers.

The dtb is installed by the kernel, and BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS is to be used for old kernels <= 3.18.

        config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS
                bool "Install Device Tree Blobs (DTBs)"
                default y
                depends on !BR2_LINUX_KERNEL_DTS_SUPPORT
                help
                  If you are using a Linux kernel <= 3.18, you should say 'y'
                  here.

                  If you are using a Linux kernel >= 3.19, you should say 'n'
                  here, and enable BR2_LINUX_KERNEL_DTS_SUPPORT to let the
                  kernel build the DTB.

The patch from Athaariq introduces the config BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI5 for the pi5.
That option was used by the former pis to install firmware blobs; the pi5 has no more firmware blobs.

And, it is **unused** by the rpi-firmware package.
Instead, it is used to disable the packages rpi-userland and raspi-gpio.

IMO, it is inappropriate.
Instead, the packages should have an _ARCH_SUPPORTS config that depends on the pi5 CPU of whatsover (BR2_cortex_a76_a55?) .

Note: The config.txt in the patch from Athaariq is more complete, the current one is way more minimal. It is a matter of taste, I do prefer minimal config.

> > And I agree, there is possible work to get rid of that package for
> > pi5.
> >
> > BR could provides its own bare minimal config.txt for every pi, it
> > can be overriden by menuconfig.
> >
> > Also, I have that attempt to install the dtb and dtbo from the kernel
> > package instead of using the ones from the rpi-firmware package.
> >

Fix: the rpi-firmware **DOES NOT** install the dtb, unless BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS is set (I guess).
the rpi-firmware installs the dtbo **ONLY**.
(my bad, sorry).

> > https://patchwork.ozlabs.org/project/buildroot/patch/20240412140945.1626579-2-gael.portay@rtone.fr/
>
> OK, but for the time being, I wouldn't mind to see a RPi 5
> configuration merged that works in the current setup. Then we can
> improve later on. We really want to have a RPi5 configuration in
> Buildroot soon.
>

Note: Remember that dtb-overlays is a downstream feature, so it is a bit weird to enable it in linux.mk. I have no alternative approach for now.

FWIW, I have just tested it, and I can boot the sdcard.img correctly.
I have probably missed the issue... because, BR is actually working on a pi5 :/

> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com/

Regards,
Gaël
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 1/3] package/rpi-firmware: bump version to v1.20240529

[Gael PORTAY]

Hello,

> ________________________________________
> De : Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Envoyé : vendredi 12 juillet 2024 16:48
> À : Gael PORTAY
> Cc : Athaariq Ardhiansyah; buildroot@buildroot.org; Arnout Vandecappelle; Martin Bark; Fiona Klute; Mahyar Koshkouei
> Objet : Re: [Buildroot] [PATCH v3 1/3] package/rpi-firmware: bump version to v1.20240529
>
> Attention: Il s'agit d'un courriel externe et pourrait être malveillant. Veuillez vérifier que vous reconnaissez l'adresse e-mail avant d'ouvrir les liens ou pièces jointes.
>
>
> Hello,
>
> On Mon, 24 Jun 2024 08:31:57 +0000
> Gael PORTAY <gael.portay@rtone.fr> wrote:
>
> > [I hope I am not responding in HTML, I have no choice but to use a new e-mail since today].
>
> Argh, your HTML e-mail is a mess.
>

The good new it the
> > Arnout, I agree, that symbol is unneeded.
> >
> > However, BR requires that package to install the device-tree to boot
> > the system because of the device-trees and device-tree overlays.
>
> Apparently, not in the case of RPi5, because the patch from Athaariq
> has:
>
> +BR2_PACKAGE_RPI_FIRMWARE=y
> +BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI5=y
> +BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE="board/raspberrypi5/config_5.txt"
>
> so neither BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS nor
> BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS are enabled. Therefore
> the rpi-firmware package does not install DTBs or DTBOs.
>

> > And I agree, there is possible work to get rid of that package for
> > pi5.
> >
> > BR could provides its own bare minimal config.txt for every pi, it
> > can be overriden by menuconfig.
> >
> > Also, I have that attempt to install the dtb and dtbo from the kernel
> > package instead of using the ones from the rpi-firmware package.
> >
> > https://patchwork.ozlabs.org/project/buildroot/patch/20240412140945.1626579-2-gael.portay@rtone.fr/
>
> OK, but for the time being, I wouldn't mind to see a RPi 5
> configuration merged that works in the current setup. Then we can
> improve later on. We really want to have a RPi5 configuration in
> Buildroot soon.
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com/

Gaël
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v3 1/3] package/rpi-firmware: bump version to v1.20240529

[Thomas Petazzoni via buildroot]

On Tue,  4 Jun 2024 06:09:34 +0700
Athaariq Ardhiansyah <foss@athaariq.my.id> wrote:

> Latest RPi firmware already provided support for Raspberry Pi 5.
> 
> Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
> 
> ---
> Changes v1 -> v2:
>   - Fix missing description due to terminal issue
> ---
>  package/rpi-firmware/Config.in         | 5 +++++
>  package/rpi-firmware/rpi-firmware.hash | 2 +-
>  package/rpi-firmware/rpi-firmware.mk   | 2 +-
>  3 files changed, 7 insertions(+), 2 deletions(-)

Considering the comments received, I have marked PATCH 1/3 and 3/3 as
Changes Requested in our patch tracking system.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 3/3] board/raspberrypi: add support for Raspberry Pi 5

[Athaariq Ardhiansyah]

Since the last Raspberry Pi 5 submission has no progress, I'm submitting
these patches anyway. The newly released Raspberry Pi 5 board shares
similar software structure except it has less proprietary API.
Therefore, rpi-userland and all of raspberry-centric GPIO utilities are
no longer supported.

Keep in mind that RPi 5 has no native 32-bit support for both kernel and
userspace binary due to Cortex-A76 processor specification. That is the
reason why I did not add _64.

Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

---
Changes v1 -> v2:
  - Fix missing newlines due to terminal issue
---
 board/raspberrypi/config_5.txt | 65 ++++++++++++++++++++++++++++++++++
 board/raspberrypi5             |  1 +
 configs/raspberrypi5_defconfig | 46 ++++++++++++++++++++++++
 package/raspi-gpio/Config.in   |  4 +++
 package/rpi-userland/Config.in |  3 ++
 5 files changed, 119 insertions(+)
 create mode 100644 board/raspberrypi/config_5.txt
 create mode 120000 board/raspberrypi5
 create mode 100644 configs/raspberrypi5_defconfig

diff --git a/board/raspberrypi/config_5.txt b/board/raspberrypi/config_5.txt
new file mode 100644
index 0000000000..2e470fff99
--- /dev/null
+++ b/board/raspberrypi/config_5.txt
@@ -0,0 +1,65 @@
+# Please note that this is only a sample, we recommend you to change it to fit
+# your needs.
+# You should override this file using BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE.
+# See http://buildroot.org/manual.html#rootfs-custom
+# and http://elinux.org/RPiconfig for a description of config.txt syntax
+
+# Raspberry Pi 5 has no start.elf and fixup.dat files due to the existence of
+# Bootloader EEPROM
+
+kernel=Image
+
+# To use an external initramfs file
+#initramfs rootfs.cpio.gz
+
+# Automatically load initramfs files, if found
+auto_initramfs=1
+
+# Uncomment some or all of these to enable the optional hardware interfaces
+#dtparam=i2c_arm=on
+#dtparam=i2s=on
+#dtparam=spi=on
+
+# Enable audio (loads snd_bcm2835)
+dtparam=audio=on
+
+# Automatically load overlays for detected cameras
+camera_auto_detect=1
+
+# Automatically load overlays for detected DSI displays
+display_auto_detect=1
+
+# Enable DRM VC4 V3D driver
+dtoverlay=vc4-kms-v3d-pi5
+max_framebuffers=2
+
+# Don't have the firmware create an initial video= setting in cmdline.txt.
+# Use the kernel's default instead.
+disable_fw_kms_setup=1
+
+# Disable overscan assuming the display supports displaying the full resolution
+# If the text shown on the screen disappears off the edge, comment this out
+disable_overscan=1
+
+# How much memory in MB to assign to the GPU on Pi models having
+# 256, 512 or 1024 MB total memory
+gpu_mem_256=100
+gpu_mem_512=100
+gpu_mem_1024=100
+
+# fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
+dtoverlay=miniuart-bt
+
+# enable autoprobing of Bluetooth driver without need of hciattach/btattach
+dtparam=krnbt=on
+
+# enable 64bits support
+arm_64bit=1
+
+# Run as fast as firmware / board allows
+arm_boost=1
+
+# Raspberry PI 5 won't use UART0 as terminal out of the box. We need to enable
+# this through config.txt
+enable_uart=1
+dtoverlay=uart0-pi5
diff --git a/board/raspberrypi5 b/board/raspberrypi5
new file mode 120000
index 0000000000..fcdafc81ed
--- /dev/null
+++ b/board/raspberrypi5
@@ -0,0 +1 @@
+raspberrypi
\ No newline at end of file
diff --git a/configs/raspberrypi5_defconfig b/configs/raspberrypi5_defconfig
new file mode 100644
index 0000000000..733838ab2e
--- /dev/null
+++ b/configs/raspberrypi5_defconfig
@@ -0,0 +1,46 @@
+BR2_aarch64=y
+BR2_cortex_a76=y
+
+# patches
+BR2_GLOBAL_PATCH_DIR="board/raspberrypi/patches"
+BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
+
+BR2_SYSTEM_DHCP="eth0"
+
+# Linux headers same as kernel, a 6.6 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_6=y
+
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
+BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,c1432b4bae5b6582f4d32ba381459f33c34d1424)/linux-c1432b4bae5b6582f4d32ba381459f33c34d1424.tar.gz"
+BR2_LINUX_KERNEL_DEFCONFIG="bcm2712"
+
+# Build the DTB from the kernel sources
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="broadcom/bcm2712-rpi-5-b"
+
+BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
+
+BR2_PACKAGE_RPI_FIRMWARE=y
+BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI5=y
+BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE="board/raspberrypi5/config_5.txt"
+
+# Required tools to create the SD image
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y
+
+# Filesystem / image
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="256M"
+BR2_TARGET_ROOTFS_EXT2_MKFS_OPTIONS="-O 64bit"
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi5/post-build.sh"
+BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi5/post-image.sh"
+
+# Enable compressed kernel module support
+BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y
+BR2_PACKAGE_KMOD_TOOLS=y
+BR2_PACKAGE_XZ=y
+BR2_PACKAGE_KMOD=y
+BR2_PACKAGE_HOST_KMOD_XZ=y
diff --git a/package/raspi-gpio/Config.in b/package/raspi-gpio/Config.in
index 32a9448335..19c796e4a7 100644
--- a/package/raspi-gpio/Config.in
+++ b/package/raspi-gpio/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_RASPI_GPIO
 	bool "raspi-gpio"
+	depends on !BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI5
 	help
 	  Tool to help debug / hack at the BCM283x GPIO. You can dump
 	  the state of a GPIO or (all GPIOs). You can change a GPIO
@@ -9,4 +10,7 @@ config BR2_PACKAGE_RASPI_GPIO
 	  registers, ignoring anything else that may be using them
 	  (like Linux drivers).
 
+	  WARNING: Raspberry Pi 5 is NOT supported. Use libgpiod2
+	           instead.
+
 	  https://github.com/RPi-Distro/raspi-gpio
diff --git a/package/rpi-userland/Config.in b/package/rpi-userland/Config.in
index 4219bdb9c4..a4fff821e1 100644
--- a/package/rpi-userland/Config.in
+++ b/package/rpi-userland/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_RPI_USERLAND
 	depends on BR2_arm || BR2_aarch64
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI5
 	depends on !BR2_STATIC_LIBS
 	select BR2_PACKAGE_HAS_LIBEGL if BR2_arm
 	select BR2_PACKAGE_HAS_LIBGLES if BR2_arm
@@ -16,6 +17,8 @@ config BR2_PACKAGE_RPI_USERLAND
 	  mmal, GLESv2, vcos, openmaxil, vchiq_arm, bcm_host, WFC,
 	  OpenVG.
 
+	  WARNING: Raspberry Pi 5 is NOT supported. Use mesa3d instead.
+
 	  https://github.com/raspberrypi/userland/
 
 if BR2_PACKAGE_RPI_USERLAND && BR2_arm
-- 
2.45.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot