[Buildroot] few patches for raspberrypi3_qt5we_defconfig

[Buildroot] few patches for raspberrypi3_qt5we_defconfig

[Stephan Lukits]

Good afternoon, on my way to build raspberrypi3_qt5we_defconfig with
buildroot 2024.02 I had to do the following patches in order to proceed.
I did NOT do these patches as described in
https://buildroot.org/downloads/manual/manual.html#submitting-patches
(I'm not there yet) but with 'quilt' so I put them all in this mail to
more aid the maintainer of 'raspberrypi3_qt5we_defconfig' then to
actually provide patches.

Following https://github.com/google/snappy/pull/169/files I made a
0001-check-NEON-for-ARMv8-CPUs.patch

Index: snappy-1.1.10/CMakeLists.txt
===================================================================
--- snappy-1.1.10.orig/CMakeLists.txt
+++ snappy-1.1.10/CMakeLists.txt
@@ -194,9 +194,9 @@ int main() {
  check_cxx_source_compiles("
  #include <arm_neon.h>
  int main() {
-  uint8_t val = 3, dup[8];
+  uint8_t val = 3;
    uint8x16_t v = vld1q_dup_u8(&val);
-  vst1q_u8(dup, v);
+  val = vmaxvq_u8(v);
    return 0;
  }" SNAPPY_HAVE_NEON)


Following 
https://lore.kernel.org/buildroot/20231025205233.1925727-1-kadir.c.yilmaz@gmail.com 
I made a 0003-python3.11-regex-error.patch

Index: 
qtwebengine-chromium-0ad2814370799a2161057d92231fe3ee00e2fe98/chromium/tools/metrics/ukm/ukm_model.py
===================================================================
--- 
qtwebengine-chromium-0ad2814370799a2161057d92231fe3ee00e2fe98.orig/chromium/tools/metrics/ukm/ukm_model.py
+++ 
qtwebengine-chromium-0ad2814370799a2161057d92231fe3ee00e2fe98/chromium/tools/metrics/ukm/ukm_model.py
@@ -42,7 +42,7 @@ _INDEX_TYPE = models.ObjectNodeType(
  _STATISTICS_TYPE =  models.ObjectNodeType(
      'statistics',
      attributes=[
-      ('export', str, r'^(?i)(|true|false)$'),
+      ('export', str, r'(?i)^(|true|false)$'),
      ],
      children=[
          models.ChildType(_QUANTILES_TYPE.tag, _QUANTILES_TYPE, 
multiple=False),
@@ -94,7 +94,7 @@ _EVENT_TYPE =  models.ObjectNodeType(
      'event',
      attributes=[
        ('name', str, r'^[A-Za-z0-9.]+$'),
-      ('singular', str, r'^(?i)(|true|false)$'),
+      ('singular', str, r'(?i)^(|true|false)$'),
      ],
      alphabetization=[
          (_OBSOLETE_TYPE.tag, _KEEP_ORDER),


Following 
https://salsa.debian.org/qt-kde-team/qt/qtwebengine/-/commit/32198a3e0694401b745b4d01add18cdcddf658b4 
I made a
0004-fix-building-with-gcc-12.patch

Index: 
qtwebengine-chromium-0ad2814370799a2161057d92231fe3ee00e2fe98/chromium/third_party/skia/src/utils/SkParseColor.cpp
===================================================================
--- 
qtwebengine-chromium-0ad2814370799a2161057d92231fe3ee00e2fe98.orig/chromium/third_party/skia/src/utils/SkParseColor.cpp
+++ 
qtwebengine-chromium-0ad2814370799a2161057d92231fe3ee00e2fe98/chromium/third_party/skia/src/utils/SkParseColor.cpp
@@ -8,6 +8,8 @@

  #include "include/utils/SkParse.h"

+#include <iterator>
+
  static constexpr const char* gColorNames[] = {
      "aliceblue",
      "antiquewhite",
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] few patches for raspberrypi3_qt5we_defconfig

[Thomas Petazzoni via buildroot]

Hello Stephan,

Thanks a lot for your e-mail and your contribution! Please see below
some feedback.

On Thu, 6 Jun 2024 10:19:25 +0200
Stephan Lukits <stephan.lukits@gmail.com> wrote:

> Good afternoon, on my way to build raspberrypi3_qt5we_defconfig with
> buildroot 2024.02 I had to do the following patches in order to proceed.
> I did NOT do these patches as described in
> https://buildroot.org/downloads/manual/manual.html#submitting-patches
> (I'm not there yet) but with 'quilt' so I put them all in this mail to
> more aid the maintainer of 'raspberrypi3_qt5we_defconfig' then to
> actually provide patches.

Thanks, but unfortunately, it means we are unable to apply them :-/

> Following https://github.com/google/snappy/pull/169/files I made a
> 0001-check-NEON-for-ARMv8-CPUs.patch
> 
> Index: snappy-1.1.10/CMakeLists.txt
> ===================================================================
> --- snappy-1.1.10.orig/CMakeLists.txt
> +++ snappy-1.1.10/CMakeLists.txt
> @@ -194,9 +194,9 @@ int main() {
>   check_cxx_source_compiles("
>   #include <arm_neon.h>
>   int main() {
> -  uint8_t val = 3, dup[8];
> +  uint8_t val = 3;
>     uint8x16_t v = vld1q_dup_u8(&val);
> -  vst1q_u8(dup, v);
> +  val = vmaxvq_u8(v);
>     return 0;
>   }" SNAPPY_HAVE_NEON)

I am not 100% sure because it's not the same patch, but I believe this
snappy issue has been fixed
by https://gitlab.com/buildroot.org/buildroot/-/commit/01f35f8875acc98adb670d789b256790e2418be8
which we merged today.

> Following 
> https://lore.kernel.org/buildroot/20231025205233.1925727-1-kadir.c.yilmaz@gmail.com 
> I made a 0003-python3.11-regex-error.patch

When you say "following", do you mind "in addition to" ? Seems like no,
your patch is the same
as https://lore.kernel.org/buildroot/20231025205233.1925727-1-kadir.c.yilmaz@gmail.com/.

> Index: 
> qtwebengine-chromium-0ad2814370799a2161057d92231fe3ee00e2fe98/chromium/tools/metrics/ukm/ukm_model.py
> ===================================================================
> --- 
> qtwebengine-chromium-0ad2814370799a2161057d92231fe3ee00e2fe98.orig/chromium/tools/metrics/ukm/ukm_model.py
> +++ 
> qtwebengine-chromium-0ad2814370799a2161057d92231fe3ee00e2fe98/chromium/tools/metrics/ukm/ukm_model.py
> @@ -42,7 +42,7 @@ _INDEX_TYPE = models.ObjectNodeType(
>   _STATISTICS_TYPE =  models.ObjectNodeType(
>       'statistics',
>       attributes=[
> -      ('export', str, r'^(?i)(|true|false)$'),
> +      ('export', str, r'(?i)^(|true|false)$'),
>       ],
>       children=[
>           models.ChildType(_QUANTILES_TYPE.tag, _QUANTILES_TYPE, 
> multiple=False),
> @@ -94,7 +94,7 @@ _EVENT_TYPE =  models.ObjectNodeType(
>       'event',
>       attributes=[
>         ('name', str, r'^[A-Za-z0-9.]+$'),
> -      ('singular', str, r'^(?i)(|true|false)$'),
> +      ('singular', str, r'(?i)^(|true|false)$'),
>       ],
>       alphabetization=[
>           (_OBSOLETE_TYPE.tag, _KEEP_ORDER),
> 
> 
> Following 
> https://salsa.debian.org/qt-kde-team/qt/qtwebengine/-/commit/32198a3e0694401b745b4d01add18cdcddf658b4 
> I made a
> 0004-fix-building-with-gcc-12.patch

OK, thanks, need to fire up a build and reproduce the issue I guess.

Thanks,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot