[Buildroot] [PATCH 1/1] package/x265: fix armv6 cross compilation issue

[Buildroot] [PATCH 1/1] package/x265: fix armv6 cross compilation issue

[David Barbion]

When running a program that depends on x265, it crashes with the
message: illegal instruction

The package x265 was forcibly compiled with the gcc flag -mfpu=neon even
if the target CPU does not support the neon instruction set.
This fix adds the cmake flag CROSS_COMPILE_ARM to correctly set gcc flags
when compiling for ARMv6 architecture.

Signed-off-by: David Barbion <davidb@230ruedubac.fr>
---
 package/x265/x265.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/x265/x265.mk b/package/x265/x265.mk
index 51c39df4cd..ada7f1e4eb 100644
--- a/package/x265/x265.mk
+++ b/package/x265/x265.mk
@@ -35,4 +35,8 @@ else
 X265_CONF_OPTS += -DENABLE_CLI=OFF
 endif
 
+ifeq ($(BR2_ARM_CPU_ARMV6),y)
+X265_CONF_OPTS += -DCROSS_COMPILE_ARM=1
+endif
+
 $(eval $(cmake-package))
-- 
2.38.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/x265: fix armv6 cross compilation issue

[Thomas Petazzoni via buildroot]

Hello David,

On Sun, 27 Nov 2022 09:12:32 +0100
David Barbion <davidb@230ruedubac.fr> wrote:

> When running a program that depends on x265, it crashes with the
> message: illegal instruction
> 
> The package x265 was forcibly compiled with the gcc flag -mfpu=neon even
> if the target CPU does not support the neon instruction set.
> This fix adds the cmake flag CROSS_COMPILE_ARM to correctly set gcc flags
> when compiling for ARMv6 architecture.
> 
> Signed-off-by: David Barbion <davidb@230ruedubac.fr>
> ---
>  package/x265/x265.mk | 4 ++++
>  1 file changed, 4 insertions(+)

Sorry for the very, very long delay with which we are getting back to
you, and thanks for your investigation. Your patch was indeed fixing
the problem, but I took a step back and fixed a little more. See the
following two patches:

  https://gitlab.com/buildroot.org/buildroot/-/commit/9d62687d0024f7e3bac68157f1250970ef45abff
  https://gitlab.com/buildroot.org/buildroot/-/commit/1fbd26f83169a206bdf9c36c85510a33c0e7a864

Of course, if you're still working on your project, it would be great
to get a confirmation that those patches are still fixing the problem
for you.

Once again, thanks for your contribution!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/x265: fix armv6 cross compilation issue

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > Hello David,
 > On Sun, 27 Nov 2022 09:12:32 +0100
 > David Barbion <davidb@230ruedubac.fr> wrote:

 >> When running a program that depends on x265, it crashes with the
 >> message: illegal instruction
 >> 
 >> The package x265 was forcibly compiled with the gcc flag -mfpu=neon even
 >> if the target CPU does not support the neon instruction set.
 >> This fix adds the cmake flag CROSS_COMPILE_ARM to correctly set gcc flags
 >> when compiling for ARMv6 architecture.
 >> 
 >> Signed-off-by: David Barbion <davidb@230ruedubac.fr>
 >> ---
 >> package/x265/x265.mk | 4 ++++
 >> 1 file changed, 4 insertions(+)

 > Sorry for the very, very long delay with which we are getting back to
 > you, and thanks for your investigation. Your patch was indeed fixing
 > the problem, but I took a step back and fixed a little more. See the
 > following two patches:

 >   https://gitlab.com/buildroot.org/buildroot/-/commit/9d62687d0024f7e3bac68157f1250970ef45abff
 >   https://gitlab.com/buildroot.org/buildroot/-/commit/1fbd26f83169a206bdf9c36c85510a33c0e7a864

 > Of course, if you're still working on your project, it would be great
 > to get a confirmation that those patches are still fixing the problem
 > for you.

 > Once again, thanks for your contribution!

Committed those two fixes to 2024.02.x and 2024.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 1/1] package/x265: fix armv6 cross compilation issue

[David Barbion]

When running a program that depends on x265, it crashes with the
message: illegal instruction

The package x265 was forcibly compiled with the gcc flag -mfpu=neon even
if the target CPU does not support the neon instruction set.
This fix adds the cmake flag CROSS_COMPILE_ARM to correctly set gcc flags
when compiling for ARM architecture.

Signed-off-by: David Barbion <davidb@230ruedubac.fr>
---
 package/x265/x265.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/x265/x265.mk b/package/x265/x265.mk
index 51c39df4cd..e3a4acc6e5 100644
--- a/package/x265/x265.mk
+++ b/package/x265/x265.mk
@@ -35,4 +35,8 @@ else
 X265_CONF_OPTS += -DENABLE_CLI=OFF
 endif
 
+ifeq ($(BR2_arm)$(BR2_aarch64),y)
+X265_CONF_OPTS += -DCROSS_COMPILE_ARM=1
+endif
+
 $(eval $(cmake-package))
-- 
2.38.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/x265: fix armv6 cross compilation issue

[David Barbion]

Hello,

Sorry for disturbance, this patch makes compilaton on neon cpu fail.
I've pushed a new patch right now.

Le 26/11/2022 à 22:54, David Barbion a écrit :
> When running a program that depends on x265, it crashes with the
> message: illegal instruction
>
> The package x265 was forcibly compiled with the gcc flag -mfpu=neon even
> if the target CPU does not support the neon instruction set.
> This fix adds the cmake flag CROSS_COMPILE_ARM to correctly set gcc flags
> when compiling for ARM architecture.
>
> Signed-off-by: David Barbion <davidb@230ruedubac.fr>
> ---
>   package/x265/x265.mk | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/package/x265/x265.mk b/package/x265/x265.mk
> index 51c39df4cd..e3a4acc6e5 100644
> --- a/package/x265/x265.mk
> +++ b/package/x265/x265.mk
> @@ -35,4 +35,8 @@ else
>   X265_CONF_OPTS += -DENABLE_CLI=OFF
>   endif
>   
> +ifeq ($(BR2_arm)$(BR2_aarch64),y)
> +X265_CONF_OPTS += -DCROSS_COMPILE_ARM=1
> +endif
> +
>   $(eval $(cmake-package))
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot